From patchwork Thu Mar 20 11:08:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Micha=C5=82_Winiarski?= X-Patchwork-Id: 14023712 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7656C36002 for ; Thu, 20 Mar 2025 11:09:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A73F10E5E1; Thu, 20 Mar 2025 11:09:39 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="BvTWe9WO"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 977F110E5E3; Thu, 20 Mar 2025 11:09:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1742468978; x=1774004978; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=pGenS0jdjCavANN8tu7obTgo/3vZCXrShtkNWm4yQxU=; b=BvTWe9WO8eaAo+UYKKYtspeelGVcyQsl1hDJOaMtzqDw1oxVB+LBx06C B7RtkOqhY+k+W3cR4lxdxGFOpnvmcOrhMyeFQzpOiJFG02D01HoasdNbN CI6uJ4hLO7hM3dB41SbFczpFpR6g1eMDpS3Lxxl+TVNzRRMR2A0BskPki VVnkrgfOmbeN7yb2kwNIIY6ljCEZddqQXWPmxp7WdI3Tbd1Q31MFrELwq kfRXK8mYSLsLhxLGUW9+G8psysK0NrGfNzybjeGs3wDC23Vtbg6j8RpNs JwuIh4KRzS1X0Z7LpuuSelx9RiDSNMDJysDpx3hvIw8Igg45HuocbV1X7 w==; X-CSE-ConnectionGUID: 9x4UOqcTSpyGBEAkESl3aA== X-CSE-MsgGUID: 4R8uShHoRJK7+JNq72T3OQ== X-IronPort-AV: E=McAfee;i="6700,10204,11378"; a="43862541" X-IronPort-AV: E=Sophos;i="6.14,261,1736841600"; d="scan'208";a="43862541" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2025 04:09:37 -0700 X-CSE-ConnectionGUID: 1Sdl8fUzRE+m1+3gdMC+0Q== X-CSE-MsgGUID: I+ILEw+7Sr2iGTkbabCe1A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,261,1736841600"; d="scan'208";a="123073990" Received: from orsmsx903.amr.corp.intel.com ([10.22.229.25]) by orviesa006.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2025 04:09:38 -0700 Received: from ORSMSX901.amr.corp.intel.com (10.22.229.23) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14; Thu, 20 Mar 2025 04:09:36 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.14 via Frontend Transport; Thu, 20 Mar 2025 04:09:36 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Thu, 20 Mar 2025 04:09:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Bnwhm2Txi8I9XAH92cigpKrbvtnGN5Cv2DF1F1TMwoena+dvZUSEJNc/jpanWvpOqxpdipCzgwauO7FFa9npXHifc018BhjRUxYO/NFt/GRL7pPxbsxdICO/0IzKqQgALDa7LqT2WcbLu86XaQdxzc5rD4FKYgYMWQS/3pn6Puw+7fcnR24gnP/lzIg/Pduc9AT6Yvc8T9QM6YxyyfiPkKrOSocgzXadshG3f6vfXqULZJS2vvuwe2eH5rvcXLo135/H388tiWbke7T8tjl022LCwO1QVfwrn31lWbY1lF5HzqeHB9hzN5mXgHZVIrw+zS4Hh8UWZvXhwDDg4WGvlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YbJ8xxrQh44IfpvjHkN8qitPtzYJ0kzF1g8+h93xxbk=; b=MWaCzN1jBwMTVFI+fh/OBrh9e6q/Ut9jBIL/2J+OwjBzSDRAAhMgBRGz9LPyvHHo9Yf2RWOJHxzR/ZilfhzQLFaQ1VrVoeD565aLsxAUsEjbEv7qrNumoAeXGzKHW99NYaFAENvsLWETYBEG+Zn87SwCdJ9rl5Ki5zesCMuXfb6pbGHAjwih+zC448J1iNFlhmx8RnwqVki3+iBARYMa4HfXU7v7GUMaboyOR3Dixbgzv1v6Sa0tSt7w1ivZ48zq1apH8UaYQrAsprtqysqyzQxGnLXdAupYgDqExkUW50RET6CLV9859L49iDKnSypgYpqlGgeXeUVBr1Q6DunQew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB5373.namprd11.prod.outlook.com (2603:10b6:5:394::7) by SN7PR11MB6875.namprd11.prod.outlook.com (2603:10b6:806:2a6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.34; Thu, 20 Mar 2025 11:09:34 +0000 Received: from DM4PR11MB5373.namprd11.prod.outlook.com ([fe80::927a:9c08:26f7:5b39]) by DM4PR11MB5373.namprd11.prod.outlook.com ([fe80::927a:9c08:26f7:5b39%7]) with mapi id 15.20.8534.036; Thu, 20 Mar 2025 11:09:33 +0000 From: =?utf-8?q?Micha=C5=82_Winiarski?= To: , , , , "Bjorn Helgaas" , =?utf-8?q?Christian_K=C3=B6nig?= , =?utf-8?q?Krzy?= =?utf-8?q?sztof_Wilczy=C5=84ski?= , =?utf-8?q?Ilpo_J=C3=A4rvi?= =?utf-8?q?nen?= CC: Rodrigo Vivi , Michal Wajdeczko , Lucas De Marchi , =?utf-8?q?Thomas_Hellstr=C3=B6m?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matt Roper , =?utf-8?q?Micha=C5=82_Winiarski?= Subject: [PATCH v6 0/6] PCI: VF resizable BAR Date: Thu, 20 Mar 2025 12:08:48 +0100 Message-ID: <20250320110854.3866284-1-michal.winiarski@intel.com> X-Mailer: git-send-email 2.49.0 X-ClientProxiedBy: VI1P190CA0039.EURP190.PROD.OUTLOOK.COM (2603:10a6:800:1bb::20) To DM4PR11MB5373.namprd11.prod.outlook.com (2603:10b6:5:394::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB5373:EE_|SN7PR11MB6875:EE_ X-MS-Office365-Filtering-Correlation-Id: b6d7135f-4698-4753-c433-08dd679fb1bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?q?x4bIJ7BVnPWPPrU+x0uBGJEjGg0bRcq?= =?utf-8?q?ZswUlTqgYLXhqN/lQ34w7W8YVsHBWY/BYDcjc/GyIU4B72I0dmnr2ffeXMyRYKZvF?= =?utf-8?q?xRjul+v3YXqQjRhTqhn0HvRJtHjoZp8DU8WVfPtYxIwFLIOuRJfu2Oze5y6EHsgXr?= =?utf-8?q?bImQCYc3J3ANxvg0DVMdwiwuG1oc7d3VVV3gM9paAhQF264I5WTjhzyDGYGlkYxQh?= =?utf-8?q?XS8ULx6UElkqltbjkiyxAtnutYMQe/+OnbDUUOg5jnMU8qN7JT4TOHkFDuUmUOCri?= =?utf-8?q?zbQVOr0zc+Senpi5ST696IT9WCLk7EefC5rg659UeII8O0kl81lz4zoQFAds6b4V4?= =?utf-8?q?ZGItjcrG9nL9+BKxCUICP5fzKnLNdrIk0XIlGPxjOaFx6oYBrTqraN81ZclY/gtdT?= =?utf-8?q?fGun6LljjWJpPMlhhJBe1N1bjkDuVmanzJkjGbIsGtDfaakV+yQLUvuglq+i/Y/0w?= =?utf-8?q?RkxRhQZ+443FveWtiojOk00Pqv6Hm0j4Dupc3grTDhwhcg2rOjFNTQn4xwvmxsXfo?= =?utf-8?q?AWMdXho10Qfm5EP5cnkqrZsPtk82dLBGvbB+0FUSQUr5o3503b70T/oZg3YdsmfYw?= =?utf-8?q?B/2T46P9PMy6Y+N9gR9Ws2A8yIURV69fA0siMkFsQN6S0TpduRHtA2J6MZ8oyCA8m?= =?utf-8?q?wgDAllr290E5b/wKHzRkgNNXyjMRwaAsej/KrBhfBa7CL4+wDRa+72B54aVQxkmue?= =?utf-8?q?TTEZDBQtLuRoRWBDWUF91lzi+igDQPLrHOwmyWd+2QtUnYykHUWHBEf2lxh3Gr3YA?= =?utf-8?q?lsDut1GpmHe7jpIka6qRFMIiWJjjiqBYq9HlRM0mKy6FNaJJ7EirvZdawaNeUnb//?= =?utf-8?q?1hF//ZgQG92BqvgiNareE5Uz/PtzSFL6KQ6xP7stE6g6kooDT35kvNnbxWbPqP8b1?= =?utf-8?q?taXEgyDirGv60coXegp9dL7InLu+N07PC8UJ03OR6+2WZq5GGQK3OELa2PZp60796?= =?utf-8?q?DaX88ZYkxoRMTJC4aWfZC4/diNFGE/XTzfhv/XHf4dTYqjB91aM7O9TCzSzuPIsQQ?= =?utf-8?q?iup28k0MwAYDUPA8ONbU5nN/KQ38UcwfTmxkZkwgPPFg/FWM6GpgAk1E0cggTcqCT?= =?utf-8?q?TsnyBJwAJu3+cLuT+k984FUFLnCNnxT1Nv0Z3kVNWSBgj6bMPyDpKVAdumrMcgOLq?= =?utf-8?q?sPfxhNH9LciJ6Tyvwl8qnwb5+fzjJc8aQQEp7kC5UF6lFZp4BN1X/1R56cqSR6hRk?= =?utf-8?q?0W5Tsx7pB8IVQ4yvWgfN6/ko4WZ/r/GVQMpM96AWJhwFrWm46s36BcIYyqby3BIH8?= =?utf-8?q?dzAP1K0HO6Y7TuwaYUjccLVQ4oefuNo33jLBdKgnnksDmIrfvuEdSFGW7NnR3mkVI?= =?utf-8?q?0DXTIaP0l1mp?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB5373.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(7416014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?IZXZyXEfZba9CqGbJrQAGEcAqv97?= =?utf-8?q?hVhM+wz6uwHlTE5D7c3dEae0Y98cLcgPa3unORF/5M43YqiTg2Wdsk61yloUTQRqP?= =?utf-8?q?efwO19zY7LeJ6oCd0lfqlVudZ5a31OBy1795UZ4unbeKcp5QoMB04CU7a6cn8C7SP?= =?utf-8?q?ARhyfSG5MTLdw3CmNMBU78wHr6ocHgWnHG+Z9fYGznE3liEDKHrTo0JSjgCMnWAum?= =?utf-8?q?G5GxHtZqhzGzxeoFdL2RVLJKlD/y/H2W5Z9ODeLqnKB8P2wH9nZsiwSiABNMSPlOY?= =?utf-8?q?woMKmLlduTC3o/4zTyvkk+lBmUxd1DmTxbG/cqheuQpxel+/CzvTG3tMJbMAKv9ks?= =?utf-8?q?rGUm+IWi89ju8g+MKEvdF4sMWxsJHFzfDMMPz7w1njjOzHZHKCmWJmwv0yqRZcKoP?= =?utf-8?q?psjVWa+Xg5e4nHQWFR8v9EvcKCMF6W8udKDut4f5BvJ0umG79T/xXToeuYhINRCD+?= =?utf-8?q?i+3An8yAn7SAKFu2u/Pu0bT0WXrGvEwljMYC103S1Y3SBYDr97tElJC1uKTIJIL5Y?= =?utf-8?q?fFW8yxaGoW5YUwwq88uM3ZjVjIs/YArBEBIP4iiumMvH/9jgyyC/9V9Bvqs6mbxYr?= =?utf-8?q?9uAIVWokBIugGgQRHiItLYTV6jK6CJzDK5/0Im+1Obb+l2C3SlE2bMhEEB/w1VCOH?= =?utf-8?q?QBjUTeOloa2IU037oIXYfcJn/92sTuwr6LLXBt22xNx1RPRVhgor+7eC5Tb2A9q6s?= =?utf-8?q?cjGuhSTyUBF8CVgM+Aln3cyV+70+V2P2LawTNX64hW5ponttjpYW4Sd0XZMh23q2T?= =?utf-8?q?o3E6RGzRbMXuux2ElHB8e8IuspOfsDHk8eRjWwxqnNmU77PD9HrITAyLKQYnJ+bCE?= =?utf-8?q?s1LGtN41yDhHV4CRQq72ugKOyF54f+cTJKsoKE3tgtCbxjheFozcXRZX2jzwN6Ay8?= =?utf-8?q?YAAKIJod12hCa9NizU7fD6/3NhoORW4ptg7xQYCKrWTKXljRmzUVdcd3GrVxXEQaf?= =?utf-8?q?1sl+bShhKuOiySyMe7sN1pTky97mEfPuIU4JH6jEDE1mFbQzDYEPe2dXc6THTltz/?= =?utf-8?q?dmGH1VlID1AmQQxPIAKR9Y0qnR0h2D66tT0JMiHJ4d7b4qZjrS9XGtFcd/gAA+u0H?= =?utf-8?q?NBQTMV0RadoipjKX+RSRMKm9ppUtqSwCsRr89vnnwCOrSGsLwKhRXaQVWkIEOzUwL?= =?utf-8?q?gAhq22jLDXWQjzf0uFRr9WJQys08YkK3WtiYnn0Ef4ZRAki22QT06ubYZ0ox6mUSY?= =?utf-8?q?k1LPIx+M/Y41bZy6FQ5zho8w/wziW9zOHHu8xohuvjmotyd2pZ0aHAgb+UddESDyY?= =?utf-8?q?8F29vSDvxgSpdCC6euWf0AcZNN+KdcFePyfT7UVGYOmSmiFjjOafUFIjXYewNqBoV?= =?utf-8?q?mmYshCPDIbd3BpO6oawr9V8vDqV7xdLN8G0DV4Kh+ZwhERMe1+JywqsutaRnh1Jq0?= =?utf-8?q?XkRocWRGFn1QF3lhFm4IhCveYIM/gaj5JSox+/M0ISyyP4q1NNw+Fr4WubcCmPRn6?= =?utf-8?q?pmxUrlURIdifglduRqxHCR438ZyRMg1+2oVq8BGSBVA1JKqNeGjDPdLkZKbrANzfL?= =?utf-8?q?KjrzgcsvUY4dm9W+zmSD8dryPE/30R1xcw=3D=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b6d7135f-4698-4753-c433-08dd679fb1bc X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5373.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2025 11:09:33.7926 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WtHPOt0XK83n7nd+XZI3xBGENdfd8i0jRjmhDOIb8pX1WDN83B8faBtbjNISITsh+NjS6vICVbnE5x7tf9IKVvXCqtg0AQclme0dTYrLRjU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6875 X-OriginatorOrg: intel.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, Next relatively small update - now that the PCI cap for regular resizable BAR is cached, we're following suit with VF rebar cap. v5 can be found here: https://lore.kernel.org/linux-pci/20250312225949.969716-1-michal.winiarski@intel.com/ For regular BAR, drivers can use pci_resize_resource to resize it to the desired size provided that it is supported by the hardware, which the driver can query using pci_rebar_get_possible_sizes. This series expands the API to work with IOV BAR as well. It also adds the additional API for drivers to change the VF BAR size without resizing the entire underlying reservation (within the original resource boundary). Thanks, -Michał v5 -> v6: - Rebased on latest pci/next - Cache the VF resizable BAR capability position to avoid multiple lookups (Ilpo) - Use pci_resource_n helper (Ilpo) v4 -> v5: - Rename pci_resource_to/from_iov helpers and add WARN if called without CONFIG_PCI_IOV (Ilpo) - Reword kerneldoc for pci_iov_vf_bar_get_sizes (Bjorn) - Reword commit message for VF BAR size check, extract the additional size check to separate conditional (Bjorn) v3 -> v4: - Change the approach to extending the BAR (Christian) - Tidy the commit messages, use 80 line limit where necessary (Bjorn) - Add kerneldocs to exported functions (Bjorn) - Add pci_resource_to_iov() / pci_resource_from_iov() helpers (Ilpo) - Use FIELD_GET(), tidy whitespace (Ilpo) v2 -> v3: - Extract introducing pci_resource_is_iov to separate commit and use it elsewhere in PCI subsystem (Christian) - Extract restoring VF rebar state to separate commit (Christian) - Reorganize memory decoding check (Christian) - Don't use dev_WARN (Ilpo) - Fix build without CONFIG_PCI_IOV (CI) v1 -> v2: - Add pci_iov_resource_extend() and usage in Xe driver - Reduce the number of ifdefs (Christian) - Drop patch 2/2 from v1 (Christian) - Add a helper to avoid upsetting static analysis tools (Krzysztof) Michał Winiarski (6): PCI/IOV: Restore VF resizable BAR state after reset PCI: Add a helper to convert between VF BAR number and IOV resource PCI: Allow IOV resources to be resized in pci_resize_resource() PCI/IOV: Check that VF BAR fits within the reservation PCI: Allow drivers to control VF BAR size drm/xe/pf: Set VF LMEM BAR size drivers/gpu/drm/xe/regs/xe_bars.h | 1 + drivers/gpu/drm/xe/xe_pci_sriov.c | 22 +++++ drivers/pci/iov.c | 156 +++++++++++++++++++++++++++--- drivers/pci/pci.c | 8 +- drivers/pci/pci.h | 29 ++++++ drivers/pci/setup-bus.c | 3 +- drivers/pci/setup-res.c | 35 ++++++- include/linux/pci.h | 6 ++ include/uapi/linux/pci_regs.h | 1 + 9 files changed, 243 insertions(+), 18 deletions(-)