From patchwork Fri Mar 28 15:56:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arun R Murthy X-Patchwork-Id: 14032215 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2023CC36013 for ; Fri, 28 Mar 2025 16:12:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F091610EA5B; Fri, 28 Mar 2025 16:12:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="R61IFPdx"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id B67CB10EA5A; Fri, 28 Mar 2025 16:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1743178326; x=1774714326; h=from:subject:date:message-id:mime-version: content-transfer-encoding:to:cc; bh=QMBzNi/XxHC2OMo1Mt1AX2NKyMLtLdRaSbexFw3iPRw=; b=R61IFPdx5CHxy1vsBgl4/OXGxKspYcsBIJ+xvB1FWbmUgiRScltHeeYu cyBKp+U4SsA3S/pvsFanVl8ja3yqxdqYXZfLPGguPwOWUwvFdImOvFnif /KnVWfKMs9L6FLuP2aRxIV2iAkl3CF64o6Kx1MdsBik9ZZ07ZgxKcBd98 EHOtcteN0ruziaT1veAHjn7HUBNO9uxyz6+B7ghrrKx1sY/cpGYSS6KsX EsskpiR5uohXhvIdTyRxO7Leu/7Geg3Xmfh7nIN89Fbqmda9blf9QxS8K TIqiCIVHFQNRQlgfUoT3iPg+RIYn0UStnTClndQ/EVAYbWIlcknxg7ujO A==; X-CSE-ConnectionGUID: oRVOb24EQseOpJ1qCtV3+Q== X-CSE-MsgGUID: ZCS16+q6SzmY4gRDXDonBA== X-IronPort-AV: E=McAfee;i="6700,10204,11387"; a="55207095" X-IronPort-AV: E=Sophos;i="6.14,283,1736841600"; d="scan'208";a="55207095" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Mar 2025 09:10:56 -0700 X-CSE-ConnectionGUID: RX2a+yZ1RDiSOqI70ivZNA== X-CSE-MsgGUID: qp6Qkf6ySSiGyZPek+eDSg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,283,1736841600"; d="scan'208";a="129624809" Received: from srr4-3-linux-106-armuthy.iind.intel.com ([10.190.238.56]) by fmviesa003.fm.intel.com with ESMTP; 28 Mar 2025 09:10:53 -0700 From: Arun R Murthy Subject: [PATCH v11 0/5] Expose modifiers/formats supported by async flips Date: Fri, 28 Mar 2025 21:26:19 +0530 Message-Id: <20250328-asyn-v11-0-a50d13bfea0d@intel.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAKPG5mcC/12Oy26DMBBFfyXyukYzxq901f+ouhiMKZaKiWxiF UX8e03SqKjLezXnzrmx7FPwmb2ebiz5EnKYYw2ILyfmRoqfnoe+FkyAUIAgOOU18m4w2rRQG+d YPb0kP4Tv+877R81Dmie+jMnTE5aIaMGoFlUjtQY4c+SUrrFJzXRNy7i+hbj4r8bN0744hrzMa b2LFbXvPhQE2odCURy4IafISep6SQd+Vyj2D2rx17vYCoGTrvOKQOv+P4RwoMTzFVaI285Sj8I N7myO2LZtP27i5hVHAQAA X-Change-ID: 20250102-asyn-bf76730501cc To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: Jani Nikula , chaitanya.kumar.borah@intel.com, ville.syrjala@intel.com, Arun R Murthy , =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= , Naveen Kumar X-Mailer: b4 0.15-dev X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" All of the formats/modifiers supported by the plane during synchronous flips are nor supported by asynchronous flips. The formats/modifiers exposed to user by IN_FORMATS exposes all formats/modifiers supported by plane and this list varies for async flips. If the async flip supported formats/modifiers are exposed to the user, user based on this list can take decision to proceed or not and avoid flip failures during async flips. Discussion around this can be located @ https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29618#note_2487123 Mutter implementation for IN_FORMARTS_ASYNC under review @ https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4063 Xorg/modesetting patch https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1816 TODO: Upon merge of the patch related to async flip https://patchwork.freedesktop.org/patch/626849/?series=139807&rev=6 the patch 5 in this series will have to make use of the new function pointer can_async_flip(). v3: Add new plane->funcs format_mod_supported_async (Ville) Arun R Murthy (3): drm/plane: Add new plane property IN_FORMATS_ASYNC drm/plane: Expose function to create format/modifier blob drm/i915/display: Populate list of async supported formats/modifiers drivers/gpu/drm/drm_mode_config.c | 7 +++ drivers/gpu/drm/drm_plane.c | 50 ++++++++++++------ .../drm/i915/display/skl_universal_plane.c | 51 +++++++++++++++++++ include/drm/drm_mode_config.h | 6 +++ include/drm/drm_plane.h | 4 ++ 5 files changed, 103 insertions(+), 15 deletions(-) --- 2.25.1 --- Arun R Murthy (5): drm/plane: Add new plane property IN_FORMATS_ASYNC drm/plane: Expose function to create format/modifier blob drm/plane: Function to check async supported modifier/format drm/i915/display: Populate list of async supported formats/modifiers drm/i915/display: Add function for format_mod_supported_async drivers/gpu/drm/drm_mode_config.c | 7 ++ drivers/gpu/drm/drm_plane.c | 72 +++++++++---- drivers/gpu/drm/i915/display/skl_universal_plane.c | 113 ++++++++++++++++++--- include/drm/drm_mode_config.h | 6 ++ include/drm/drm_plane.h | 24 +++++ 5 files changed, 188 insertions(+), 34 deletions(-) --- base-commit: 08bd590935a5258ffd79355c59adffd72fb2c642 change-id: 20250102-asyn-bf76730501cc Best regards, -- Arun R Murthy --- Changes in v11: - EDITME: describe what is new in this series revision. - EDITME: use bulletpoints and terse descriptions. - Link to v10: https://lore.kernel.org/r/20250328-asyn-v10-0-8b8ad12cfc97@intel.com Changes in v9: - EDITME: describe what is new in this series revision. - EDITME: use bulletpoints and terse descriptions. - Link to v8: https://lore.kernel.org/r/20250312-asyn-v8-0-0c4cbe5a066d@intel.com Changes in v6: - EDITME: describe what is new in this series revision. - EDITME: use bulletpoints and terse descriptions. - Link to v5: https://lore.kernel.org/r/20250218-asyn-v5-0-7ac5ac4abd4a@intel.com --- Arun R Murthy (3): drm/plane: Add new plane property IN_FORMATS_ASYNC drm/plane: modify create_in_formats to accommodate async drm/i915/display: Add i915 hook for format_mod_supported_async drivers/gpu/drm/drm_mode_config.c | 7 +++ drivers/gpu/drm/drm_plane.c | 53 +++++++++++++++----- drivers/gpu/drm/i915/display/skl_universal_plane.c | 56 ++++++++++++++++------ include/drm/drm_mode_config.h | 6 +++ include/drm/drm_plane.h | 17 +++++++ 5 files changed, 112 insertions(+), 27 deletions(-) --- base-commit: bc7a84cbc968ce97e581e9e3c2d26fb0ac106482 change-id: 20250102-asyn-bf76730501cc Best regards, -- Arun R Murthy --- Arun R Murthy (3): drm/plane: Add new plane property IN_FORMATS_ASYNC drm/plane: modify create_in_formats to accommodate async drm/i915/display: Add i915 hook for format_mod_supported_async drivers/gpu/drm/drm_mode_config.c | 7 ++++ drivers/gpu/drm/drm_plane.c | 49 ++++++++++++++++------ drivers/gpu/drm/i915/display/i9xx_plane.c | 6 ++- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 30 ++++++++++++- drivers/gpu/drm/i915/display/intel_atomic_plane.h | 6 ++- drivers/gpu/drm/i915/display/intel_display.c | 11 +---- drivers/gpu/drm/i915/display/skl_universal_plane.c | 5 ++- include/drm/drm_mode_config.h | 6 +++ include/drm/drm_plane.h | 17 ++++++++ 9 files changed, 111 insertions(+), 26 deletions(-) --- base-commit: be5a404c3344b7d794766f045b8f94aa93c42069 change-id: 20250102-asyn-bf76730501cc Best regards, -- Arun R Murthy --- Arun R Murthy (3): drm/plane: Add new plane property IN_FORMATS_ASYNC drm/plane: modify create_in_formats to accommodate async drm/i915/display: Add i915 hook for format_mod_supported_async drivers/gpu/drm/drm_mode_config.c | 7 +++ drivers/gpu/drm/drm_plane.c | 52 ++++++++++++++++------ drivers/gpu/drm/i915/display/i9xx_plane.c | 6 ++- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 32 ++++++++++++- drivers/gpu/drm/i915/display/intel_atomic_plane.h | 6 ++- drivers/gpu/drm/i915/display/intel_display.c | 14 ++---- drivers/gpu/drm/i915/display/skl_universal_plane.c | 5 ++- include/drm/drm_mode_config.h | 6 +++ include/drm/drm_plane.h | 17 +++++++ 9 files changed, 117 insertions(+), 28 deletions(-) --- base-commit: aba848f9b752cf51474c0c3b1abcf0f572f774dc change-id: 20250102-asyn-bf76730501cc Best regards, -- Arun R Murthy --- Arun R Murthy (5): drm/plane: Add new plane property IN_FORMATS_ASYNC drm/plane: modify create_in_formats to acommodate async drm/i915/display: Acomodate format check in can_async_flip() drm/i915/display: Add i915 hook for format_mod_supported_async drm/i915/display: Indexed 8bit format does not support async flip drivers/gpu/drm/drm_mode_config.c | 7 +++ drivers/gpu/drm/drm_plane.c | 52 ++++++++++++++++------ drivers/gpu/drm/i915/display/i9xx_plane.c | 6 ++- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 22 ++++++++- drivers/gpu/drm/i915/display/intel_atomic_plane.h | 6 ++- drivers/gpu/drm/i915/display/intel_display.c | 14 ++---- drivers/gpu/drm/i915/display/skl_universal_plane.c | 5 ++- include/drm/drm_mode_config.h | 6 +++ include/drm/drm_plane.h | 17 +++++++ 9 files changed, 107 insertions(+), 28 deletions(-) --- base-commit: c1893793c7d3868fe083bdab33999178337b5561 change-id: 20250102-asyn-bf76730501cc Best regards, -- Arun R Murthy --- Arun R Murthy (5): drm/plane: Add new plane property IN_FORMATS_ASYNC drm/plane: modify create_in_formats to acommodate async drm/i915/display: Acomodate format check in intel_plane_can_async_flip() drm/i915/display: Add i915 hook for format_mod_supported_async drm/i915/display: Indexed 8bit format does not support async flip drivers/gpu/drm/drm_mode_config.c | 7 +++ drivers/gpu/drm/drm_plane.c | 52 ++++++++++++++++------ drivers/gpu/drm/i915/display/i9xx_plane.c | 6 ++- drivers/gpu/drm/i915/display/intel_atomic_plane.c | 18 +++++++- drivers/gpu/drm/i915/display/intel_atomic_plane.h | 6 ++- drivers/gpu/drm/i915/display/intel_display.c | 14 ++---- drivers/gpu/drm/i915/display/skl_universal_plane.c | 5 ++- include/drm/drm_mode_config.h | 6 +++ include/drm/drm_plane.h | 17 +++++++ 9 files changed, 103 insertions(+), 28 deletions(-) --- base-commit: 8a0f86f7106709c73acb1477af9ad5f267d7a340 change-id: 20250102-asyn-bf76730501cc Best regards,