From patchwork Tue Apr 1 09:37:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Zimmermann X-Patchwork-Id: 14034591 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 862F1C36014 for ; Tue, 1 Apr 2025 09:44:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB56B10E52F; Tue, 1 Apr 2025 09:44:30 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.b="b4Sw3zx2"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="8GQOPg8u"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="b4Sw3zx2"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="8GQOPg8u"; dkim-atps=neutral Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8019B10E553 for ; Tue, 1 Apr 2025 09:44:28 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 16F201F38D; Tue, 1 Apr 2025 09:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743500667; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=2AZKACvWm0D5MD4DHzUc9lfbQtTDe1uz4tBvrf9DrMk=; b=b4Sw3zx2ZQWxLgZSvDKkMSxAkKkGcyu7Adf8vWgY737Y54HILqkmydjkhD8w2tWvFShJ4V My3SOcy1dM2vLBKmhnGV8j+d/hCB/byFwGVyrKxfTwcAR/rzHjar26Spq/kveW3m6hUXEG 2d8XbgKL391SWQFAv/DMv8Ui9UMjqSM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743500667; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=2AZKACvWm0D5MD4DHzUc9lfbQtTDe1uz4tBvrf9DrMk=; b=8GQOPg8u83jNUPCSH5Dv5+dU/L/ulAyP9Cl+jXpiexa7VP2kpI6L+4eArv9v3216T3MyBL HB0kcf9rEKFuD0Aw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743500667; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=2AZKACvWm0D5MD4DHzUc9lfbQtTDe1uz4tBvrf9DrMk=; b=b4Sw3zx2ZQWxLgZSvDKkMSxAkKkGcyu7Adf8vWgY737Y54HILqkmydjkhD8w2tWvFShJ4V My3SOcy1dM2vLBKmhnGV8j+d/hCB/byFwGVyrKxfTwcAR/rzHjar26Spq/kveW3m6hUXEG 2d8XbgKL391SWQFAv/DMv8Ui9UMjqSM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743500667; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=2AZKACvWm0D5MD4DHzUc9lfbQtTDe1uz4tBvrf9DrMk=; b=8GQOPg8u83jNUPCSH5Dv5+dU/L/ulAyP9Cl+jXpiexa7VP2kpI6L+4eArv9v3216T3MyBL HB0kcf9rEKFuD0Aw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D004D138A5; Tue, 1 Apr 2025 09:44:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id TSSDMXq162dSBgAAD6G6ig (envelope-from ); Tue, 01 Apr 2025 09:44:26 +0000 From: Thomas Zimmermann To: javierm@redhat.com, jani.nikula@linux.intel.com, mripard@kernel.org, simona@ffwll.ch, airlied@gmail.com, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, Thomas Zimmermann Subject: [PATCH v3 00/18] drm: Provide helpers for system framebuffers and add efidrm/vesadrm Date: Tue, 1 Apr 2025 11:37:03 +0200 Message-ID: <20250401094056.32904-1-tzimmermann@suse.de> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,opensuse.org:url]; FREEMAIL_TO(0.00)[redhat.com,linux.intel.com,kernel.org,ffwll.ch,gmail.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_SEVEN(0.00)[8]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_DN_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FREEMAIL_ENVRCPT(0.00)[gmail.com] X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This series simplifies the existing ofdrm and simepldrm drivers, and adds new drivers for EFI- and VESA-based framebuffers. Existing drivers for system framebuffers, ofdrm and simpledrm, share much of their mode-setting pipeline. The major difference between the two drivers is in how they retrieve the framebuffer from the systems. Hence, it makes sense to share some of the pipeline implementation. With the shared helpers in place, we can then add dedicated drivers for EFI and VESA easily. Patches 1 to 3 clean up obsolete artifacts in ofdrm and simpledrm. Patch 4 moves both drivers from tiny/ into their own subdirectory sysfb/. The name aligns with the naming in drivers/firmware/sysfb.c to signal the connection. It's the firmware code that creates most of the system-framebuffer devices that these drivers operate on. The patch also adds a separate menu in Kconfig. Patches 5 to 11 unify the mode-setting pipeline between ofdrm and simpledrm. Either both drivers already use the same implementation or they can easily do so. There've been previous attempts to unify some of the drivers' code, but with little success. This time the helpers will be shared among 4 drivers, so it's already much more successful than before. Patch 12 adds EDID support to ofdrm. The EDID data can be found in some Macintosh's DeviceTree next to the framebuffer configuration. EDID support will be useful for EFI and VESA as well. Patch 13 adds another helper for screen_info that will be required by EFI and VESA drivers. Patch 14 and 15 add efidrm, a DRM driver that operates on EFI-provided framebuffers. It uses the shared sysfb helpers. The immediate benefit over simpledrm is the support for EFI's various types of memory caching on the framebuffer. Simpledrm only supported WriteCombine caching. There's also EDID support if the kernel's edid_info has been initialized. This feature needs to be implemented in the kernel's efistub library. Patches 16 to 18 add vesadrm, a DRM driver that operates on VESA- provided framebuffers. It is very much like efidrm, but tailored towards VESA features. It has EDID support and there's a patch at [1] for Grub to provide the data as part of the kernel's boot parameters. Vesadrm also supports gamma ramps. Together with EDID, this allows for gamma correction and night mode. Gnome already does that. Future directions: Efidrm requires EDID data that has to be provided by the efistub library. There is an EFI call to do so. Vesadrm currently requires a discrete color mode. Support for palette modes can be added later. There's still a bit of code duplication among palette handling. We have more drivers that use similar code for palette LUTs, such as ast and mgag200. We should try to provide generic palette helpers for all these drivers. This series has been tested on various devices that require the provided drivers. v3: - make EFI/VESA drivers depend on !SYSFB_SIMPLEFB (Javier) - clear unsupported EDID extension field v2: - simplify EDID logic (Jani) - use CONFIG_X86_32 instead of __i386__ [1] https://build.opensuse.org/projects/home:tdz:branches:Base:System/packages/grub2/files/grub2-provide-edid.patch?expand=1 Thomas Zimmermann (18): drm/ofdrm: Remove struct ofdrm_device.pdev drm/ofdrm: Open-code drm_simple_encoder_init() drm/simpledrm: Remove struct simpledrm_device.nformats drm: Move sysfb drivers into separate subdirectory drm/sysfb: Add struct drm_sysfb_device drm/sysfb: Provide single mode-init helper drm/sysfb: Merge mode-config functions drm/sysfb: Merge connector functions drm/sysfb: Maintain CRTC state in struct drm_sysfb_crtc_state drm/sysfb: Merge CRTC functions drm/sysfb: Merge primary-plane functions drm/sysfb: ofdrm: Add EDID support firmware: sysfb: Move bpp-depth calculation into screen_info helper drm/sysfb: Add efidrm for EFI displays drm/sysfb: efidrm: Add EDID support drm/sysfb: Add vesadrm for VESA displays drm/sysfb: vesadrm: Add EDID support drm/sysfb: vesadrm: Add gamma correction MAINTAINERS | 3 +- drivers/firmware/sysfb_simplefb.c | 31 +- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/sysfb/Kconfig | 76 +++ drivers/gpu/drm/sysfb/Makefile | 8 + drivers/gpu/drm/sysfb/drm_sysfb_helper.c | 324 ++++++++++ drivers/gpu/drm/sysfb/drm_sysfb_helper.h | 136 ++++ drivers/gpu/drm/sysfb/efidrm.c | 495 +++++++++++++++ drivers/gpu/drm/{tiny => sysfb}/ofdrm.c | 364 ++--------- drivers/gpu/drm/{tiny => sysfb}/simpledrm.c | 237 +------ drivers/gpu/drm/sysfb/vesadrm.c | 662 ++++++++++++++++++++ drivers/gpu/drm/tiny/Kconfig | 32 - drivers/gpu/drm/tiny/Makefile | 2 - drivers/video/screen_info_generic.c | 36 ++ include/linux/screen_info.h | 9 + include/video/pixel_format.h | 41 ++ 17 files changed, 1892 insertions(+), 567 deletions(-) create mode 100644 drivers/gpu/drm/sysfb/Kconfig create mode 100644 drivers/gpu/drm/sysfb/Makefile create mode 100644 drivers/gpu/drm/sysfb/drm_sysfb_helper.c create mode 100644 drivers/gpu/drm/sysfb/drm_sysfb_helper.h create mode 100644 drivers/gpu/drm/sysfb/efidrm.c rename drivers/gpu/drm/{tiny => sysfb}/ofdrm.c (75%) rename drivers/gpu/drm/{tiny => sysfb}/simpledrm.c (76%) create mode 100644 drivers/gpu/drm/sysfb/vesadrm.c create mode 100644 include/video/pixel_format.h