From patchwork Tue Apr 1 12:51:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jocelyn Falempe X-Patchwork-Id: 14034793 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9068EC3601B for ; Tue, 1 Apr 2025 12:58:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 55FBF10E58A; Tue, 1 Apr 2025 12:58:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="BLq2FijJ"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id DBD0C10E2DE for ; Tue, 1 Apr 2025 12:58:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743512318; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ZBPHk9cZuedRDs9pl9r5KL5+x0frCOEG1GupmWjuGtI=; b=BLq2FijJZSJ44hXunFrgWYS0HRf46Xht8o4jVwibP7ZPnVPtLOnCpWBcVkE8rr7+vSCFJ6 eY3o8XqT6aWPJM1m8d11G8tmrXmar3t/3N+TNUjAD1r+RpSrDy1d+6YMHlcCEPvCuvFNCl pn+OCWTYVhq+vwERplG1OIgGgc2ORA4= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-7bo5vYdoNfK-elKO9zWT7Q-1; Tue, 01 Apr 2025 08:58:35 -0400 X-MC-Unique: 7bo5vYdoNfK-elKO9zWT7Q-1 X-Mimecast-MFC-AGG-ID: 7bo5vYdoNfK-elKO9zWT7Q_1743512314 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 936451800258; Tue, 1 Apr 2025 12:58:33 +0000 (UTC) Received: from hydra.redhat.com (unknown [10.44.32.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C0A731956094; Tue, 1 Apr 2025 12:58:29 +0000 (UTC) From: Jocelyn Falempe To: Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Jocelyn Falempe Subject: [PATCH v6 0/8] drm/i915: Add drm_panic support Date: Tue, 1 Apr 2025 14:51:06 +0200 Message-ID: <20250401125818.333033-1-jfalempe@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This is a draft of drm_panic support for i915. I've tested it on the 4 intel laptops I have at my disposal. * Haswell with 128MB of eDRAM. * Comet Lake i7-10850H * Raptor Lake i7-1370P (with DPT, and Y-tiling). * Lunar Lake Ultra 5 228V (with DPT, and 4-tiling, and using the Xe driver. I tested panic in both fbdev console and gnome desktop. Best regards, v2: * Add the proper abstractions to build also for Xe. * Fix dim checkpatch issues. v3: * Add support for Y-tiled framebuffer when DPT is enabled. v4: * Add support for Xe driver, which shares most of the code. * Add support for 4-tiled framebuffer found in newest GPU. v5: * Rebase on top of git@gitlab.freedesktop.org:drm/i915/kernel.git drm-intel-next * Use struct intel_display instead of drm_i915_private. * Use iosys_map for intel_bo_panic_map(). v6: * Rebase on top of git@gitlab.freedesktop.org:drm/i915/kernel.git drm-intel-next * Use struct intel_display instead of drm_i915_private for intel_atomic_plane.c Jocelyn Falempe (8): drm/i915/fbdev: Add intel_fbdev_get_map() drm/i915/display/i9xx: Add a disable_tiling() for i9xx planes drm/i915/display: Add a disable_tiling() for skl planes drm/i915/gem: Add i915_gem_object_panic_map() drm/i915/display: Add drm_panic support drm/i915/display: Flush the front buffer in panic handler drm/i915/display: Add drm_panic support for Y-tiling with DPT drm/i915/display: Add drm_panic support for 4-tiling with DPT drivers/gpu/drm/i915/display/i9xx_plane.c | 23 +++ .../gpu/drm/i915/display/intel_atomic_plane.c | 169 +++++++++++++++++- drivers/gpu/drm/i915/display/intel_bo.c | 5 + drivers/gpu/drm/i915/display/intel_bo.h | 1 + .../drm/i915/display/intel_display_types.h | 2 + drivers/gpu/drm/i915/display/intel_fb_pin.c | 5 + drivers/gpu/drm/i915/display/intel_fb_pin.h | 2 + drivers/gpu/drm/i915/display/intel_fbdev.c | 5 + drivers/gpu/drm/i915/display/intel_fbdev.h | 6 +- .../drm/i915/display/skl_universal_plane.c | 27 +++ drivers/gpu/drm/i915/gem/i915_gem_object.h | 2 + drivers/gpu/drm/i915/gem/i915_gem_pages.c | 29 +++ drivers/gpu/drm/i915/i915_vma.h | 5 + drivers/gpu/drm/xe/display/intel_bo.c | 10 ++ drivers/gpu/drm/xe/display/xe_fb_pin.c | 5 + 15 files changed, 294 insertions(+), 2 deletions(-) base-commit: 010363c4618920838ca8777fdabd46871d289bf9