From patchwork Tue Feb 25 11:05:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 13989816 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB34AC021BB for ; Tue, 25 Feb 2025 11:05:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 047B610E4B9; Tue, 25 Feb 2025 11:05:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=live.com header.i=@live.com header.b="bDBcPXdN"; dkim-atps=neutral Received: from PNZPR01CU001.outbound.protection.outlook.com (mail-centralindiaazolkn19011025.outbound.protection.outlook.com [52.103.68.25]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D67010E4B9 for ; Tue, 25 Feb 2025 11:05:32 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=fPPmjORme1xK63vbmN8un7WUe1ERf/ofboa6KmeB/LCkx4Ko6IauEWP1WCxx0vVd1ApPKA8/9GSSHcNpVx+XSgMac/QDEMgLgs6qCYz7UZ4PumLrNoq0tXtGJyCjlNnkg7cUqE6wbsL6I09ezvUsoSSeBCapJx03Xam3u4DicoAtZx7sWPcsV24BVbalgailaN1uzZlV4WC3/kz7K/ysPcesvFeYeG+7mxAztjYO91PfL2ElO0l16hfLoyguOjid2CBrrTWNoC2kMz8HLHG2HY79jDmtE0NooBPin2l4PPH/HF7a4+HqvM1MgLoWOG4OtOqSvpmmSSIw59U/AO9hIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QLWwzwbpbd5xpPF3ZCQL8jDvqsW4lMuOOmP/GFwm/p8=; b=sWn/qW6IOWuCBawWuT03eS76P5r0jaujC17H01epSNjNTMMcxC8uHfsDo9b8tJZkVE7FicqjbTok5phvCpBHhZUDUtvmHTf55TnpgGkOpFMbXPKeBFnt+2b5PxL7MYIY/wp4QTF0nJ4iFbGZdAcfxO+dqX9G213fbEaoGJiWena1qjaFwL/H8ikTVW6+Z6yLJfnmqaIWwSY4xl7qdAzU929c5KZCKkfFycMTVLFIuNPQ0GGZNa9pn+1nWn8stBpDzi3Wfgy8GhWIr+dhXGgh3Yr/hH9fwLYIyxFw/INfDGyXn6oKJxcaBo0L0uQdW5SOzXPZZkJzDgJOHcmt8wYgfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QLWwzwbpbd5xpPF3ZCQL8jDvqsW4lMuOOmP/GFwm/p8=; b=bDBcPXdN0lxs4hAbGCrsFPG3A7Yh/CYTYKsL/cd603/GhhQU16uu1EgbGScMXbjikzXiY+8t3x96858g4judwko1PdaFWXHYTHC2waFWi6bg9Ud9VlIVt1fKRZTHUj/VKVBVdFdH7G9xMdFWVFZ+apsldVs63OL+nQBfdbIlis9qeOr2r+2R5VXoOccj8tNWPl0tHfX1LzqT6s9DbG3k8Ffxo2pXfU2Vt594FSWrcazJcaGxKp8nc693EwnHyd95f10odOCphrRSZODIuOAu9WLu2i+WaRmotugN+jmhp5hRrwKkibeV1+xrFCqwBU0cX4VqJCprne8xWRwF2xTSwQ== Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:f7::14) by MAZPR01MB8050.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:83::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.23; Tue, 25 Feb 2025 11:05:24 +0000 Received: from PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77]) by PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM ([fe80::324:c085:10c8:4e77%7]) with mapi id 15.20.8466.016; Tue, 25 Feb 2025 11:05:24 +0000 From: Aditya Garg To: "airlied@redhat.com" , "tzimmermann@suse.de" , "jfalempe@redhat.com" , "maarten.lankhorst@linux.intel.com" , "mripard@kernel.org" , "airlied@gmail.com" , "simona@ffwll.ch" , "kraxel@redhat.com" , "javierm@redhat.com" CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux.dev" , "andriy.shevchenko@linux.intel.com" Subject: [PATCH 0/6] drm: remove redundant else across drivers Thread-Topic: [PATCH 0/6] drm: remove redundant else across drivers Thread-Index: AQHbh3UrfSW2kiCPIEe4LvWM4YIbiQ== Date: Tue, 25 Feb 2025 11:05:24 +0000 Message-ID: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN3PR01MB9597:EE_|MAZPR01MB8050:EE_ x-ms-office365-filtering-correlation-id: 102750c1-6062-431c-ff2d-08dd558c4dc0 x-microsoft-antispam: BCL:0; ARA:14566002|19110799003|8062599003|8060799006|5062599005|7092599003|15080799006|12121999004|461199028|10035399004|4302099013|3412199025|440099028|41001999003|102099032|1602099012; x-microsoft-antispam-message-info: tg51dGkHr/h1UN+oGDBaEx0qzoskniwD17mJPUgWWg7At8nlZO2rfDVb3404JMh3I13NmtUOj2btXwwrvV7kZAk8j/k4fyT0Ip5zp+jHTQxF3aYrIJj3yzUzhRi6/wG4GvUxtbaDxll9F4AHiSog8+h3WD02/HkyFBPxAxc5K5pILxvqgFj9pJ9x9HQUNAK9CtRry88zwXf1/yEVOaU5f5qTcBqoI/N7IxRx0GzNAMhoIrdcYRgDYEdQNUDqLlrTSX0gAaXzpO9Y5ofHKdWGCseHuFwAOi2ubD/sAOBPTNX5+oggyJjrduEZNWfyLvD+i6S7s9DSozsmWW4zImlSB59LZX02PC6ZuPwWAd2rUWaIc6ejEZ+Uh4ec4Li8OOOYnrBzo6NzkEYaZy5UEWp7xuqDRzjvj2z5ppyhyuYL1rG79G7fgVQ5+KHvVhVrhFAgnbqO/hENjVclaY6E/XQ2WoMSNMSWnud85nx3s+Q9J1gzMcwWw62aZ8E/W7DQwDp9mnOUQWqkBEjfKXC+yueVSuunVfAnftJKPGjc9yoSq6zk7yNC6KexDZtytYqMhmt0rrNyUfQNU2A0VbT3jQkylqRJODidaMEnHAJmTuP2bsQnzPjvvWwX+adnv3kIKR91YbLjD5o4SmQGSev1Rgauc7AMjgEyHQm9Xznt+mT60DVkaMoM1pYghPJjkbuVbwqmo3+omJg11h8BXKKyjiy9+ylnG3q1x05q+ejie7BMkCrVh7+AD5wWAaVITPHgPZK95ba9jTpg9LnhFdE0gpSmB7aUgVE5OPkWKE4G8Or/ESHgjQDZFVnPlCxFnfupPjaxhr7vd9FdD77ngPzJxbteUf76+Yi8Z5PCP69Ly3OMXMGOs7MbzWg0sJJvBTVmh7cfIg5k4GTTmvFCzzJdjEVakGQLpxLXc2X4gay0+c7iF5NX4+JWfsW6W847K7cqHBmZRTsmjk7orax5Hgze/OcNtSPQ8tteLiZBR7WSoULnMna6+csB6KcZveXUfbG2HJVoIqkAzANPXx3FGKFN1EAg6cfAozK0LFs5Kg9Y09fG0ZJ1ZQYZl2YrX2fZQSQuDpRUgmlvyJnF0z4AoZALu8SQoOk6ICjx7QmnLdbfqWkmYfu5XzVhlma2wRKfDKDsy+YcF4jCQjCbMwIzg+3zSQsLYkueMOvxAADKorswCv3/ASVb/1jUV4OdrN04Q5cB58VnL6wm0XPeKpsxxCvD9QHEVN/camor6z+haCiYhuJNLuxhRrdz46o2N0gNrRK8szVquBpHkUoU2cWhFIZlt7XbaPYkRxcg0B6LOcmrPnAyTq3OevNG1gtpWufFBdOBnx0hankmKE6YEcEbQsMGb/urvQ== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: 2eK2l98bw4jx87Jk7NcgN607T4GPeyzbC2MtGPCt/LUOGQbR6HjZ/uj/KUXT4kJnmMX66xuFtLFT0GfTvC5uSqPzGusSJA2jLSdNmf6zTV3c0yi8DCv+N2qreno8YYAs8SUBKvkOEiwCXk0FDzhhYvrwWJv4yXZTmk9Oowz62u8pytCOCy/KxePaRlAeGknNuxOuLZnhl8wUVvIlZreSW2UT0PbJkAwAMV0M9IPFD05ElHExGBUyIPijXkvqL5jr71pJysCRcXq5vIjGHKXuMXsOqD754RVRhcSqkxK2o/K36BQdXmngw3p0x4vVZWPq5nUvbyCntx4xMTx1IyNhtQjPOwhcNuQ13Y7ArU2JUU2jwhgGtqVsQ8djyL2IY8zaI8y+NZKus7Z+zV2wiFbsxNOHjNrdHkBIqUtSJhWd5+pHcKR4crPf3pYtwIvlW98NZahing82VTvhMmU+vaDzRWqEuHHPZKC0X0ueG//jFfyrPf1lI2QN4+JuUWtpYaQDdb/jGRQ9D2Tx2j2ty+Nw0uN11JOVF4MDorSIwc8ZPQmh6txp+EodWopXaZcwQjicqf7DD8WmERmmATtG7ssMUiyLAOyvXmN311Q9J0KscbzYUGEyxSsrsVRN6QDhswMO+y+BImFSulYJJHhqwZSumw/biU2SCmDnkuBh/+Tm2JFv/axLhPuzX/kyRiGgshjqJiNWcqoXCZoHUCw95D95MPljUSlEvr0Ju4RevwxwpqXwhMY8rluhmiZ5AxQ7jbByGbbbsv4g3R8OoOnXwL0i+aTpywsROlxVTsNlxKT4PeYjyUd5xWq3HR2k/i2p7tsztd2fobB49fAhvCZm75KPrf/RzNzPZFbFJOInh1U+DyjqMacCxic9aVO7hA5GxQRwljkRbT5Qt5fJ/cij30+LyPIfNsaL/ZiRniyfbZ1dJztxUuqGtVOJ6WvOEcSF3gDo7CF/z/5QMjY45tNukus8Smogxvv7NVadHwHcv7x5M2ku0YlKLDkELlJ/lyB7zLjldJYJ2tb5+fM+Y7uN88MhSIRF0IXtfFsoPqjfOJ+IoYS2epnW36HVV2A6sTWMBy/PvP9xs5emJ4Cy83+O2UnPxDFKyymEU70YCIbeTAop9hsGBjfrFPxKnfIXS/lVh5/UTLaEeJuymRFbJzLX+8hdKoilWk97os4Vpt4FPQaMCO3R9b+JAmS6+Jy3QtP1qSE7utJOV409OHfUUmJLX081504U3vjUlvZACrEh3+vihb0oX8tg+Edoco9TAP5rDu4R0NMiXiot7MWG+Kym2tvtRuEj6nEICsvrXGyVnE7aunTnVgteBcZ6FV7zqrIChbb9 Content-ID: MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 102750c1-6062-431c-ff2d-08dd558c4dc0 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2025 11:05:24.4705 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MAZPR01MB8050 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In primary_plane_helper_atomic_check of various drm drivers, a redundant else statement is there. All these statements match this pattern: if (foo) return foo; else if (bar) return bar; Which is equivalent to: if (foo) return foo; if (bar) return bar; This error was observed by Andy Shevchenko [1] while reviewing the appletbdrm driver, which has been submitted upstream. A simple grep was used to find such errors. Most likely a common code was copied and pasted among these drivers. Some of them also seem to have been ported to use atomic helpers instead of simple_display_pipe. [1]: https://lore.kernel.org/dri-devel/Z7igVXqvRYTVFpXU@smile.fi.intel.com/ Aditya Garg (6): drm/ast: Remove redundant else in atomic_check drm/cirrus-qemu: Remove redundant else in atomic_check drm/offdrm: Remove redundant else in atomic_check drm/bochs: Remove redundant else in atomic_check drm/simpledrm: Remove redundant else in atomic_check drm/mgag200: Remove redundant else in atomic_check drivers/gpu/drm/ast/ast_mode.c | 5 +++-- drivers/gpu/drm/mgag200/mgag200_mode.c | 3 ++- drivers/gpu/drm/tiny/bochs.c | 3 ++- drivers/gpu/drm/tiny/cirrus-qemu.c | 6 ++++-- drivers/gpu/drm/tiny/ofdrm.c | 3 ++- drivers/gpu/drm/tiny/simpledrm.c | 3 ++- 6 files changed, 15 insertions(+), 8 deletions(-)