mbox series

[v3,0/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

Message ID cover.1597652012.git.agx@sigxcpu.org (mailing list archive)
Headers show
Series drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel | expand

Message

Guido Günther Aug. 17, 2020, 8:14 a.m. UTC 
The panel uses a Focaltech FT8006p, the touch part is handled by the already
existing edt-ft5x06. It can be found in e.g. the Librem 5.

Changes from v2:
- Due to review comments by Sam Ravnborg, thanks!
  https://lore.kernel.org/lkml/20200815212727.GA1244923@ravnborg.org/
  - Drop unused header
  - Use newline before comment
- Add Reviewed/Acked-by by Sam Ravnborg, thanks!
  https://lore.kernel.org/lkml/20200815212727.GA1244923@ravnborg.org/
  https://lore.kernel.org/lkml/20200815212750.GB1244923@ravnborg.org/
  https://lore.kernel.org/lkml/20200815212840.GC1244923@ravnborg.org/

Changes from v1:
- Due to review comments by Sam Ravnborg, thanks!
  https://lore.kernel.org/dri-devel/20200815083917.GA993113@ravnborg.org/
  - Don't preserve newlines with '|' in description
  - Use reset-gpios and backlight from panel-common.yaml
  - Reindent example
  https://lore.kernel.org/dri-devel/20200815093226.GB993113@ravnborg.org/
  - Drop unused includes
  - Use dev_* instead of DRM_* for printing
  - Turn off regulators in reverse order from enable
  - Silence errors in mantix_{shutdown,remove}
  - Drop duplicate mipi_dsi_dcs_enter_sleep_mode()
  https://lore.kernel.org/dri-devel/20200815100230.GA1002374@ravnborg.org/
  - Use dev_err_probe()
- Add delays when turning off panel as suggested by the data sheet

This series is against next-20200814.

Guido Günther (3):
  dt-bindings: vendor-prefixes: Add mantix vendor prefix
  dt-bindings: Add Mantix MLAF057WE51-X panel bindings
  drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

 .../display/panel/mantix,mlaf057we51-x.yaml   |  70 ++++
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 MAINTAINERS                                   |   7 +
 drivers/gpu/drm/panel/Kconfig                 |  11 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../gpu/drm/panel/panel-mantix-mlaf057we51.c  | 328 ++++++++++++++++++
 6 files changed, 419 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c

Comments

Sam Ravnborg Aug. 18, 2020, 5:05 p.m. UTC | #1 
Hi Guido.

On Mon, Aug 17, 2020 at 10:14:33AM +0200, Guido Günther wrote:
> 
> The panel uses a Focaltech FT8006p, the touch part is handled by the already
> existing edt-ft5x06. It can be found in e.g. the Librem 5.
> 
> Changes from v2:
> - Due to review comments by Sam Ravnborg, thanks!
>   https://lore.kernel.org/lkml/20200815212727.GA1244923@ravnborg.org/
>   - Drop unused header
>   - Use newline before comment
> - Add Reviewed/Acked-by by Sam Ravnborg, thanks!
>   https://lore.kernel.org/lkml/20200815212727.GA1244923@ravnborg.org/
>   https://lore.kernel.org/lkml/20200815212750.GB1244923@ravnborg.org/
>   https://lore.kernel.org/lkml/20200815212840.GC1244923@ravnborg.org/
> 
> Changes from v1:
> - Due to review comments by Sam Ravnborg, thanks!
>   https://lore.kernel.org/dri-devel/20200815083917.GA993113@ravnborg.org/
>   - Don't preserve newlines with '|' in description
>   - Use reset-gpios and backlight from panel-common.yaml
>   - Reindent example
>   https://lore.kernel.org/dri-devel/20200815093226.GB993113@ravnborg.org/
>   - Drop unused includes
>   - Use dev_* instead of DRM_* for printing
>   - Turn off regulators in reverse order from enable
>   - Silence errors in mantix_{shutdown,remove}
>   - Drop duplicate mipi_dsi_dcs_enter_sleep_mode()
>   https://lore.kernel.org/dri-devel/20200815100230.GA1002374@ravnborg.org/
>   - Use dev_err_probe()
> - Add delays when turning off panel as suggested by the data sheet
> 
> This series is against next-20200814.
> 
> Guido Günther (3):
>   dt-bindings: vendor-prefixes: Add mantix vendor prefix
>   dt-bindings: Add Mantix MLAF057WE51-X panel bindings
>   drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

Maxime Ripard backmerged -rc1 to drm-misc-next so I went ahead and applied
this series to drm-misc-next, forgetting you got commit rights. As they are
already pushed out too late for you to do push them - sorry!

	Sam

> 
>  .../display/panel/mantix,mlaf057we51-x.yaml   |  70 ++++
>  .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
>  MAINTAINERS                                   |   7 +
>  drivers/gpu/drm/panel/Kconfig                 |  11 +
>  drivers/gpu/drm/panel/Makefile                |   1 +
>  .../gpu/drm/panel/panel-mantix-mlaf057we51.c  | 328 ++++++++++++++++++
>  6 files changed, 419 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml
>  create mode 100644 drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c
> 
> -- 
> 2.26.2
Guido Günther Aug. 18, 2020, 5:33 p.m. UTC | #2 
Hi Sam,
On Tue, Aug 18, 2020 at 07:05:56PM +0200, Sam Ravnborg wrote:
> Hi Guido.
> 
> On Mon, Aug 17, 2020 at 10:14:33AM +0200, Guido Günther wrote:
> > 
> > The panel uses a Focaltech FT8006p, the touch part is handled by the already
> > existing edt-ft5x06. It can be found in e.g. the Librem 5.
> > 
> > Changes from v2:
> > - Due to review comments by Sam Ravnborg, thanks!
> >   https://lore.kernel.org/lkml/20200815212727.GA1244923@ravnborg.org/
> >   - Drop unused header
> >   - Use newline before comment
> > - Add Reviewed/Acked-by by Sam Ravnborg, thanks!
> >   https://lore.kernel.org/lkml/20200815212727.GA1244923@ravnborg.org/
> >   https://lore.kernel.org/lkml/20200815212750.GB1244923@ravnborg.org/
> >   https://lore.kernel.org/lkml/20200815212840.GC1244923@ravnborg.org/
> > 
> > Changes from v1:
> > - Due to review comments by Sam Ravnborg, thanks!
> >   https://lore.kernel.org/dri-devel/20200815083917.GA993113@ravnborg.org/
> >   - Don't preserve newlines with '|' in description
> >   - Use reset-gpios and backlight from panel-common.yaml
> >   - Reindent example
> >   https://lore.kernel.org/dri-devel/20200815093226.GB993113@ravnborg.org/
> >   - Drop unused includes
> >   - Use dev_* instead of DRM_* for printing
> >   - Turn off regulators in reverse order from enable
> >   - Silence errors in mantix_{shutdown,remove}
> >   - Drop duplicate mipi_dsi_dcs_enter_sleep_mode()
> >   https://lore.kernel.org/dri-devel/20200815100230.GA1002374@ravnborg.org/
> >   - Use dev_err_probe()
> > - Add delays when turning off panel as suggested by the data sheet
> > 
> > This series is against next-20200814.
> > 
> > Guido Günther (3):
> >   dt-bindings: vendor-prefixes: Add mantix vendor prefix
> >   dt-bindings: Add Mantix MLAF057WE51-X panel bindings
> >   drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel
> 
> Maxime Ripard backmerged -rc1 to drm-misc-next so I went ahead and applied
> this series to drm-misc-next, forgetting you got commit rights. As they are
> already pushed out too late for you to do push them - sorry!

On the contrary: Thanks a lot for handling this so promptly!
 -- Guido