From patchwork Mon Jul 4 12:07:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 12905649 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32012C433EF for ; Mon, 4 Jul 2022 16:19:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC54110F037; Mon, 4 Jul 2022 16:15:39 +0000 (UTC) Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5CA6E10E02D for ; Mon, 4 Jul 2022 12:08:10 +0000 (UTC) Received: by mail-pj1-x102b.google.com with SMTP id ju17so4034570pjb.3 for ; Mon, 04 Jul 2022 05:08:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=oRPwtSfaZ4lK+/Kwqo3hIoWwSAaNNETI/B4QeMlq4K0=; b=vJ8/VNDeZy+E+GejBNM7BapmNbdbn8iOiAYLS8BzvfKFvpk6CdR/Mnagao/Gw0H7jf LnQLiFNEht81PcZFPHiWhIaSCu70QDfOqAa6+yId1JCV4HSO1Unw3VcKXpVFK7l+uLAa 6tgC/XrPbB61OdJR18NqwpzOUGI4obFkG6Jsi69ZcVRV/RfsUIhvkkLWPN3KU8aReJTi AFIjCf42RSzRiBRGfKs+tzI9gBb1Ye1L96wXhT1ElmU6pn/qgv75K8/crdjKUUfOX3J/ noZLYEmHwmI1jmH5mN0RcBuHTxCbA/TegDWRR6awCiMU/3dx7+ZyEYVwegC7cot1yxTR zv0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=oRPwtSfaZ4lK+/Kwqo3hIoWwSAaNNETI/B4QeMlq4K0=; b=UyMhtdU2Fd/L+O3zcTKTZAsuuXTy7tIsvBrYsCOBrSj7x+lnzwEYmCw5mJg2BP8vGp oeL81BRgkDGkFc7EPhGLC6aESU/HyTwdfhBC9mzFR0Sfli0T0Wspci8uRyhX21dMhA6r sglg0RV3TOiNrB7BlgxHrNv6iB2Q/TFf08/Yk/seN7/XLPX0bCkI575zKE1DsaC8MVXw GMTucBkKAdweEVt/bM6AD7inlctLN4fiOuponz07OuXlwl9hBRmES0iYqYmklDfmJDCj kF8lL4MlwAOEqxdihJPuCtvGBpInBSpRSRB9Dz1aNGpC9/WonilVRgIwR8874MkG4tgv i5mA== X-Gm-Message-State: AJIora9KeG5TnoEFpQdViIRlBZD9+U7KsuvCj06THY14gJMyGsuLHk/H MiPy1rxnudCxWZX/CMXXYLERdA== X-Google-Smtp-Source: AGRyM1sM6QESGjlfD1GGt0oFtY+CVN6+kz3J/8IXAvOmEUXgWJ/VGwfVTka8Ig/8o207cGsoSgkOBA== X-Received: by 2002:a17:902:b184:b0:168:a310:3eb0 with SMTP id s4-20020a170902b18400b00168a3103eb0mr36007275plr.9.1656936490190; Mon, 04 Jul 2022 05:08:10 -0700 (PDT) Received: from localhost ([122.171.18.80]) by smtp.gmail.com with ESMTPSA id u4-20020a170902714400b0015e8d4eb28fsm21099493plm.217.2022.07.04.05.08.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jul 2022 05:08:09 -0700 (PDT) From: Viresh Kumar To: Alim Akhtar , Alyssa Rosenzweig , Andy Gross , Bjorn Andersson , Chanwoo Choi , Chen-Yu Tsai , Fabio Estevam , Ilia Lin , Jernej Skrabec , Jonathan Hunter , Krzysztof Kozlowski , Kyungmin Park , MyungJoo Ham , Nishanth Menon , NXP Linux Team , Patrice Chotard , Pengutronix Kernel Team , Qiang Yu , "Rafael J. Wysocki" , Rob Herring , Samuel Holland , Sascha Hauer , Shawn Guo , Stephen Boyd , Steven Price , Thierry Reding , Tomeu Vizoso , Viresh Kumar , Viresh Kumar , Yangtao Li Subject: [PATCH V3 00/20] OPP: Add new configuration interface: dev_pm_opp_set_config() Date: Mon, 4 Jul 2022 17:37:38 +0530 Message-Id: X-Mailer: git-send-email 2.31.1.272.g89b43f80a514 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Vincent Guittot , lima@lists.freedesktop.org, linux-pm@vger.kernel.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Dmitry Osipenko , linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello, We have too many configuration specific APIs currently, six of them already, like dev_pm_opp_set_regulators(). This makes it complex/messy for both the OPP core and its users to manage. There is also code redundancy in these APIs, in the way they add/manage the OPP table specific stuff. This patch series is an attempt to simplify these interfaces by adding a new interface, dev_pm_opp_set_config(), which is now used by all the existing ones. This series also migrates few users to the new API, where multiple configurations were required and rest are updated for API interface changes. This is pushed here: git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git opp/linux-next This was earlier tested by various folks, I have tested it again on hikey board, it will get further tested on linux-next in the coming days. Build test is already done by Linaro's bot for enough platform though. The entire patchset shall get merged via the OPP tree in 5.20-rc1, please do not merge individual patches. V2->V3: - Merged two patchsets: [PATCH V2 00/30] OPP: Add new configuration interface: dev_pm_opp_set_config() [PATCH V2 0/5] OPP: Replace custom set_opp() with config_regulators() - The existing APIs aren't removed anymore, but are made to use the new core API to set various configurations (Greg KH). - clk-names and regulator-names are NULL terminated arrays now (Greg KH). - New interface added: dev_pm_opp_set_config_regulators(). V1->V2: - dev_pm_opp_set_config() doesn't return the OPP table anymore, but a token allocated with xa_alloc(). The same needs to be passed to clear-config API. - Updated all users according to that as well. - The clk_names interface is updated to allow multiple clocks. - Converted few // comments to /* */. - Added tags by few people. - Dropped the last patch to rearrange stuff, not required anymore. Thanks. --- Viresh Viresh Kumar (20): OPP: Track if clock name is configured by platform OPP: Make dev_pm_opp_set_regulators() accept NULL terminated list OPP: Add dev_pm_opp_set_config() and friends cpufreq: qcom-nvmem: Migrate to dev_pm_opp_set_config() cpufreq: sti: Migrate to dev_pm_opp_set_config() cpufreq: ti: Migrate to dev_pm_opp_set_config() drm/lima: Migrate to dev_pm_opp_set_config() soc/tegra: Add comment over devm_pm_opp_set_clkname() soc/tegra: Migrate to dev_pm_opp_set_config() OPP: Migrate set-regulators API to use set-config helpers OPP: Migrate set-supported-hw API to use set-config helpers OPP: Migrate set-clk-name API to use set-config helpers OPP: Migrate set-opp-helper API to use set-config helpers OPP: Migrate attach-genpd API to use set-config helpers OPP: Migrate set-prop-name helper API to use set-config helpers OPP: Add support for config_regulators() helper OPP: Make _generic_set_opp_regulator() a config_regulators() interface OPP: Add dev_pm_opp_get_supplies() OPP: ti: Migrate to dev_pm_opp_set_config_regulators() OPP: Remove custom OPP helper support drivers/cpufreq/cpufreq-dt.c | 19 +- drivers/cpufreq/imx-cpufreq-dt.c | 12 +- drivers/cpufreq/qcom-cpufreq-nvmem.c | 109 +-- drivers/cpufreq/sti-cpufreq.c | 27 +- drivers/cpufreq/sun50i-cpufreq-nvmem.c | 31 +- drivers/cpufreq/tegra20-cpufreq.c | 12 +- drivers/cpufreq/ti-cpufreq.c | 42 +- drivers/devfreq/exynos-bus.c | 21 +- drivers/gpu/drm/lima/lima_devfreq.c | 12 +- drivers/gpu/drm/panfrost/panfrost_devfreq.c | 4 +- drivers/memory/tegra/tegra124-emc.c | 11 +- drivers/opp/core.c | 821 +++++++++----------- drivers/opp/opp.h | 32 +- drivers/opp/ti-opp-supply.c | 77 +- drivers/soc/tegra/common.c | 49 +- drivers/soc/tegra/pmc.c | 4 +- include/linux/pm_opp.h | 295 ++++--- 17 files changed, 750 insertions(+), 828 deletions(-)