[v4,0/5] Add new panel driver Samsung S6E88A0-AMS427AP24

Message

Jakob Hauser Oct. 27, 2024, 11:42 p.m. UTC

The patchset adds a new driver for Samsung AMS427AP24 panel with S6E88A0
controller. Patches are based on current branch drm-misc-next.

The discussion in v3 was not finished. I send v4 nonetheless as a new base to
continue the discussion. I hope that's ok.

Changes in v4:

 Patch 3
 - Removed include <linux/of.h>, it's not needed.
 - Added comments to the mipi_dsi_dcs_write_seq_multi() lines in function
   s6e88a0_ams427ap24_on().

 Patch 4
 - New defines for payload data length, thereof a fixed and a variable part.
 - In the array s6e88a0_ams427ap24_br_to_cd[] made the comment about the
   columns more clear and added an additional column "brightness from".
 - Array s6e88a0_ams427ap24_aid[] reduced from five to two columns and
   s6e88a0_ams427ap24_elvss[] from two to one column. Now they hold the
   variable data only. I kept s6e88a0_ams427ap24_elvss[] as a two-dimensional
   array to allow using the same memcopy procedure for all three buffers aid,
   elvss and gamma in function s6e88a0_ams427ap24_set_brightness().
 - In function s6e88a0_ams427ap24_set_brightness() initialized prototype
   payload array for b2 and b6 commands. And in the memcpy commands below
   used the new defines for the fixed and variable data length.

 Patch 5
 - Added a comment to the mipi_dsi_dcs_write_seq_multi() line, according to the
   other lines before and after.

v1: https://lore.kernel.org/dri-devel/[e-mail]/T/#t
v2: https://lore.kernel.org/dri-devel/[e-mail]/T/#t
v3: https://lore.kernel.org/dri-devel/[e-mail]/T/#t

Jakob Hauser (5):
  dt-bindings: display: panel: Move flip properties to panel-common
  dt-bindings: display: panel: Add Samsung S6E88A0-AMS427AP24
  drm/panel: samsung-s6e88a0-ams427ap24: Add initial driver
  drm/panel: samsung-s6e88a0-ams427ap24: Add brightness control
  drm/panel: samsung-s6e88a0-ams427ap24: Add flip option

 .../bindings/display/panel/panel-common.yaml  |   8 +
 .../panel/samsung,s6e88a0-ams427ap24.yaml     |  65 ++
 .../display/panel/samsung,s6e8aa0.yaml        |  10 +-
 drivers/gpu/drm/panel/Kconfig                 |  10 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 .../panel/panel-samsung-s6e88a0-ams427ap24.c  | 766 ++++++++++++++++++
 6 files changed, 852 insertions(+), 8 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams427ap24.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-samsung-s6e88a0-ams427ap24.c

Comments

Neil Armstrong Oct. 31, 2024, 10:18 a.m. UTC | #1

Hi,

On Mon, 28 Oct 2024 00:42:01 +0100, Jakob Hauser wrote:
> The patchset adds a new driver for Samsung AMS427AP24 panel with S6E88A0
> controller. Patches are based on current branch drm-misc-next.
> 
> The discussion in v3 was not finished. I send v4 nonetheless as a new base to
> continue the discussion. I hope that's ok.
> 
> Changes in v4:
> 
> [...]

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

[1/5] dt-bindings: display: panel: Move flip properties to panel-common
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/3c0ecd83eee9b8584588f629e01d209f2c3a632b
[2/5] dt-bindings: display: panel: Add Samsung S6E88A0-AMS427AP24
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/4998d53df6753c3dbb6e960291715027518c61df
[3/5] drm/panel: samsung-s6e88a0-ams427ap24: Add initial driver
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/d5658db2a0768a73a862f8b5fe6daae10d3abfec
[4/5] drm/panel: samsung-s6e88a0-ams427ap24: Add brightness control
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/5b67fdf1668fc373b1e492e33ce7d17f7056a609
[5/5] drm/panel: samsung-s6e88a0-ams427ap24: Add flip option
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/e70d4f8e242bbc4fd39f3a867dc3e33122d7e559