From patchwork Fri Jul 22 09:32:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9243313 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1DBDA60757 for ; Fri, 22 Jul 2016 09:32:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 09EBF262FF for ; Fri, 22 Jul 2016 09:32:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F2E8D27F93; Fri, 22 Jul 2016 09:32:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 843F7262FF for ; Fri, 22 Jul 2016 09:32:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB1606EB05; Fri, 22 Jul 2016 09:32:43 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mout.web.de (mout.web.de [212.227.17.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1487E6EB05 for ; Fri, 22 Jul 2016 09:32:17 +0000 (UTC) Received: from [192.168.1.2] ([77.182.75.73]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0Lw0q9-1bG80N41nx-017qN6; Fri, 22 Jul 2016 11:32:11 +0200 Subject: [PATCH] drm/mgag200: Delete an unnecessary check before drm_gem_object_unreference_unlocked() To: dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> From: SF Markus Elfring Message-ID: <05b266e4-2bae-b70b-5a96-ae609496d173@users.sourceforge.net> Date: Fri, 22 Jul 2016 11:32:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <5317A59D.4@users.sourceforge.net> X-Provags-ID: V03:K0:/JA+abwuYVraQnxIiOvl4mLaAU/YeqbsCIt/UlBIKCP97CrtfR9 Ag04fUSDNfoJHbB3eKIAlTKYC6D45ydu6A9LaDpNzt1AFdDRRzqYRuO6Ng8K8XY8IPZ48Pf AtpMZPpBzXNGuV4bzJelCCeq8iDeidPD+uq8eFaCChhBWBo6JxCV++laLcR4Q4fJFZqtQij NGsZXI3KyIIYF3+woWcYw== X-UI-Out-Filterresults: notjunk:1; V01:K0:JjHPZLz1W1g=:piuhoikqnL4Hg3dH7XR/1O UfyLL88rFzhXyp6claOKvEd//TpW21hsygcMjfa1AkLUwSAYZKR+jsrEDNYwRvEhccFLOLP/j wY1axN8PSGR7IfBTJ8XRc4xH/Chj77ZG2XPQPMNoy1sQLxklDbQ9yOLtT3/S8HJkKr13dsHX3 xOSxJix4cInOIfj1MnuZuCC+Nu5Xg2AUFh8nSsdGDIeF0J11ZVlvscUknTF0lldZxaaC7QScL EAAyvHbULA41rzmVVk7ubeFA2+EJGa5GbliDlaz4M6vVHv5h9YqaTnHvrV8pjaWwWBDNVvH4+ ICEuXgrNIDttdEOH1jxt/pqwUF7MKKdAoqP0tQbcMrzW7dwzVHdFHLuWwBsIFPdVJIUgfwle0 7aq/oO2CAn1ff0gYbPATRzdbt+JJk+AbFugJMj2WpzXUI1G8YIYtZCGpPZ0xaqoNLZrE8lgJr Xo6/4dFGEDXt3bWQWdXuODgoL/9d9W4eIMCse/K9Pd7znimR/ZdQMmcDwLney7wv03M8Tzcb4 NERStKBYpR5ywKW8yhMp43fx960lVGhezBzvNXayOZsjJA818FPnv3nb6wLQliik+2UYhphMR XKa/NWdXBSzK3EOB1SqzaEZCESn/QQb85fxYIZOm7GNHmVyV3erCHV0ej2r6Lrz9CfGuMdlSz mdn5BZ+gZ7T5QHkXHrSWXzF1ZCJuN1aO9Y8h8aEihsP+E6Ek8is2RlrqWC+T+CZezUJYVAEEf x/vOFd3U2hcDJBHKkU9yghFodkZM8Q8KmT6/+46sHLkTMAJ5fJIkXIAaXbCaCVmRNGaA1O++D vUVkR1Y Cc: Julia Lawall , kernel-janitors@vger.kernel.org, LKML X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Fri, 22 Jul 2016 11:20:27 +0200 The drm_gem_object_unreference_unlocked() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/gpu/drm/mgag200/mgag200_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c index 615cbb0..13798b3 100644 --- a/drivers/gpu/drm/mgag200/mgag200_main.c +++ b/drivers/gpu/drm/mgag200/mgag200_main.c @@ -17,8 +17,8 @@ static void mga_user_framebuffer_destroy(struct drm_framebuffer *fb) { struct mga_framebuffer *mga_fb = to_mga_framebuffer(fb); - if (mga_fb->obj) - drm_gem_object_unreference_unlocked(mga_fb->obj); + + drm_gem_object_unreference_unlocked(mga_fb->obj); drm_framebuffer_cleanup(fb); kfree(fb); }