| Message ID | 097eb2ad92f68f0f1a7c035c9b6b094afaf34dc1.1486115846.git-series.maxime.ripard@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Feb 03, 2017 at 10:59:05AM +0100, Maxime Ripard wrote: > The Sitronix ST7789V is an LCD panel controller, controlled over SPI, that > can drive 18-bits 240x320 LCD displays. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt > > diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt > new file mode 100644 > index 000000000000..f70e6e9c54ed > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt > @@ -0,0 +1,36 @@ > +Sitronix ST7789V RGB panel with SPI control bus > + > +Required properties: > + - compatible: "sitronix,st7789v" > + - reg: Chip select of the panel on the SPI bus > + - reset-gpios: a GPIO phandle for the reset pin Shouldn't this have some sort of power supply? Thierry
Hi Thierry, On Mon, Feb 06, 2017 at 02:05:49PM +0100, Thierry Reding wrote: > On Fri, Feb 03, 2017 at 10:59:05AM +0100, Maxime Ripard wrote: > > The Sitronix ST7789V is an LCD panel controller, controlled over SPI, that > > can drive 18-bits 240x320 LCD displays. > > > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > --- > > Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt | 36 ++++++++++++++++++++++++++++++++++++ > > 1 file changed, 36 insertions(+), 0 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt > > > > diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt > > new file mode 100644 > > index 000000000000..f70e6e9c54ed > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt > > @@ -0,0 +1,36 @@ > > +Sitronix ST7789V RGB panel with SPI control bus > > + > > +Required properties: > > + - compatible: "sitronix,st7789v" > > + - reg: Chip select of the panel on the SPI bus > > + - reset-gpios: a GPIO phandle for the reset pin > > Shouldn't this have some sort of power supply? On the board I currently have, it's just tied to an always on regulator, but you're right, I'll add it. Thanks! Maxime
On Tue, Feb 07, 2017 at 04:44:42PM +0100, Maxime Ripard wrote: > Hi Thierry, > > On Mon, Feb 06, 2017 at 02:05:49PM +0100, Thierry Reding wrote: > > On Fri, Feb 03, 2017 at 10:59:05AM +0100, Maxime Ripard wrote: > > > The Sitronix ST7789V is an LCD panel controller, controlled over SPI, that > > > can drive 18-bits 240x320 LCD displays. > > > > > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > > --- > > > Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt | 36 ++++++++++++++++++++++++++++++++++++ > > > 1 file changed, 36 insertions(+), 0 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt > > > > > > diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt > > > new file mode 100644 > > > index 000000000000..f70e6e9c54ed > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt > > > @@ -0,0 +1,36 @@ > > > +Sitronix ST7789V RGB panel with SPI control bus > > > + > > > +Required properties: > > > + - compatible: "sitronix,st7789v" > > > + - reg: Chip select of the panel on the SPI bus > > > + - reset-gpios: a GPIO phandle for the reset pin > > > > Shouldn't this have some sort of power supply? > > On the board I currently have, it's just tied to an always on > regulator, but you're right, I'll add it. Yes, we need to make sure to describe this from the panel's perspective to make sure that when other board designers hook things up differently we can still model it in DT. But you already knew that... Thierry
diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt new file mode 100644 index 000000000000..f70e6e9c54ed --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt @@ -0,0 +1,36 @@ +Sitronix ST7789V RGB panel with SPI control bus + +Required properties: + - compatible: "sitronix,st7789v" + - reg: Chip select of the panel on the SPI bus + - reset-gpios: a GPIO phandle for the reset pin + +Optional properties: + - backlight: phandle to the backlight used + +The generic bindings for the SPI slaves documented in [1] also applies + +The device node can contain one 'port' child node with one child +'endpoint' node, according to the bindings defined in [2]. This +node should describe panel's video bus. + +[1]: Documentation/devicetree/bindings/spi/spi-bus.txt +[2]: Documentation/devicetree/bindings/graph.txt + +Example: + +panel@0 { + compatible = "sitronix,st7789v"; + reg = <0>; + reset-gpios = <&pio 6 11 GPIO_ACTIVE_LOW>; + backlight = <&pwm_bl>; + spi-max-frequency = <100000>; + spi-cpol; + spi-cpha; + + port { + panel_input: endpoint { + remote-endpoint = <&tcon0_out_panel>; + }; + }; +};
The Sitronix ST7789V is an LCD panel controller, controlled over SPI, that can drive 18-bits 240x320 LCD displays. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/panel/sitronix,st7789v.txt