From patchwork Mon Jun 13 14:40:38 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Dietsche X-Patchwork-Id: 875162 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p5DGSnpc029695 for ; Mon, 13 Jun 2011 16:29:10 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 898279F2FF for ; Mon, 13 Jun 2011 09:28:49 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from que21.charter.net (que21.charter.net [209.225.8.22]) by gabe.freedesktop.org (Postfix) with ESMTP id 731B39EE9A for ; Mon, 13 Jun 2011 07:44:35 -0700 (PDT) Received: from imp11 ([10.20.200.11]) by mta21.charter.net (InterMail vM.7.09.02.04 201-2219-117-106-20090629) with ESMTP id <20110613144047.ZWFL11595.mta21.charter.net@imp11>; Mon, 13 Jun 2011 10:40:47 -0400 Received: from www.farmergreg.com ([96.42.32.177]) by imp11 with smtp.charter.net id vSgm1g00J3pHlLY05Sgmnh; Mon, 13 Jun 2011 10:40:47 -0400 X-Authority-Analysis: v=1.1 cv=vT9vkN3vVXssH3Ov7r/wQUs/sfIFjNPEFFf4aeKIi4A= c=1 sm=1 a=2vPNFbQ4uesA:10 a=lDGNyK2vIvEA:10 a=xzrYXqw+0zwiO4gHSXHcAg==:17 a=apapQfFnAAAA:8 a=Zh0XGXoQGCX4B2KpgjUA:9 a=LYNH9Ox2T_sA:10 a=xzrYXqw+0zwiO4gHSXHcAg==:117 Received: from red.farmergreg.com ([10.0.0.50]) by www.farmergreg.com with esmtp (Exim 4.72) (envelope-from ) id 1QW8Jj-0007Ki-38; Mon, 13 Jun 2011 09:40:39 -0500 Received: from greg by red.farmergreg.com with local (Exim 4.72) (envelope-from ) id 1QW8Jk-0005Ij-MR; Mon, 13 Jun 2011 09:40:40 -0500 From: Greg Dietsche To: airlied@linux.ie Subject: [PATCH v2] savage: remove unnecessary if statement Date: Mon, 13 Jun 2011 09:40:38 -0500 Message-Id: <1307976038-20351-1-git-send-email-Gregory.Dietsche@cuw.edu> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <20110606125316.312fad32@absol.kitzblitz> References: <20110606125316.312fad32@absol.kitzblitz> X-Mailman-Approved-At: Mon, 13 Jun 2011 09:28:40 -0700 Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Greg Dietsche X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Mon, 13 Jun 2011 16:29:10 +0000 (UTC) the code always returns ret regardless, so if(ret) check is unnecessary. v2: fixed up the spelling. Signed-off-by: Greg Dietsche Reviewed-by: Nicolas Kaiser --- drivers/gpu/drm/savage/savage_bci.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c index bf5f83e..cb1ee4e 100644 --- a/drivers/gpu/drm/savage/savage_bci.c +++ b/drivers/gpu/drm/savage/savage_bci.c @@ -647,9 +647,6 @@ int savage_driver_firstopen(struct drm_device *dev) ret = drm_addmap(dev, aperture_base, SAVAGE_APERTURE_SIZE, _DRM_FRAME_BUFFER, _DRM_WRITE_COMBINING, &dev_priv->aperture); - if (ret) - return ret; - return ret; }