From patchwork Mon Jul 4 03:16:17 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Skeggs X-Patchwork-Id: 941392 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p643Nsvk020457 for ; Mon, 4 Jul 2011 03:24:15 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 52CBE9EF57 for ; Sun, 3 Jul 2011 20:13:34 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-vx0-f177.google.com (mail-vx0-f177.google.com [209.85.220.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 603C49EEF0 for ; Sun, 3 Jul 2011 20:13:26 -0700 (PDT) Received: by vxd3 with SMTP id 3so4252081vxd.36 for ; Sun, 03 Jul 2011 20:13:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; bh=S4BhvDbO9HXEz1CmNz0IMPDI16EGaknN57pOEIqK8o8=; b=doKqqSuLssQraYmym2Fdvaf51vnv0ySdslWJYMgumj/fTwdaVwGiVjxPnOzlZFkXw2 zn2sw2+1N0R9kmMUdPvA0/op1Gu9JKa3NQg73RHPulSigNm/Cm9077WLzQHauInb63xV JbCzJaXZ5YsdzL25dX4SPp50QbtY2wNMvH8XE= Received: by 10.52.175.229 with SMTP id cd5mr7475723vdc.197.1309749204939; Sun, 03 Jul 2011 20:13:24 -0700 (PDT) Received: from nisroch.bne.redhat.com ([66.187.239.10]) by mx.google.com with ESMTPS id dp2sm3396686vbb.13.2011.07.03.20.13.23 (version=SSLv3 cipher=OTHER); Sun, 03 Jul 2011 20:13:24 -0700 (PDT) From: skeggsb@gmail.com To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm/kms: allow drm_mode_group with no objects Date: Mon, 4 Jul 2011 13:16:17 +1000 Message-Id: <1309749377-8372-1-git-send-email-skeggsb@gmail.com> X-Mailer: git-send-email 1.7.5.4 Cc: Ben Skeggs X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Mon, 04 Jul 2011 03:24:15 +0000 (UTC) From: Ben Skeggs Sometimes we could be controlling a device (such as an NVIDIA Tesla) that has no crtcs/encoders/connectors. One could argue that the driver should unset DRIVER_MODESET in this case, but that changes a whole heap of the DRM's other behaviours, and it's much easier to just be a modesetting driver without any outputs. Signed-off-by: Ben Skeggs --- drivers/gpu/drm/drm_crtc.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 21058e6..82db185 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -886,9 +886,6 @@ int drm_mode_group_init(struct drm_device *dev, struct drm_mode_group *group) total_objects += dev->mode_config.num_connector; total_objects += dev->mode_config.num_encoder; - if (total_objects == 0) - return -EINVAL; - group->id_list = kzalloc(total_objects * sizeof(uint32_t), GFP_KERNEL); if (!group->id_list) return -ENOMEM;