From patchwork Tue Jul 5 20:12:53 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tormod Volden X-Patchwork-Id: 946482 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p65KD8JB028416 for ; Tue, 5 Jul 2011 20:13:29 GMT Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2858C9E7D7 for ; Tue, 5 Jul 2011 13:13:08 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wy0-f177.google.com (mail-wy0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id B5A869E748 for ; Tue, 5 Jul 2011 13:12:58 -0700 (PDT) Received: by wyf23 with SMTP id 23so5359939wyf.36 for ; Tue, 05 Jul 2011 13:12:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; bh=uCD+EyUxpqvPArRdTUXRaYhktR6FGbQEWXH/fI5erH0=; b=QONF9irsMYfM1E0QjaGMa2i2reU9rcWDEhKCBAhmW6eKm1Cy1gYNuFlZTj1wdOCTUG WbPF52ZYToFOAqYF1gx/qO0xcw/45bY9+khfiJHLj3iuZomm1kad0B/OrizgW+O3BIwj XwZJmiV0DOxiICotlRFqw7EFoyJuCsuLjRQJU= Received: by 10.227.169.135 with SMTP id z7mr6804320wby.75.1309896777877; Tue, 05 Jul 2011 13:12:57 -0700 (PDT) Received: from localhost.localdomain (80-219-113-251.dclient.hispeed.ch [80.219.113.251]) by mx.google.com with ESMTPS id fi5sm5559796wbb.56.2011.07.05.13.12.56 (version=SSLv3 cipher=OTHER); Tue, 05 Jul 2011 13:12:56 -0700 (PDT) From: Tormod Volden To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 drm-next] drm: really make debug levels match in edid failure code Date: Tue, 5 Jul 2011 22:12:53 +0200 Message-Id: <1309896774-2629-1-git-send-email-lists.tormod@gmail.com> X-Mailer: git-send-email 1.7.0.4 Cc: Dave Airlie X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Tue, 05 Jul 2011 20:13:29 +0000 (UTC) From: Tormod Volden Also disable the ascii dump and remove the literal printing of the KERN_ERR macro in the log: [drm:drm_edid_block_valid] *ERROR* Raw EDID: <3>00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ v2: Remove the trailing empty line as well. Signed-off-by: Tormod Volden --- drivers/gpu/drm/drm_edid.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index 0929219..756af4d 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/gpu/drm/drm_edid.c @@ -185,8 +185,8 @@ drm_edid_block_valid(u8 *raw_edid) bad: if (raw_edid) { printk(KERN_ERR "Raw EDID:\n"); - print_hex_dump_bytes(KERN_ERR, DUMP_PREFIX_NONE, raw_edid, EDID_LENGTH); - printk(KERN_ERR "\n"); + print_hex_dump(KERN_ERR, " \t", DUMP_PREFIX_NONE, 16, 1, + raw_edid, EDID_LENGTH, false); } return 0; }