From patchwork Thu Jul 5 06:31:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Henrik Rydberg X-Patchwork-Id: 1158091 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 435973FE4F for ; Thu, 5 Jul 2012 06:31:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 10BC4A0D95 for ; Wed, 4 Jul 2012 23:31:12 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from smtprelay-b21.telenor.se (smtprelay-b21.telenor.se [195.54.99.212]) by gabe.freedesktop.org (Postfix) with ESMTP id F048F9E7F4 for ; Wed, 4 Jul 2012 23:30:59 -0700 (PDT) Received: from ipb4.telenor.se (ipb4.telenor.se [195.54.127.167]) by smtprelay-b21.telenor.se (Postfix) with ESMTP id 11D64EA71A; Thu, 5 Jul 2012 08:30:57 +0200 (CEST) X-SENDER-IP: [85.230.168.62] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ao5YAIAz9U9V5qg+PGdsb2JhbABFihqpM4NaGQEBAQEeAxYNJ4J1IxgRcQoaiCK6CxSLLoY1A5scjH+BVA X-IronPort-AV: E=Sophos;i="4.77,528,1336341600"; d="scan'208";a="74886831" Received: from c-3ea8e655.710-13-64736c12.cust.bredbandsbolaget.se (HELO polaris) ([85.230.168.62]) by ipb4.telenor.se with SMTP; 05 Jul 2012 08:30:56 +0200 Received: by polaris (sSMTP sendmail emulation); Thu, 05 Jul 2012 08:31:26 +0200 From: "Henrik Rydberg" To: Ben Skeggs Subject: [REGRESSION] nouveau: Memory corruption using nva3 engine for 0xaf Date: Thu, 5 Jul 2012 08:31:13 +0200 Message-Id: <1341469873-1582-1-git-send-email-rydberg@euromail.se> X-Mailer: git-send-email 1.7.11.1 Cc: nouveau@lists.freedesktop.org, Henrik Rydberg , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Hi Ben, Dave, Since 3.5-rc0, I have been experiencing occasional screen corruption on my MacBookAir3,1, using a GeForce 320M (nv50, 0xaf). The X driver version is xf86-video-nouvea-1.0.1-1 (arch). I do not know what the root problem is, but I have been able to isolate the symptoms to the usage of nva3_copy.c. The patch below is the least intrusive way I could find which kills the symptoms. Hopefully this will sched some light on the true problem, such that a fix can be found for 3.5. Thanks, Henrik The nva3 copy engine exhibits random memory corruption in at least one case, the GeForce 320M (nv50, 0xaf) in the MacBookAir3,1. This patch omits creating the engine for the specific chipset, falling back to M2MF, which kills the symptoms. Signed-off-by: Ben Skeggs --- drivers/gpu/drm/nouveau/nouveau_state.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_state.c b/drivers/gpu/drm/nouveau/nouveau_state.c index 19706f0..b466937 100644 --- a/drivers/gpu/drm/nouveau/nouveau_state.c +++ b/drivers/gpu/drm/nouveau/nouveau_state.c @@ -731,7 +731,6 @@ nouveau_card_init(struct drm_device *dev) case 0xa3: case 0xa5: case 0xa8: - case 0xaf: nva3_copy_create(dev); break; }