| Message ID | 1343821532-30817-1-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, Any comments on this series? Regards Sachin On 1 August 2012 17:15, Sachin Kamat <sachin.kamat@linaro.org> wrote: > Fixes the following sparse warning: > drivers/gpu/drm/drm_proc.c:92:5: > warning: symbol 'drm_proc_create_files' was not declared. Should it be static? > drivers/gpu/drm/drm_proc.c:175:5: > warning: symbol 'drm_proc_remove_files' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/gpu/drm/drm_proc.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_proc.c b/drivers/gpu/drm/drm_proc.c > index 371c695..da457b1 100644 > --- a/drivers/gpu/drm/drm_proc.c > +++ b/drivers/gpu/drm/drm_proc.c > @@ -89,7 +89,7 @@ static const struct file_operations drm_proc_fops = { > * Create a given set of proc files represented by an array of > * gdm_proc_lists in the given root directory. > */ > -int drm_proc_create_files(struct drm_info_list *files, int count, > +static int drm_proc_create_files(struct drm_info_list *files, int count, > struct proc_dir_entry *root, struct drm_minor *minor) > { > struct drm_device *dev = minor->dev; > @@ -172,7 +172,7 @@ int drm_proc_init(struct drm_minor *minor, int minor_id, > return 0; > } > > -int drm_proc_remove_files(struct drm_info_list *files, int count, > +static int drm_proc_remove_files(struct drm_info_list *files, int count, > struct drm_minor *minor) > { > struct list_head *pos, *q; > -- > 1.7.4.1 >
Hi, Any comments on this series? On 1 August 2012 17:15, Sachin Kamat <sachin.kamat@linaro.org> wrote: > Fixes the following sparse warning: > drivers/gpu/drm/drm_proc.c:92:5: > warning: symbol 'drm_proc_create_files' was not declared. Should it be static? > drivers/gpu/drm/drm_proc.c:175:5: > warning: symbol 'drm_proc_remove_files' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > drivers/gpu/drm/drm_proc.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_proc.c b/drivers/gpu/drm/drm_proc.c > index 371c695..da457b1 100644 > --- a/drivers/gpu/drm/drm_proc.c > +++ b/drivers/gpu/drm/drm_proc.c > @@ -89,7 +89,7 @@ static const struct file_operations drm_proc_fops = { > * Create a given set of proc files represented by an array of > * gdm_proc_lists in the given root directory. > */ > -int drm_proc_create_files(struct drm_info_list *files, int count, > +static int drm_proc_create_files(struct drm_info_list *files, int count, > struct proc_dir_entry *root, struct drm_minor *minor) > { > struct drm_device *dev = minor->dev; > @@ -172,7 +172,7 @@ int drm_proc_init(struct drm_minor *minor, int minor_id, > return 0; > } > > -int drm_proc_remove_files(struct drm_info_list *files, int count, > +static int drm_proc_remove_files(struct drm_info_list *files, int count, > struct drm_minor *minor) > { > struct list_head *pos, *q; > -- > 1.7.4.1 >
diff --git a/drivers/gpu/drm/drm_proc.c b/drivers/gpu/drm/drm_proc.c index 371c695..da457b1 100644 --- a/drivers/gpu/drm/drm_proc.c +++ b/drivers/gpu/drm/drm_proc.c @@ -89,7 +89,7 @@ static const struct file_operations drm_proc_fops = { * Create a given set of proc files represented by an array of * gdm_proc_lists in the given root directory. */ -int drm_proc_create_files(struct drm_info_list *files, int count, +static int drm_proc_create_files(struct drm_info_list *files, int count, struct proc_dir_entry *root, struct drm_minor *minor) { struct drm_device *dev = minor->dev; @@ -172,7 +172,7 @@ int drm_proc_init(struct drm_minor *minor, int minor_id, return 0; } -int drm_proc_remove_files(struct drm_info_list *files, int count, +static int drm_proc_remove_files(struct drm_info_list *files, int count, struct drm_minor *minor) { struct list_head *pos, *q;
Fixes the following sparse warning: drivers/gpu/drm/drm_proc.c:92:5: warning: symbol 'drm_proc_create_files' was not declared. Should it be static? drivers/gpu/drm/drm_proc.c:175:5: warning: symbol 'drm_proc_remove_files' was not declared. Should it be static? Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/gpu/drm/drm_proc.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)