From patchwork Fri Aug 24 22:16:22 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sedat Dilek X-Patchwork-Id: 1373391 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id EAFA2DF6DA for ; Sat, 25 Aug 2012 13:45:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D5B5A9E982 for ; Sat, 25 Aug 2012 06:45:36 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 10B0BA0FD7 for ; Fri, 24 Aug 2012 15:16:34 -0700 (PDT) Received: by weyr3 with SMTP id r3so1345546wey.36 for ; Fri, 24 Aug 2012 15:16:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=F57QrA/3GXok3o6636vUDKpQPeAz/UbFdlW/F0MPxTk=; b=lJGtPCKmr2Hd6TJltMX8KuGxHkb1XSo18l/S2hpoeIC5RbgZvaoW7P9tS+zm2LSX8j X2l/tTmeRC3aRzA1cqf/T57EVpCa8DuJZPPSHL7yCAWl7eFAtqhKqbHGBJvGl6bRjlI1 rDzyDzziKw9t7BpLgwIsdEF15HltCtV7a6IE+BnEBsXg4lM5X0tS+Wm2T2VFWqIt+sdX U181ilONgxz6KmSWnYe40vHwJqQeWKcmC4ZKhHb/twlDpFuZ24vabjWftIvd78qjyiog gIkB5nNKllKiI5j0gIP/9OKFAM0249ZG94qNbjSYbqyom7ouHYbYh2m63njvwO3daZTk xo1g== Received: by 10.180.78.170 with SMTP id c10mr8621723wix.3.1345846594018; Fri, 24 Aug 2012 15:16:34 -0700 (PDT) Received: from fambox.fritz.box (p5B2EA080.dip.t-dialin.net. [91.46.160.128]) by mx.google.com with ESMTPS id fr4sm1108253wib.8.2012.08.24.15.16.32 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 24 Aug 2012 15:16:33 -0700 (PDT) From: Sedat Dilek To: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH drm-next 1/3] drm/udl: usb: Fix recursive Kconfig dependency Date: Sat, 25 Aug 2012 00:16:22 +0200 Message-Id: <1345846584-5910-1-git-send-email-sedat.dilek@gmail.com> X-Mailer: git-send-email 1.7.9.5 X-Mailman-Approved-At: Sat, 25 Aug 2012 06:43:37 -0700 Cc: Sedat Dilek X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org In drivers/usb/Kconfig "config USB_ARCH_HAS_HCD" is within "if USB_SUPPORT" statement. In drivers/gpu/drm/Kconfig "config DRM_USB" depends on USB_ARCH_HAS_HCD but selects USB_SUPPORT which leads to the error for udl Kconfig: $ yes "" | make oldconfig scripts/kconfig/conf --oldconfig Kconfig drivers/gpu/drm/udl/Kconfig:1:error: recursive dependency detected! drivers/gpu/drm/udl/Kconfig:1: symbol DRM_UDL depends on USB_ARCH_HAS_HCD drivers/usb/Kconfig:76: symbol USB_ARCH_HAS_HCD depends on USB_SUPPORT drivers/usb/Kconfig:58: symbol USB_SUPPORT is selected by DRM_USB drivers/gpu/drm/Kconfig:22: symbol DRM_USB is selected by DRM_UDL Fix this by changing from select to depends on USB_SUPPORT in "config DRM_USB". This is a follow-up fix to df0b344300724e00db9fff7eb6406eb91f450b91 in Dave's drm-next GIT branch. [ v2: Restore old status, but change from select to depends on USB_SUPPORT ] [ v3: Use common prefix "drm/udl" in label ] Signed-off-by: Sedat Dilek --- drivers/gpu/drm/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 3a8c683..0cbdc45 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -22,9 +22,8 @@ menuconfig DRM config DRM_USB tristate depends on DRM - depends on USB_ARCH_HAS_HCD + depends on USB_SUPPORT && USB_ARCH_HAS_HCD select USB - select USB_SUPPORT config DRM_KMS_HELPER tristate