diff mbox

[drm-next,2/3] drm/i915: Remove reference to drm_display_info raw_edid field

Message ID 1345846584-5910-2-git-send-email-sedat.dilek@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Sedat Dilek Aug. 24, 2012, 10:16 p.m. UTC
Reported-By: Stephen Rothwell <sfr@canb.auug.org.au>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Acked-by: Dave Airlie <airlied@gmail.com>
Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
---
 drivers/gpu/drm/i915/intel_modes.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Daniel Vetter Aug. 26, 2012, 6:39 p.m. UTC | #1
On Sat, Aug 25, 2012 at 12:16:23AM +0200, Sedat Dilek wrote:
> Reported-By: Stephen Rothwell <sfr@canb.auug.org.au>
> Acked-by: Jani Nikula <jani.nikula@intel.com>
> Acked-by: Dave Airlie <airlied@gmail.com>
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>

This doesn't apply to my drm-intel-next tree any more - we've moved around
the assignement a bit.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_modes.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_modes.c b/drivers/gpu/drm/i915/intel_modes.c
> index 29b7259..4bc1c0f 100644
> --- a/drivers/gpu/drm/i915/intel_modes.c
> +++ b/drivers/gpu/drm/i915/intel_modes.c
> @@ -45,7 +45,6 @@ int intel_connector_update_modes(struct drm_connector *connector,
>  	drm_mode_connector_update_edid_property(connector, edid);
>  	ret = drm_add_edid_modes(connector, edid);
>  	drm_edid_to_eld(connector, edid);
> -	connector->display_info.raw_edid = NULL;
>  	kfree(edid);
>  
>  	return ret;
> -- 
> 1.7.9.5
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
Sedat Dilek Aug. 26, 2012, 7:18 p.m. UTC | #2
On Sun, Aug 26, 2012 at 8:39 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Sat, Aug 25, 2012 at 12:16:23AM +0200, Sedat Dilek wrote:
>> Reported-By: Stephen Rothwell <sfr@canb.auug.org.au>
>> Acked-by: Jani Nikula <jani.nikula@intel.com>
>> Acked-by: Dave Airlie <airlied@gmail.com>
>> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
>
> This doesn't apply to my drm-intel-next tree any more - we've moved around
> the assignement a bit.

Error still exists but is in intel_ddc_get_modes() now.

- Sedat -

http://cgit.freedesktop.org/~danvet/drm-intel/tree/drivers/gpu/drm/i915/intel_modes.c?h=drm-intel-next#n53

> -Daniel
>
>> ---
>>  drivers/gpu/drm/i915/intel_modes.c |    1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_modes.c b/drivers/gpu/drm/i915/intel_modes.c
>> index 29b7259..4bc1c0f 100644
>> --- a/drivers/gpu/drm/i915/intel_modes.c
>> +++ b/drivers/gpu/drm/i915/intel_modes.c
>> @@ -45,7 +45,6 @@ int intel_connector_update_modes(struct drm_connector *connector,
>>       drm_mode_connector_update_edid_property(connector, edid);
>>       ret = drm_add_edid_modes(connector, edid);
>>       drm_edid_to_eld(connector, edid);
>> -     connector->display_info.raw_edid = NULL;
>>       kfree(edid);
>>
>>       return ret;
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Mail: daniel@ffwll.ch
> Mobile: +41 (0)79 365 57 48
diff mbox

Patch

diff --git a/drivers/gpu/drm/i915/intel_modes.c b/drivers/gpu/drm/i915/intel_modes.c
index 29b7259..4bc1c0f 100644
--- a/drivers/gpu/drm/i915/intel_modes.c
+++ b/drivers/gpu/drm/i915/intel_modes.c
@@ -45,7 +45,6 @@  int intel_connector_update_modes(struct drm_connector *connector,
 	drm_mode_connector_update_edid_property(connector, edid);
 	ret = drm_add_edid_modes(connector, edid);
 	drm_edid_to_eld(connector, edid);
-	connector->display_info.raw_edid = NULL;
 	kfree(edid);
 
 	return ret;