diff mbox

[1/2] drm/exynos: Add missing braces around sizeof in exynos_hdmi.c

Message ID 1346408448-13928-1-git-send-email-sachin.kamat@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Sachin Kamat Aug. 31, 2012, 10:20 a.m. UTC
Fixes the following checkpatch warnings:
WARNING: sizeof *res should be sizeof(*res)
WARNING: sizeof res->regul_bulk[0] should be sizeof(res->regul_bulk[0])
WARNING: sizeof *res should be sizeof(*res)

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/gpu/drm/exynos/exynos_hdmi.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Comments

Inki Dae Sept. 3, 2012, 2:44 a.m. UTC | #1
Applied. Thanks.

2012/8/31 Sachin Kamat <sachin.kamat@linaro.org>:
> Fixes the following checkpatch warnings:
> WARNING: sizeof *res should be sizeof(*res)
> WARNING: sizeof res->regul_bulk[0] should be sizeof(res->regul_bulk[0])
> WARNING: sizeof *res should be sizeof(*res)
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/gpu/drm/exynos/exynos_hdmi.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index 409e2ec..a4c6bbc 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -2172,7 +2172,7 @@ static int __devinit hdmi_resources_init(struct hdmi_context *hdata)
>
>         DRM_DEBUG_KMS("HDMI resource init\n");
>
> -       memset(res, 0, sizeof *res);
> +       memset(res, 0, sizeof(*res));
>
>         /* get clocks, power */
>         res->hdmi = clk_get(dev, "hdmi");
> @@ -2204,7 +2204,7 @@ static int __devinit hdmi_resources_init(struct hdmi_context *hdata)
>         clk_set_parent(res->sclk_hdmi, res->sclk_pixel);
>
>         res->regul_bulk = kzalloc(ARRAY_SIZE(supply) *
> -               sizeof res->regul_bulk[0], GFP_KERNEL);
> +               sizeof(res->regul_bulk[0]), GFP_KERNEL);
>         if (!res->regul_bulk) {
>                 DRM_ERROR("failed to get memory for regulators\n");
>                 goto fail;
> @@ -2243,7 +2243,7 @@ static int hdmi_resources_cleanup(struct hdmi_context *hdata)
>                 clk_put(res->sclk_hdmi);
>         if (!IS_ERR_OR_NULL(res->hdmi))
>                 clk_put(res->hdmi);
> -       memset(res, 0, sizeof *res);
> +       memset(res, 0, sizeof(*res));
>
>         return 0;
>  }
> --
> 1.7.4.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index 409e2ec..a4c6bbc 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -2172,7 +2172,7 @@  static int __devinit hdmi_resources_init(struct hdmi_context *hdata)
 
 	DRM_DEBUG_KMS("HDMI resource init\n");
 
-	memset(res, 0, sizeof *res);
+	memset(res, 0, sizeof(*res));
 
 	/* get clocks, power */
 	res->hdmi = clk_get(dev, "hdmi");
@@ -2204,7 +2204,7 @@  static int __devinit hdmi_resources_init(struct hdmi_context *hdata)
 	clk_set_parent(res->sclk_hdmi, res->sclk_pixel);
 
 	res->regul_bulk = kzalloc(ARRAY_SIZE(supply) *
-		sizeof res->regul_bulk[0], GFP_KERNEL);
+		sizeof(res->regul_bulk[0]), GFP_KERNEL);
 	if (!res->regul_bulk) {
 		DRM_ERROR("failed to get memory for regulators\n");
 		goto fail;
@@ -2243,7 +2243,7 @@  static int hdmi_resources_cleanup(struct hdmi_context *hdata)
 		clk_put(res->sclk_hdmi);
 	if (!IS_ERR_OR_NULL(res->hdmi))
 		clk_put(res->hdmi);
-	memset(res, 0, sizeof *res);
+	memset(res, 0, sizeof(*res));
 
 	return 0;
 }