| Message ID | 1346881623-388-1-git-send-email-msb@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Mandeep, On 2012? 09? 06? 06:47, Mandeep Singh Baines wrote: > The double invocations are incorrect but seem to be safe so I don't > think this will fix any bugs. > > Before: > > [ 7.639366] drm_prime_init_file ee3675d0 > [ 7.639377] drm_prime_init_file ee3675d0 > [ 7.639507] drm_prime_destroy_file ee3675d0 > [ 7.639518] drm_prime_destroy_file ee3675d0 > [ 7.639802] drm_prime_init_file ee372390 > [ 7.639810] drm_prime_init_file ee372390 > [ 8.473316] drm_prime_init_file ee356390 > [ 8.473331] drm_prime_init_file ee356390 > > After: > > [ 6.363842] drm_prime_init_file edc2e5d0 > [ 6.363994] drm_prime_destroy_file edc2e5d0 > [ 6.364260] drm_prime_init_file edc2e750 > [ 8.004837] drm_prime_init_file ee36ded0 > You are right. prime file_priv is handled by drm_fops.c, so it can be removed from exynos drm. Thanks for your patch. > Signed-off-by: Mandeep Singh Baines <msb@chromium.org> > CC: Stéphane Marchesin <marcheu@chromium.org> > CC: Pawel Osciak <posciak@google.com> > CC: Inki Dae <inki.dae@samsung.com> > CC: Joonyoung Shim <jy0922.shim@samsung.com> > CC: Seung-Woo Kim <sw0312.kim@samsung.com> > CC: Kyungmin Park <kyungmin.park@samsung.com> > CC: David Airlie <airlied@linux.ie> > CC: dri-devel@lists.freedesktop.org Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_drm_drv.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c > index ebacec6..a27b8ff 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c > @@ -160,7 +160,6 @@ static int exynos_drm_open(struct drm_device *dev, struct drm_file *file) > if (!file_priv) > return -ENOMEM; > > - drm_prime_init_file_private(&file->prime); > file->driver_priv = file_priv; > > return exynos_drm_subdrv_open(dev, file); > @@ -184,7 +183,6 @@ static void exynos_drm_preclose(struct drm_device *dev, > e->base.destroy(&e->base); > } > } > - drm_prime_destroy_file_private(&file->prime); > spin_unlock_irqrestore(&dev->event_lock, flags); > > exynos_drm_subdrv_close(dev, file); >
Hi, 2012/9/6 Mandeep Singh Baines <msb@chromium.org>: > The double invocations are incorrect but seem to be safe so I don't > think this will fix any bugs. > > Before: > > [ 7.639366] drm_prime_init_file ee3675d0 > [ 7.639377] drm_prime_init_file ee3675d0 > [ 7.639507] drm_prime_destroy_file ee3675d0 > [ 7.639518] drm_prime_destroy_file ee3675d0 > [ 7.639802] drm_prime_init_file ee372390 > [ 7.639810] drm_prime_init_file ee372390 > [ 8.473316] drm_prime_init_file ee356390 > [ 8.473331] drm_prime_init_file ee356390 > > After: > > [ 6.363842] drm_prime_init_file edc2e5d0 > [ 6.363994] drm_prime_destroy_file edc2e5d0 > [ 6.364260] drm_prime_init_file edc2e750 > [ 8.004837] drm_prime_init_file ee36ded0 > > Signed-off-by: Mandeep Singh Baines <msb@chromium.org> > CC: Stéphane Marchesin <marcheu@chromium.org> > CC: Pawel Osciak <posciak@google.com> > CC: Inki Dae <inki.dae@samsung.com> > CC: Joonyoung Shim <jy0922.shim@samsung.com> > CC: Seung-Woo Kim <sw0312.kim@samsung.com> > CC: Kyungmin Park <kyungmin.park@samsung.com> > CC: David Airlie <airlied@linux.ie> > CC: dri-devel@lists.freedesktop.org remove all CCs and can you send it again using text mode? your patch is messed up when I try to get patch file. Thanks. Inki Dae > --- > drivers/gpu/drm/exynos/exynos_drm_drv.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c > index ebacec6..a27b8ff 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c > @@ -160,7 +160,6 @@ static int exynos_drm_open(struct drm_device *dev, struct drm_file *file) > if (!file_priv) > return -ENOMEM; > > - drm_prime_init_file_private(&file->prime); > file->driver_priv = file_priv; > > return exynos_drm_subdrv_open(dev, file); > @@ -184,7 +183,6 @@ static void exynos_drm_preclose(struct drm_device *dev, > e->base.destroy(&e->base); > } > } > - drm_prime_destroy_file_private(&file->prime); > spin_unlock_irqrestore(&dev->event_lock, flags); > > exynos_drm_subdrv_close(dev, file); > -- > 1.7.7.3 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
Dear Inki Dae, Am Donnerstag, den 06.09.2012, 11:35 +0900 schrieb InKi Dae: > 2012/9/6 Mandeep Singh Baines <msb@chromium.org>: > > The double invocations are incorrect but seem to be safe so I don't > > think this will fix any bugs. > > > > Before: > > > > [ 7.639366] drm_prime_init_file ee3675d0 > > [ 7.639377] drm_prime_init_file ee3675d0 > > [ 7.639507] drm_prime_destroy_file ee3675d0 > > [ 7.639518] drm_prime_destroy_file ee3675d0 > > [ 7.639802] drm_prime_init_file ee372390 > > [ 7.639810] drm_prime_init_file ee372390 > > [ 8.473316] drm_prime_init_file ee356390 > > [ 8.473331] drm_prime_init_file ee356390 > > > > After: > > > > [ 6.363842] drm_prime_init_file edc2e5d0 > > [ 6.363994] drm_prime_destroy_file edc2e5d0 > > [ 6.364260] drm_prime_init_file edc2e750 > > [ 8.004837] drm_prime_init_file ee36ded0 > > > > Signed-off-by: Mandeep Singh Baines <msb@chromium.org> > > CC: Stéphane Marchesin <marcheu@chromium.org> > > CC: Pawel Osciak <posciak@google.com> > > CC: Inki Dae <inki.dae@samsung.com> > > CC: Joonyoung Shim <jy0922.shim@samsung.com> > > CC: Seung-Woo Kim <sw0312.kim@samsung.com> > > CC: Kyungmin Park <kyungmin.park@samsung.com> > > CC: David Airlie <airlied@linux.ie> > > CC: dri-devel@lists.freedesktop.org > > remove all CCs I guess they were generated by some script. So they should be fine, no? Mandeep, if you put CC in here those people should be CCed in real. `git send-email` should take care of that but I do not see everyone in the CC field. Or does `git send-email` use blind carbon copy (BCC) field? > and can you send it again using text mode? At least to the list it was send in plain text mode. > your patch is messed up when I try to get patch file. Everything is fine on my side. Especially since Mandeep used `git send-email` which should do everything correctly. > Thanks. > Inki Dae In your From address your name is written InKi with capital K. Which one is correct? Thanks, Paul
Hi, 2012/9/6 Paul Menzel <paulepanter@users.sourceforge.net>: > Dear Inki Dae, > > > Am Donnerstag, den 06.09.2012, 11:35 +0900 schrieb InKi Dae: > >> 2012/9/6 Mandeep Singh Baines <msb@chromium.org>: >> > The double invocations are incorrect but seem to be safe so I don't >> > think this will fix any bugs. >> > >> > Before: >> > >> > [ 7.639366] drm_prime_init_file ee3675d0 >> > [ 7.639377] drm_prime_init_file ee3675d0 >> > [ 7.639507] drm_prime_destroy_file ee3675d0 >> > [ 7.639518] drm_prime_destroy_file ee3675d0 >> > [ 7.639802] drm_prime_init_file ee372390 >> > [ 7.639810] drm_prime_init_file ee372390 >> > [ 8.473316] drm_prime_init_file ee356390 >> > [ 8.473331] drm_prime_init_file ee356390 >> > >> > After: >> > >> > [ 6.363842] drm_prime_init_file edc2e5d0 >> > [ 6.363994] drm_prime_destroy_file edc2e5d0 >> > [ 6.364260] drm_prime_init_file edc2e750 >> > [ 8.004837] drm_prime_init_file ee36ded0 >> > >> > Signed-off-by: Mandeep Singh Baines <msb@chromium.org> >> > CC: Stéphane Marchesin <marcheu@chromium.org> >> > CC: Pawel Osciak <posciak@google.com> >> > CC: Inki Dae <inki.dae@samsung.com> >> > CC: Joonyoung Shim <jy0922.shim@samsung.com> >> > CC: Seung-Woo Kim <sw0312.kim@samsung.com> >> > CC: Kyungmin Park <kyungmin.park@samsung.com> >> > CC: David Airlie <airlied@linux.ie> >> > CC: dri-devel@lists.freedesktop.org >> >> remove all CCs > > I guess they were generated by some script. So they should be fine, no? > > Mandeep, if you put CC in here those people should be CCed in real. `git > send-email` should take care of that but I do not see everyone in the CC > field. Or does `git send-email` use blind carbon copy (BCC) field? > >> and can you send it again using text mode? > > At least to the list it was send in plain text mode. > >> your patch is messed up when I try to get patch file. > > Everything is fine on my side. Especially since Mandeep used `git > send-email` which should do everything correctly. > your patch was encoded with 'Content-Transfer-Encoding: base64' so please use 7bit ascii like 'Content-Transfer-Encoding: 7bit' >> Thanks. >> Inki Dae > > In your From address your name is written InKi with capital K. Which one > is correct? > Inki is correct :) Thanks. Inki Dae > > Thanks, > > Paul > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel >
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index ebacec6..a27b8ff 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c @@ -160,7 +160,6 @@ static int exynos_drm_open(struct drm_device *dev, struct drm_file *file) if (!file_priv) return -ENOMEM; - drm_prime_init_file_private(&file->prime); file->driver_priv = file_priv; return exynos_drm_subdrv_open(dev, file); @@ -184,7 +183,6 @@ static void exynos_drm_preclose(struct drm_device *dev, e->base.destroy(&e->base); } } - drm_prime_destroy_file_private(&file->prime); spin_unlock_irqrestore(&dev->event_lock, flags); exynos_drm_subdrv_close(dev, file);
The double invocations are incorrect but seem to be safe so I don't think this will fix any bugs. Before: [ 7.639366] drm_prime_init_file ee3675d0 [ 7.639377] drm_prime_init_file ee3675d0 [ 7.639507] drm_prime_destroy_file ee3675d0 [ 7.639518] drm_prime_destroy_file ee3675d0 [ 7.639802] drm_prime_init_file ee372390 [ 7.639810] drm_prime_init_file ee372390 [ 8.473316] drm_prime_init_file ee356390 [ 8.473331] drm_prime_init_file ee356390 After: [ 6.363842] drm_prime_init_file edc2e5d0 [ 6.363994] drm_prime_destroy_file edc2e5d0 [ 6.364260] drm_prime_init_file edc2e750 [ 8.004837] drm_prime_init_file ee36ded0 Signed-off-by: Mandeep Singh Baines <msb@chromium.org> CC: Stéphane Marchesin <marcheu@chromium.org> CC: Pawel Osciak <posciak@google.com> CC: Inki Dae <inki.dae@samsung.com> CC: Joonyoung Shim <jy0922.shim@samsung.com> CC: Seung-Woo Kim <sw0312.kim@samsung.com> CC: Kyungmin Park <kyungmin.park@samsung.com> CC: David Airlie <airlied@linux.ie> CC: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)