diff mbox

DRM/Radeon: Fix primary DAC Load Detection for RV100 chips.

Message ID 1351096279-5710-1-git-send-email-eich@suse.de (mailing list archive)
State New, archived
Headers show

Commit Message

Egbert Eich Oct. 24, 2012, 4:31 p.m. UTC
For Radeon 7500 ATI recommends a DAC_FORCE value of 0x1ac. This value
works better on ES1000 (RV100) chips, too, as it doesn't produce any false
positives on any cards I have tested. Therefore let's assume that this
value is good for all RV100 and RV200 chipset generations.

Signed-off-by: Egbert Eich <eich@suse.de>
---
 drivers/gpu/drm/radeon/radeon_legacy_encoders.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Comments

Alex Deucher Oct. 24, 2012, 4:57 p.m. UTC | #1
On Wed, Oct 24, 2012 at 12:31 PM, Egbert Eich <eich@suse.de> wrote:
> For Radeon 7500 ATI recommends a DAC_FORCE value of 0x1ac. This value
> works better on ES1000 (RV100) chips, too, as it doesn't produce any false
> positives on any cards I have tested. Therefore let's assume that this
> value is good for all RV100 and RV200 chipset generations.

Looks good.  Added to by -fixes queue.

Thanks!

Alex

>
> Signed-off-by: Egbert Eich <eich@suse.de>
> ---
>  drivers/gpu/drm/radeon/radeon_legacy_encoders.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> index 752e98b..c7916ac 100644
> --- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> +++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> @@ -659,6 +659,8 @@ static enum drm_connector_status radeon_legacy_primary_dac_detect(struct drm_enc
>
>         if (ASIC_IS_R300(rdev))
>                 tmp |= (0x1b6 << RADEON_DAC_FORCE_DATA_SHIFT);
> +       else if (ASIC_IS_RV100(rdev))
> +               tmp |= (0x1ac << RADEON_DAC_FORCE_DATA_SHIFT);
>         else
>                 tmp |= (0x180 << RADEON_DAC_FORCE_DATA_SHIFT);
>
> --
> 1.7.6.3
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
index 752e98b..c7916ac 100644
--- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
+++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
@@ -659,6 +659,8 @@  static enum drm_connector_status radeon_legacy_primary_dac_detect(struct drm_enc
 
 	if (ASIC_IS_R300(rdev))
 		tmp |= (0x1b6 << RADEON_DAC_FORCE_DATA_SHIFT);
+	else if (ASIC_IS_RV100(rdev))
+		tmp |= (0x1ac << RADEON_DAC_FORCE_DATA_SHIFT);
 	else
 		tmp |= (0x180 << RADEON_DAC_FORCE_DATA_SHIFT);