From patchwork Thu Nov 15 05:11:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inki Dae X-Patchwork-Id: 1747021 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 795FE3FCA5 for ; Thu, 15 Nov 2012 05:11:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B3679E918 for ; Wed, 14 Nov 2012 21:11:24 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by gabe.freedesktop.org (Postfix) with ESMTP id D94989E744 for ; Wed, 14 Nov 2012 21:11:12 -0800 (PST) Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MDI009IKJOU9HM0@mailout3.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 15 Nov 2012 14:11:11 +0900 (KST) Received: from epcpdlpp3 ( [203.254.230.43]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 72.A4.01231.F6974A05; Thu, 15 Nov 2012 14:11:11 +0900 (KST) X-AuditID: cbfee61a-b7fa66d0000004cf-bd-50a4796fa6c0 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id B1.A4.01231.F6974A05; Thu, 15 Nov 2012 14:11:11 +0900 (KST) Received: from daeinki-desktop.10.32.193.11 ([10.90.51.53]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MDI00574JQM7R40@mmp2.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 15 Nov 2012 14:11:11 +0900 (KST) From: Inki Dae To: airlied@linux.ie, dri-devel@lists.freedesktop.org Subject: [PATCH v2] drm/exynos: fix overlay updating issue Date: Thu, 15 Nov 2012 14:11:09 +0900 Message-id: <1352956269-21447-1-git-send-email-inki.dae@samsung.com> X-Mailer: git-send-email 1.7.4.1 In-reply-to: <1352895107-16412-1-git-send-email-inki.dae@samsung.com> References: <1352895107-16412-1-git-send-email-inki.dae@samsung.com> DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsVy+t8zbd38yiUBBjdPClhc+fqezYHR4373 caYAxigum5TUnMyy1CJ9uwSujElvJrIXTOGueNu7gKmBcSFnFyMnh4SAicS9G/tYIWwxiQv3 1rN1MXJxCAnMYpRY+/Q7M1xR81uoxHRGiQ9HtjFBOOuZJC7M/ckOUsUmoCoxccV9NhBbRMBU omPSUhYQm1mgUGJhz1MwW1jASqJzXwOYzQJUv3HSUrANvAIuEgua9zNBbFOQWHDvLdgcTgFX idfLl4HNFwKq6fvyggmiV0Di2+RDQHM4gOplJTYdYAa5R0LgDJvEpkNP2SDmSEocXHGDZQKj 8AJGhlWMoqkFyQXFSem5hnrFibnFpXnpesn5uZsYIWEotYNxZYPFIUYBDkYlHl6HH4sDhFgT y4orcw8xSnAwK4nwvjgIFOJNSaysSi3Kjy8qzUktPsToA3TJRGYp0eR8YIzklcQbGhsYGxpa GpqZWpoa4BBWEudt9kgJEBJITyxJzU5NLUgtghnHxMEp1cDI+/Gh75TYOXa5D607PjJNZQ0N Lyl+XMzOPtNE47TS5siO9Usub3BY/OCy346JIRPeqAiwvfryyKBWPVBDIs6uJzNtzgd7yx+z 916wsXycPMXPbWro9pqzXixNcUl6/KHKMov2hp3ym/CpfxE3p9GjHbfmPFLX3MxeZCiy9duS 5EWsMYLSjMFKLMUZiYZazEXFiQCFQIv9cAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphkeLIzCtJLcpLzFFi42I5/e+xoG5+5ZIAg09NPBZXvr5nc2D0uN99 nCmAMaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH aKySQlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMWPSm4nsBVO4K972LmBq YFzI2cXIySEhYCJxr/ktG4QtJnHh3nogm4tDSGA6o8SHI9uYIJz1TBIX5v5kB6liE1CVmLji PliHiICpRMekpSwgNrNAocTCnqdgtrCAlUTnvgYwmwWofuOkpcwgNq+Ai8SC5v1MENsUJBbc g9jMKeAq8Xr5MrD5QkA1fV9eME1g5F3AyLCKUTS1ILmgOCk911CvODG3uDQvXS85P3cTIzjI n0ntYFzZYHGIUYCDUYmH1+HH4gAh1sSy4srcQ4wSHMxKIrwvDgKFeFMSK6tSi/Lji0pzUosP MfoAXTWRWUo0OR8YgXkl8YbGJmZGlkZmxibmxsY4hJXEeZs9UgKEBNITS1KzU1MLUotgxjFx cEo1MM7TX8wU9FPs8mRTldWyp39v3n/JfIEa85yjZ6YFXlrpqJem2WNaJvfZ7a6h6K4PWkUz rr6JbeWOrv/176IF7yEJ5ivWU7nN/sRw814LO2GjOPnR/X7/K3IMPydu5w9ZdGCVStXd3nkp cfrJkXZPFTh2Niy6zllYZJQf2L/j4+JvuT/kl3J9W6zEUpyRaKjFXFScCAC4/gcmnwIAAA== X-CFilter-Loop: Reflected Cc: kyungmin.park@samsung.com, sw0312.kim@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Chagelog v2: Move encoder's dpms updating into exynos_drm_encoder_commit function because when crtc's dpms is updated, encoder's dpms is updated also. This would induce the issue that encoder isn't disabled after crtc is disabled. Changelog v1: This patch fixes a issue that overlay data aren't applied to real hardware when dpms off goes to on after setcrtc was requested like below, dpms off -> setcrtc -> dpms off -> dpms on For this, it makes encoder's dpms to be updated when setcrtc is requested. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c index 241ad1e..607231a 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c +++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c @@ -226,6 +226,12 @@ static void exynos_drm_encoder_commit(struct drm_encoder *encoder) * already updated or not by exynos_drm_encoder_dpms function. */ exynos_encoder->updated = true; + + /* + * In case of setcrtc, there is no way to update encoder's dpms + * so update it here. + */ + exynos_encoder->dpms = DRM_MODE_DPMS_ON; } static void exynos_drm_encoder_disable(struct drm_encoder *encoder)