From patchwork Mon Nov 19 05:27:43 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 1763471 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 08FC73FCAE for ; Mon, 19 Nov 2012 08:31:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0381AE6065 for ; Mon, 19 Nov 2012 00:31:31 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pb0-f49.google.com (mail-pb0-f49.google.com [209.85.160.49]) by gabe.freedesktop.org (Postfix) with ESMTP id ACADFE600B for ; Sun, 18 Nov 2012 21:33:50 -0800 (PST) Received: by mail-pb0-f49.google.com with SMTP id un15so2985490pbc.36 for ; Sun, 18 Nov 2012 21:33:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=d8l3OlfhWtoaLbWXi5IQs/aNHvNgvha1UHIbqoORGKw=; b=fHQtVeuUA1j/Re1aNZhgE6QRNqVH9LIAQToQJc0/AWMdYpAt3Ikl+xboxzV1Ab4BO1 wOqIhE1Lz9CBbnzLZtMxSY2f671df1rknuBcgjQc3JxCVrkAhpYSsU0M+GkJ8rYqXERG qPrnhzNYHhvKFzedS/rR8TSRNRbQ3/7Try4qtBAL0/P/2+oLn3yKTg+biCbE1nh4UGgk cNGEpnn1iIkkTxErAqU1SF83VN+le3lGtsJpfrt4G1irDran6hMEjjboR+Qk4i6C9+Qi V6qD+TYKwXA2NqvJbq7ap2teHjqlu0I5wYY323Q2LqIHpslalGEcc0dG/ZiNQhhN5fWD skRg== Received: by 10.66.89.9 with SMTP id bk9mr32624080pab.67.1353303230477; Sun, 18 Nov 2012 21:33:50 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id se4sm5605309pbb.13.2012.11.18.21.33.47 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 18 Nov 2012 21:33:49 -0800 (PST) From: Sachin Kamat To: dri-devel@lists.freedesktop.org Subject: [PATCH 1/1] drm/udl: Add missing static storage class specifiers in udl_connector.c Date: Mon, 19 Nov 2012 10:57:43 +0530 Message-Id: <1353302863-5462-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQn1BnD9bVbSq2IiCq6RanOKsnGUu3cLv9RKJFRgPP+28iWjXzXdxhLMH7ffT/zNYIou1eu3 X-Mailman-Approved-At: Mon, 19 Nov 2012 00:17:21 -0800 Cc: sachin.kamat@linaro.org, patches@linaro.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Fixes the following sparse warnings: drivers/gpu/drm/udl/udl_connector.c:80:20: warning: symbol 'udl_best_single_encoder' was not declared. Should it be static? drivers/gpu/drm/udl/udl_connector.c:93:5: warning: symbol 'udl_connector_set_property' was not declared. Should it be static? drivers/gpu/drm/udl/udl_connector.c:106:35: warning: symbol 'udl_connector_helper_funcs' was not declared. Should it be static? drivers/gpu/drm/udl/udl_connector.c:112:28: warning: symbol 'udl_connector_funcs' was not declared. Should it be static? Signed-off-by: Sachin Kamat Reviewed-by: Alex Deucher --- drivers/gpu/drm/udl/udl_connector.c | 12 +++++++----- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/udl/udl_connector.c b/drivers/gpu/drm/udl/udl_connector.c index b3b2ced..25b93de 100644 --- a/drivers/gpu/drm/udl/udl_connector.c +++ b/drivers/gpu/drm/udl/udl_connector.c @@ -84,7 +84,8 @@ udl_detect(struct drm_connector *connector, bool force) return connector_status_connected; } -struct drm_encoder *udl_best_single_encoder(struct drm_connector *connector) +static struct drm_encoder* +udl_best_single_encoder(struct drm_connector *connector) { int enc_id = connector->encoder_ids[0]; struct drm_mode_object *obj; @@ -97,8 +98,9 @@ struct drm_encoder *udl_best_single_encoder(struct drm_connector *connector) return encoder; } -int udl_connector_set_property(struct drm_connector *connector, struct drm_property *property, - uint64_t val) +static int udl_connector_set_property(struct drm_connector *connector, + struct drm_property *property, + uint64_t val) { return 0; } @@ -110,13 +112,13 @@ static void udl_connector_destroy(struct drm_connector *connector) kfree(connector); } -struct drm_connector_helper_funcs udl_connector_helper_funcs = { +static struct drm_connector_helper_funcs udl_connector_helper_funcs = { .get_modes = udl_get_modes, .mode_valid = udl_mode_valid, .best_encoder = udl_best_single_encoder, }; -struct drm_connector_funcs udl_connector_funcs = { +static struct drm_connector_funcs udl_connector_funcs = { .dpms = drm_helper_connector_dpms, .detect = udl_detect, .fill_modes = drm_helper_probe_single_connector_modes,