From patchwork Fri Nov 23 14:09:27 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paulo Zanoni X-Patchwork-Id: 1795701 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id 7C5DEDF254 for ; Fri, 23 Nov 2012 14:12:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7BBF2E66B0 for ; Fri, 23 Nov 2012 06:12:02 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-gg0-f177.google.com (mail-gg0-f177.google.com [209.85.161.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 0BA7EE66A0; Fri, 23 Nov 2012 06:09:57 -0800 (PST) Received: by mail-gg0-f177.google.com with SMTP id y3so1200550ggc.36 for ; Fri, 23 Nov 2012 06:09:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=jWLjkPqLZYx8mQNK7BX2CyhRVhcxLd72zpGIVnNNiio=; b=XjBdHXf1H4vImvBqJ8aJHpVd1l8B9oHB8fK/ikz+TVBP01/tRhbC/dR8MDvNGaJReQ FRrkGuHAe71tpqnKU2/zhU8cVn7nKniyXpQqL+/dllBcGuLBsLG8dKXC/Nm+D4GHnXlC knZFiKaXFgb7P3wZA8Ve7dIQZ1Tsu+YULDK4MUH3QqKJpOxgi3w4N2Dx9y6VIcF1DiWl oHqlqsM+LYRQsm2Sif/+ESbuHTbTNwsQd4ynq4EdXFZijJq+D2ByO4X8Usw6EdMNPrDQ 3hIPYu7DUaWDgCwXV7gZNMMyI5jgVK6F8zBv04Q1mD2y+gtrzBBui6c/U2Fw2/uUZGuM RBng== Received: by 10.236.82.169 with SMTP id o29mr3936869yhe.116.1353679797497; Fri, 23 Nov 2012 06:09:57 -0800 (PST) Received: from vicky.domain.invalid ([187.112.188.105]) by mx.google.com with ESMTPS id t46sm6503725yhi.3.2012.11.23.06.09.55 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 23 Nov 2012 06:09:56 -0800 (PST) From: Paulo Zanoni To: dri-devel@lists.freedesktop.org Subject: [PATCH 2/2] drm/i915: set the VIC of the mode on the AVI InfoFrame Date: Fri, 23 Nov 2012 12:09:27 -0200 Message-Id: <1353679767-3737-2-git-send-email-przanoni@gmail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1353679767-3737-1-git-send-email-przanoni@gmail.com> References: <1353679767-3737-1-git-send-email-przanoni@gmail.com> Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org From: Paulo Zanoni We currently set "0" as the VIC value of the AVI InfoFrames. According to the specs this should be fine and work for every mode, so to my point of view we can't consider the current behavior as a bug. The problem is that we recently received a bug report (Kernel bug #50371) from a user that has an AV receiver that gives a black screen for any mode with VIC set to 0. So in order to make at least some modes work for him, this patch sets the correct VIC number when sending AVI InfoFrames. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=50371 Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index 1dcfd5b..eaf70d6 100644 --- a/drivers/gpu/drm/i915/intel_hdmi.c +++ b/drivers/gpu/drm/i915/intel_hdmi.c @@ -340,6 +340,8 @@ static void intel_hdmi_set_avi_infoframe(struct drm_encoder *encoder, if (adjusted_mode->flags & DRM_MODE_FLAG_DBLCLK) avi_if.body.avi.YQ_CN_PR |= DIP_AVI_PR_2; + avi_if.body.avi.VIC = drm_mode_cea_vic(adjusted_mode); + intel_set_infoframe(encoder, &avi_if); }