From patchwork Wed Dec 12 16:16:42 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= X-Patchwork-Id: 1869531 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id 15216DF266 for ; Wed, 12 Dec 2012 18:08:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 18B9DE65EE for ; Wed, 12 Dec 2012 10:08:50 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 4BBB6E5CB7; Wed, 12 Dec 2012 08:21:24 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 12 Dec 2012 08:21:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,267,1355126400"; d="scan'208";a="263033727" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.168]) by fmsmga002.fm.intel.com with SMTP; 12 Dec 2012 08:21:21 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 12 Dec 2012 18:21:19 +0200 From: ville.syrjala@linux.intel.com To: dri-devel@lists.freedesktop.org Subject: [PATCH 75/81] drm/i915: Drop some stale FIXMEs from the atomic code Date: Wed, 12 Dec 2012 18:16:42 +0200 Message-Id: <1355329008-31459-76-git-send-email-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 1.7.8.6 In-Reply-To: <1355329008-31459-1-git-send-email-ville.syrjala@linux.intel.com> References: <1355329008-31459-1-git-send-email-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Cc: intel-gfx@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org From: Ville Syrjälä Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_atomic.c | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_atomic.c b/drivers/gpu/drm/i915/intel_atomic.c index 415cd72..efdaff3 100644 --- a/drivers/gpu/drm/i915/intel_atomic.c +++ b/drivers/gpu/drm/i915/intel_atomic.c @@ -717,7 +717,6 @@ static void crtc_commit(struct drm_crtc *crtc) dev_priv->display.crtc_enable(&intel_crtc->base); /* FIXME need to check where this stuff is used really */ - /* FIXME need to update DPMS state somewhere */ list_for_each_entry(intel_encoder, &dev->mode_config.encoder_list, base.head) { if (intel_encoder->base.crtc == crtc) intel_encoder->connectors_active = true; @@ -1210,8 +1209,6 @@ static void restore_state(struct drm_device *dev, /* must restore the new_crtc and new_encoder pointers as well */ intel_modeset_update_staged_output_state(dev); - /* FIXME props etc. */ - /* was the hardware state clobbered? */ if (s->restore_hw) apply_config(dev, s); @@ -1523,7 +1520,6 @@ static void update_crtc(struct drm_device *dev, struct intel_crtc_state *st = &s->crtc[i]; struct drm_crtc *crtc = st->crtc; - /* FIXME is this OK? */ if (st->fb_dirty && !st->mode_dirty) { mutex_lock(&dev->struct_mutex); intel_update_fbc(dev);