From patchwork Fri Dec 21 04:20:42 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eunchul Kim X-Patchwork-Id: 1902031 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id C0289DFAC4 for ; Fri, 21 Dec 2012 04:24:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C4A23E6769 for ; Thu, 20 Dec 2012 20:24:31 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id F2473E5CEC for ; Thu, 20 Dec 2012 20:20:32 -0800 (PST) Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MFD005ML5DYWAF0@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 21 Dec 2012 13:20:29 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.46]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 4E.ED.01231.D83E3D05; Fri, 21 Dec 2012 13:20:29 +0900 (KST) X-AuditID: cbfee61a-b7fa66d0000004cf-07-50d3e38d5979 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id EB.ED.01231.D83E3D05; Fri, 21 Dec 2012 13:20:29 +0900 (KST) Received: from localhost.localdomain ([10.90.54.32]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MFD009P95E1VT50@mmp2.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 21 Dec 2012 13:20:29 +0900 (KST) From: Eunchul Kim To: dri-devel@lists.freedesktop.org, inki.dae@samsung.com Subject: [PATCH v2 2/8] drm/exynos: removed needless error handling about property. Date: Fri, 21 Dec 2012 13:20:42 +0900 Message-id: <1356063648-12447-3-git-send-email-chulspro.kim@samsung.com> X-Mailer: git-send-email 1.7.0.4 In-reply-to: <1356063648-12447-1-git-send-email-chulspro.kim@samsung.com> References: <1356063648-12447-1-git-send-email-chulspro.kim@samsung.com> DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsVy+t8zPd3ex5cDDKYsFLC48vU9mwOjx/3u 40wBjFFcNimpOZllqUX6dglcGW//v2YumCZZcezYXNYGxg7RLkZODgkBE4llBzaxQdhiEhfu rQeyuTiEBJYxSiyYsIENpujs3RmsEInpjBKXtu5mBEkICaxgkmg5qwpiswnoSBy51cwMYosI WEo82PqbGaSBWeAno8S6J2dZQRLCAqESF7d0s4PYLAKqEnN7D4AN4hXwkNhy+hULxDYFidZl h8BqOAU8JZq2fWGFWOYhcb7nNxtEr4DEt8mHgOo5gOplJTYdANslIXCdTWLjoQtMEHMkJQ6u uMEygVF4ASPDKkbR1ILkguKk9FxDveLE3OLSvHS95PzcTYyQMJTawbiyweIQowAHoxIPL6PZ 5QAh1sSy4srcQ4wSHMxKIrzPlwCFeFMSK6tSi/Lji0pzUosPMfoAXTKRWUo0OR8YI3kl8YbG BsaGhpaGZqaWpgY4hJXEeZs9UgKEBNITS1KzU1MLUotgxjFxcEo1MNb1HVrwSzOpQlNqF8Oq 1E0H3PIeTTl++VXG6U8LxcVvyT5NL8h5qiHD1lIiNO9Fim1siJNp60spX0Xx2bsvJoUtWCfU 6bEh8oKa99OYbVbR0sa3iye2ntafs3GbQVTEduZPCco96YoLslW4p8yIiQw5mlvTO+PHlqcT sr594u9Rn2Oh/WJighJLcUaioRZzUXEiAHwyyThwAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphkeLIzCtJLcpLzFFi42I5/e+xoG7v48sBBjcncltc+fqezYHR4373 caYAxqgGRpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wc oLFKCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1DguB6jAzQQMI6xoy3/18zF0yTrDh2bC5r A2OHaBcjJ4eEgInE2bszWCFsMYkL99azdTFycQgJTGeUuLR1NyNIQkhgBZNEy1lVEJtNQEfi yK1mZhBbRMBS4sHW38wgDcwCPxkl1j05CzZJWCBU4uKWbnYQm0VAVWJu7wGwQbwCHhJbTr9i gdimING67BBYDaeAp0TTti+sEMs8JM73/GabwMi7gJFhFaNoakFyQXFSeq6hXnFibnFpXrpe cn7uJkZwkD+T2sG4ssHiEKMAB6MSDy+j2eUAIdbEsuLK3EOMEhzMSiK8z5cAhXhTEiurUovy 44tKc1KLDzH6AF01kVlKNDkfGIF5JfGGxiZmRpZGZsYm5sbGOISVxHmbPVIChATSE0tSs1NT C1KLYMYxcXBKNTB6Vy5Z8703PEE27ztTwC7/k/teXjphf6XXevk+KdV8rsWbU6Pk7e6dqNxs 2HxritWWgMfVr7M1kjhsulLr33+uXhYo+PVK8qtrzy//fvXoKs+p/Q0FtyNXn7y6a3GHVcKV v+b18+bu/3mZ10K9zOzRbZlPk+SXODqsfJhUND+7IClv7pR9jvmWSizFGYmGWsxFxYkAP+aa PJ8CAAA= X-CFilter-Loop: Reflected Cc: jy0.jeon@samsung.com, sw0312.kim@samsung.com, jaejoon.seo@samsung.com, kyungmin.park@samsung.com, jmock.shin@samsung.com, lsmin.lee@samsung.com, th908.kim@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org This patch removed property error handling. property couldn't be NULL. so, I removed it. Signed-off-by: Eunchul Kim --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 12 ------------ drivers/gpu/drm/exynos/exynos_drm_gsc.c | 12 ------------ drivers/gpu/drm/exynos/exynos_drm_ipp.c | 5 ----- 3 files changed, 0 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c index 7a3e460..5dc0251 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c @@ -705,10 +705,6 @@ static int fimc_src_set_addr(struct device *dev, } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EINVAL; - } DRM_DEBUG_KMS("%s:prop_id[%d]buf_id[%d]buf_type[%d]\n", __func__, property->prop_id, buf_id, buf_type); @@ -1241,10 +1237,6 @@ static int fimc_dst_set_addr(struct device *dev, } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EINVAL; - } DRM_DEBUG_KMS("%s:prop_id[%d]buf_id[%d]buf_type[%d]\n", __func__, property->prop_id, buf_id, buf_type); @@ -1573,10 +1565,6 @@ static int fimc_ippdrv_start(struct device *dev, enum drm_exynos_ipp_cmd cmd) } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EINVAL; - } fimc_handle_irq(ctx, true, false, true); diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c index c443c3b..ba5fefd 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c @@ -720,10 +720,6 @@ static int gsc_src_set_addr(struct device *dev, } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EFAULT; - } DRM_DEBUG_KMS("%s:prop_id[%d]buf_id[%d]buf_type[%d]\n", __func__, property->prop_id, buf_id, buf_type); @@ -1180,10 +1176,6 @@ static int gsc_dst_set_addr(struct device *dev, } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EFAULT; - } DRM_DEBUG_KMS("%s:prop_id[%d]buf_id[%d]buf_type[%d]\n", __func__, property->prop_id, buf_id, buf_type); @@ -1565,10 +1557,6 @@ static int gsc_ippdrv_start(struct device *dev, enum drm_exynos_ipp_cmd cmd) } property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property.\n"); - return -EINVAL; - } gsc_handle_irq(ctx, true, false, true); diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos/exynos_drm_ipp.c index ba45f9a..cac94fe 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_ipp.c +++ b/drivers/gpu/drm/exynos/exynos_drm_ipp.c @@ -1487,11 +1487,6 @@ void ipp_sched_cmd(struct work_struct *work) mutex_lock(&c_node->cmd_lock); property = &c_node->property; - if (!property) { - DRM_ERROR("failed to get property:prop_id[%d]\n", - c_node->property.prop_id); - goto err_unlock; - } switch (cmd_work->ctrl) { case IPP_CTRL_PLAY: