From patchwork Mon Dec 24 08:33:44 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 1908331 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 02C0540061 for ; Mon, 24 Dec 2012 09:40:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E95B1E6114 for ; Mon, 24 Dec 2012 01:40:54 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pb0-f44.google.com (mail-pb0-f44.google.com [209.85.160.44]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FBC5E5C30 for ; Mon, 24 Dec 2012 00:42:11 -0800 (PST) Received: by mail-pb0-f44.google.com with SMTP id uo1so3852293pbc.3 for ; Mon, 24 Dec 2012 00:42:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=gYAwfCU6huYj6Jv5Es7QWxxRY3oDwBHf3KlKMdUOl/c=; b=pwc7Lvhwm1si1OHs89KYxnaISfd1HhESguSoviIkEIPhdq3Mn9xC+M27dIXuCH36vx hmi7C9FHYEHCtSD725/Mjzbt3g7rPYj5WrI+0p6jgKhK53EnDNKtR+MCUV4+oBs403VV g4b0llwc6C6ScYicGScKwmAR3z8GViQCgv3+wBw9Q9eq2sOoo9nlK1eY7SfTmAhBi/5i /5nGXEaDzSyJ8cylbv7IxZtxoGTnpFV93ZtOGwZZuO4rSoNRcaG/GJqsuSf9so63o6Yl palo38DtqPRaQI5eajc9pGG1gItXgUk4W5Sj1QenELb0u7pUoSOPKO+7dWwCBK6Plni4 90Tw== X-Received: by 10.66.52.102 with SMTP id s6mr61387331pao.6.1356338531405; Mon, 24 Dec 2012 00:42:11 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id pv8sm11959096pbc.26.2012.12.24.00.42.08 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 24 Dec 2012 00:42:10 -0800 (PST) From: Sachin Kamat To: dri-devel@lists.freedesktop.org Subject: [PATCH 03/10] drm/exynos: Remove redundant NULL check Date: Mon, 24 Dec 2012 14:03:44 +0530 Message-Id: <1356338031-23674-4-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1356338031-23674-1-git-send-email-sachin.kamat@linaro.org> References: <1356338031-23674-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQkyy6LcCseIHuirzFZ2zM2wGkra/lD38CScOMl8c+tb9zP0IV20dm1D/oJRTGiUQcxChMzE X-Mailman-Approved-At: Mon, 24 Dec 2012 01:36:57 -0800 Cc: sachin.kamat@linaro.org, patches@linaro.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org devm_request_and_ioremap API checks for NULL. Hence explicit NULL check is not necessary. Saves some code. Cc: Eunchul Kim Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c index ab75150..972aa70 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c @@ -1801,12 +1801,6 @@ static int __devinit fimc_probe(struct platform_device *pdev) /* resource memory */ ctx->regs_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!ctx->regs_res) { - dev_err(dev, "failed to find registers.\n"); - ret = -ENOENT; - goto err_clk; - } - ctx->regs = devm_request_and_ioremap(dev, ctx->regs_res); if (!ctx->regs) { dev_err(dev, "failed to map registers.\n");