From patchwork Thu Dec 27 11:40:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Prathyush K X-Patchwork-Id: 1912651 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork1.kernel.org (Postfix) with ESMTP id 6CB6A3FC66 for ; Thu, 27 Dec 2012 11:19:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2A0F0E5D2F for ; Thu, 27 Dec 2012 03:19:24 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTP id 90B85E5C1E for ; Thu, 27 Dec 2012 03:19:10 -0800 (PST) Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MFO00ILVSRQA9E0@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 27 Dec 2012 20:19:09 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.126]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id CB.32.01231.DAE2CD05; Thu, 27 Dec 2012 20:19:09 +0900 (KST) X-AuditID: cbfee61a-b7fa66d0000004cf-63-50dc2ead5da9 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 9B.32.01231.DAE2CD05; Thu, 27 Dec 2012 20:19:09 +0900 (KST) Received: from chrome-ubuntu.sisodomain.com ([107.108.73.106]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MFO001KVSPMPQ20@mmp1.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 27 Dec 2012 20:19:09 +0900 (KST) From: Prathyush K To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm/exynos: fimd: modify condition in fimd resume Date: Thu, 27 Dec 2012 06:40:13 -0500 Message-id: <1356608413-6295-1-git-send-email-prathyush.k@samsung.com> X-Mailer: git-send-email 1.8.0 DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKLMWRmVeSWpSXmKPExsWyRsSkTnet3p0Agytd4hZXvr5nc2D0uN99 nCmAMYrLJiU1J7MstUjfLoErY9G8+awFbzkqzl15y9TAuJa9i5GTQ0LAROLspDssELaYxIV7 69m6GLk4hASWMkpMbFjODFN06cpLqMQiRok7K/4xQTgbmSQmv/4OVsUmoC3xa85dVhBbREBZ 4u/EVYwgNrOAhMSR9rNsILawgJPEs1kzwGpYBFQl9n76BmbzCrhJPJ98GeokOYkPex6xQ9QI SHybfAjoPA6guKzEpgPMIHslBHawSay7epQNol5S4uCKGywTGAUXMDKsYhRNLUguKE5KzzXU K07MLS7NS9dLzs/dxAgMq9P/nkntYFzZYHGIUYCDUYmHV9H6doAQa2JZcWXuIUYJDmYlEd6/ sncChHhTEiurUovy44tKc1KLDzH6AF0ykVlKNDkfGPJ5JfGGxibmpsamlkZGZqamOISVxHmb PVIChATSE0tSs1NTC1KLYMYxcXBKNTAelVE44Rec15XwXU69X3rlX7VFwQsrt7p94pJ5ahD3 4+x/NfvDnEUSWu/O5wRXPoiOzHSo7bq1k2HrzNtF++J+cxuyLy9btLf96asPoc9EazXPmLfz N0hcOtZyeY31wqqPHSdblm8xUH36/nDFr0UZs1quyUpzrO6+cfjZ9VcKS7a7Oxyv2xClxFKc kWioxVxUnAgAtlpVjFgCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrCLMWRmVeSWpSXmKPExsVy+t9jAd21encCDJb1C1hc+fqezYHR4373 caYAxqgGRpuM1MSU1CKF1Lzk/JTMvHRbJe/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wc oLFKCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1DguB6jAzQQMIaxoxF8+azFrzlqDh35S1T A+Na9i5GTg4JAROJS1deskHYYhIX7q0Hsrk4hAQWMUrcWfGPCcLZyCQx+fV3ZpAqNgFtiV9z 7rKC2CICyhJ/J65iBLGZBSQkjrSfBZskLOAk8WzWDLAaFgFVib2fvoHZvAJuEs8nX4baLCfx Yc8j9gmM3AsYGVYxiqYWJBcUJ6XnGuoVJ+YWl+al6yXn525iBAftM6kdjCsbLA4xCnAwKvHw KlrfDhBiTSwrrsw9xCjBwawkwvtX9k6AEG9KYmVValF+fFFpTmrxIUYfoO0TmaVEk/OBEZVX Em9obGJuamxqaWJhYmaJQ1hJnLfZIyVASCA9sSQ1OzW1ILUIZhwTB6dUA6O9VXJ3SEHybeGL TsvP8dbPUjEvPm+hVy/tOvucXJn6R7bNL+Wa2Rw/WV7brlqU9+nYo8WLFXPEP+74LKkhvuW+ GGuR9+kpPrNalhTsWaHCu62LY3nDlXXiqoKzHqyx/rrIfYHrr69nfX6sqt9zl+lWb12QlfXS kh8Jyz3vM/Z8ZHpXMifK7ZISS3FGoqEWc1FxIgByRWaYhwIAAA== X-CFilter-Loop: Reflected X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org If fimd is runtime suspended (by DPMS OFF), fimd_suspend does not call fimd_activate(false) and just returns. Similarily the check in fimd_resume should not resume if previously runtime_suspended. Instead the existing check does the opposite. So if fimd was not runtime suspended, suspend will turn off fimd but resume will not turn it on. This patch fixes this issue by reversing the condition. Signed-off-by: Prathyush K --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index bf0d9ba..9accd466 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -1046,7 +1046,7 @@ static int fimd_resume(struct device *dev) * of pm runtime would still be 1 so in this case, fimd driver * should be on directly not drawing on pm runtime interface. */ - if (pm_runtime_suspended(dev)) { + if (!pm_runtime_suspended(dev)) { int ret; ret = fimd_activate(ctx, true);