| Message ID | 1358788568-11137-9-git-send-email-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Checked it out and applied. For ARCH_MULTIPLATFORM support, Such header files shouldn't be included. And for this, we are planning on supporting device tree for ipp driver. Thanks, Inki Dae 2013/1/22 Arnd Bergmann <arnd@arndb.de>: > While the exynos DRM support in principle can work on > multiplatform, the FIMD and IPP sections of it both > include the plat/map-base.h header file, which is > not available on multiplatform. Rather than disabling > the entire driver, we can just conditionally build > these two parts. > > Without this patch, building allyesconfig results in: > > drivers/gpu/drm/exynos/exynos_drm_fimc.c:19:27: fatal error: plat/map-base.h: No such file or directory > drivers/gpu/drm/exynos/exynos_drm_ipp.c:20:27: fatal error: plat/map-base.h: No such file or directory > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Cc: Joonyoung Shim <jy0922.shim@samsung.com> > Cc: Inki Dae <inki.dae@samsung.com> > Cc: Seung-Woo Kim <sw0312.kim@samsung.com> > Cc: Kyungmin Park <kyungmin.park@samsung.com> > Cc: David Airlie <airlied@linux.ie> > Cc: dri-devel@lists.freedesktop.org > --- > drivers/gpu/drm/exynos/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig > index 1d1f1e5..046bcda 100644 > --- a/drivers/gpu/drm/exynos/Kconfig > +++ b/drivers/gpu/drm/exynos/Kconfig > @@ -24,7 +24,7 @@ config DRM_EXYNOS_DMABUF > > config DRM_EXYNOS_FIMD > bool "Exynos DRM FIMD" > - depends on DRM_EXYNOS && !FB_S3C > + depends on DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM > help > Choose this option if you want to use Exynos FIMD for DRM. > > @@ -48,7 +48,7 @@ config DRM_EXYNOS_G2D > > config DRM_EXYNOS_IPP > bool "Exynos DRM IPP" > - depends on DRM_EXYNOS > + depends on DRM_EXYNOS && !ARCH_MULTIPLATFORM > help > Choose this option if you want to use IPP feature for DRM. > > -- > 1.7.10.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index 1d1f1e5..046bcda 100644 --- a/drivers/gpu/drm/exynos/Kconfig +++ b/drivers/gpu/drm/exynos/Kconfig @@ -24,7 +24,7 @@ config DRM_EXYNOS_DMABUF config DRM_EXYNOS_FIMD bool "Exynos DRM FIMD" - depends on DRM_EXYNOS && !FB_S3C + depends on DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM help Choose this option if you want to use Exynos FIMD for DRM. @@ -48,7 +48,7 @@ config DRM_EXYNOS_G2D config DRM_EXYNOS_IPP bool "Exynos DRM IPP" - depends on DRM_EXYNOS + depends on DRM_EXYNOS && !ARCH_MULTIPLATFORM help Choose this option if you want to use IPP feature for DRM.
While the exynos DRM support in principle can work on multiplatform, the FIMD and IPP sections of it both include the plat/map-base.h header file, which is not available on multiplatform. Rather than disabling the entire driver, we can just conditionally build these two parts. Without this patch, building allyesconfig results in: drivers/gpu/drm/exynos/exynos_drm_fimc.c:19:27: fatal error: plat/map-base.h: No such file or directory drivers/gpu/drm/exynos/exynos_drm_ipp.c:20:27: fatal error: plat/map-base.h: No such file or directory Signed-off-by: Arnd Bergmann <arnd@arndb.de> Cc: Joonyoung Shim <jy0922.shim@samsung.com> Cc: Inki Dae <inki.dae@samsung.com> Cc: Seung-Woo Kim <sw0312.kim@samsung.com> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: David Airlie <airlied@linux.ie> Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/exynos/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)