| Message ID | 1362517656.16460.125.camel@x61.thuisdomein (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Mar 05, 2013 at 10:07:36PM +0100, Paul Bolle wrote: > Commit ac24c2204a76e5b42aa103bf963ae0eda1b827f3 ("drm/tegra: Use generic > HDMI infoframe helpers") added "select DRM_HDMI" to the DRM_TEGRA > Kconfig entry. But there is no Kconfig symbol named DRM_HDMI. The select > statement for that symbol is a nop. Drop it. > > What was needed to use HDMI functionality was to select HDMI (which this > entry already did through depending on DRM) and to include linux/hdmi.h > (which this commit also did). > > Signed-off-by: Paul Bolle <pebolle@tiscali.nl> > --- > Untested. > > drivers/gpu/drm/tegra/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig > index c92955d..be1daf7 100644 > --- a/drivers/gpu/drm/tegra/Kconfig > +++ b/drivers/gpu/drm/tegra/Kconfig > @@ -4,7 +4,6 @@ config DRM_TEGRA > select DRM_KMS_HELPER > select DRM_GEM_CMA_HELPER > select DRM_KMS_CMA_HELPER > - select DRM_HDMI > select FB_CFB_FILLRECT > select FB_CFB_COPYAREA > select FB_CFB_IMAGEBLIT Good catch! I think what happened here is that the DRM HDMI helpers used to be in a separate file and DRM_HDMI enabled that file to be built. The helpers were moved into drm_edid.c at some point, though, and the symbol was dropped and I forgot to remove it from the Tegra DRM Kconfig. Acked-by: <thierry.reding@avionic-design.de>
diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig index c92955d..be1daf7 100644 --- a/drivers/gpu/drm/tegra/Kconfig +++ b/drivers/gpu/drm/tegra/Kconfig @@ -4,7 +4,6 @@ config DRM_TEGRA select DRM_KMS_HELPER select DRM_GEM_CMA_HELPER select DRM_KMS_CMA_HELPER - select DRM_HDMI select FB_CFB_FILLRECT select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT
Commit ac24c2204a76e5b42aa103bf963ae0eda1b827f3 ("drm/tegra: Use generic HDMI infoframe helpers") added "select DRM_HDMI" to the DRM_TEGRA Kconfig entry. But there is no Kconfig symbol named DRM_HDMI. The select statement for that symbol is a nop. Drop it. What was needed to use HDMI functionality was to select HDMI (which this entry already did through depending on DRM) and to include linux/hdmi.h (which this commit also did). Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- Untested. drivers/gpu/drm/tegra/Kconfig | 1 - 1 file changed, 1 deletion(-)