From patchwork Mon Apr 29 06:57:05 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 2500361 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by patchwork2.kernel.org (Postfix) with ESMTP id 3FDCBDF25A for ; Mon, 29 Apr 2013 14:01:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 18B09E60D5 for ; Mon, 29 Apr 2013 07:01:25 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com [209.85.220.44]) by gabe.freedesktop.org (Postfix) with ESMTP id D668FE5CDD for ; Mon, 29 Apr 2013 00:09:51 -0700 (PDT) Received: by mail-pa0-f44.google.com with SMTP id rl6so327211pac.31 for ; Mon, 29 Apr 2013 00:09:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=U8ZEmX2MxoECUiOS6/sXfiqE8eyuN34tsNjhgf+0TzM=; b=lL6F9mxEYjJ1TxkcJkbYjatnHggyXcPiA7xo+ck5PzSPIzBYoGEyP7bcP4e/AI6XoS 5+O4PYTVcFuRPG0OFRPP//gQLzGmVYAtEsLEnBu/+wWfKCBTBOoxNjPuw9pi2IZJ15PP T7eeZ4ieacUSs96AYBF9ZZFkDPB/8b/Qly4bNrZwibZejvivuI413yjbVjDan4uB4tDr afR+cALim0hMmriaq3LKesdPSvmGcqTJsd4b2dJSDYn2Kzya7mBYCeQLwXspo94ZOT2b A/OXRvqmnXsBi3TtXf6/5NEPeWZTrc/UCS1vqyZlwiy7bgdHX5TvyQVD25UjpEscgKhW kxDQ== X-Received: by 10.68.164.3 with SMTP id ym3mr68474125pbb.205.1367219391555; Mon, 29 Apr 2013 00:09:51 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id al2sm22875654pbc.25.2013.04.29.00.09.48 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Apr 2013 00:09:50 -0700 (PDT) From: Sachin Kamat To: dri-devel@lists.freedesktop.org Subject: [PATCH 1/2] drm/exynos: exynos_drm_fbdev: Fix incorrect usage of IS_ERR_OR_NULL Date: Mon, 29 Apr 2013 12:27:05 +0530 Message-Id: <1367218626-13782-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Gm-Message-State: ALoCoQldTKupaeXgs8ApTxnSBXf1Ln+sDpZGwUFnldPQCdZoTI1MXc8fCBqr4MgXnG5/Nh25WAiB X-Mailman-Approved-At: Mon, 29 Apr 2013 06:59:45 -0700 Cc: sachin.kamat@linaro.org, patches@linaro.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org exynos_drm_framebuffer_init() does not return NULL. Use IS_ERR instead. Signed-off-by: Sachin Kamat --- This series is based on exynos-drm-next branch of Inki Dae's tree: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index 68f0045..8f007aa 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c @@ -182,7 +182,7 @@ static int exynos_drm_fbdev_create(struct drm_fb_helper *helper, helper->fb = exynos_drm_framebuffer_init(dev, &mode_cmd, &exynos_gem_obj->base); - if (IS_ERR_OR_NULL(helper->fb)) { + if (IS_ERR(helper->fb)) { DRM_ERROR("failed to create drm framebuffer.\n"); ret = PTR_ERR(helper->fb); goto err_destroy_gem;