| Message ID | 1370002628-16417-2-git-send-email-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Fri, May 31, 2013 at 2:17 PM, <ville.syrjala@linux.intel.com> wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Keeping the modes in the same order as we probe them makes it a bit > easier to track what's happening. > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> I've just added a regression fixer to my -fixes queue which depends upon the old behaviour ... I'll make a note to fix this once stuff is merged together again. For reference the patch this will break in -fixes is: commit c3456fb3e4712d0448592af3c5d644c9472cd3c1 Author: Daniel Vetter <daniel.vetter@ffwll.ch> Date: Mon Jun 10 09:47:58 2013 +0200 drm/i915: prefer VBT modes for SVDO-LVDS over EDID Cheers, Daniel > --- > drivers/gpu/drm/drm_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index e7e9242..f072ac6 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -657,7 +657,7 @@ EXPORT_SYMBOL(drm_crtc_cleanup); > void drm_mode_probed_add(struct drm_connector *connector, > struct drm_display_mode *mode) > { > - list_add(&mode->head, &connector->probed_modes); > + list_add_tail(&mode->head, &connector->probed_modes); > } > EXPORT_SYMBOL(drm_mode_probed_add); > > -- > 1.8.1.5 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
On Tue, Jun 11, 2013 at 09:15:29AM +0200, Daniel Vetter wrote: > On Fri, May 31, 2013 at 2:17 PM, <ville.syrjala@linux.intel.com> wrote: > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > Keeping the modes in the same order as we probe them makes it a bit > > easier to track what's happening. > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > I've just added a regression fixer to my -fixes queue which depends > upon the old behaviour ... I'll make a note to fix this once stuff is > merged together again. For reference the patch this will break in > -fixes is: > > commit c3456fb3e4712d0448592af3c5d644c9472cd3c1 > Author: Daniel Vetter <daniel.vetter@ffwll.ch> > Date: Mon Jun 10 09:47:58 2013 +0200 > > drm/i915: prefer VBT modes for SVDO-LVDS over EDID That is not the only place to have a subtle dependence upon the ordering of modes in the list. -Chris
On Tue, Jun 11, 2013 at 08:48:48AM +0100, Chris Wilson wrote: > On Tue, Jun 11, 2013 at 09:15:29AM +0200, Daniel Vetter wrote: > > On Fri, May 31, 2013 at 2:17 PM, <ville.syrjala@linux.intel.com> wrote: > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > > > Keeping the modes in the same order as we probe them makes it a bit > > > easier to track what's happening. > > > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > I've just added a regression fixer to my -fixes queue which depends > > upon the old behaviour ... I'll make a note to fix this once stuff is > > merged together again. For reference the patch this will break in > > -fixes is: > > > > commit c3456fb3e4712d0448592af3c5d644c9472cd3c1 > > Author: Daniel Vetter <daniel.vetter@ffwll.ch> > > Date: Mon Jun 10 09:47:58 2013 +0200 > > > > drm/i915: prefer VBT modes for SVDO-LVDS over EDID > > That is not the only place to have a subtle dependence upon the ordering > of modes in the list. I've now included latest drm-next into drm-intel-nightly. I guess we'll find out soon ;-) -Daniel
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index e7e9242..f072ac6 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -657,7 +657,7 @@ EXPORT_SYMBOL(drm_crtc_cleanup); void drm_mode_probed_add(struct drm_connector *connector, struct drm_display_mode *mode) { - list_add(&mode->head, &connector->probed_modes); + list_add_tail(&mode->head, &connector->probed_modes); } EXPORT_SYMBOL(drm_mode_probed_add);