From patchwork Fri Aug 30 09:10:51 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 2852573 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 57E05C0AB5 for ; Sun, 1 Sep 2013 15:49:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5A56B202C1 for ; Sun, 1 Sep 2013 15:49:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 4393B20295 for ; Sun, 1 Sep 2013 15:49:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2CCC8E5C80 for ; Sun, 1 Sep 2013 08:49:31 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pb0-f43.google.com (mail-pb0-f43.google.com [209.85.160.43]) by gabe.freedesktop.org (Postfix) with ESMTP id BA9ACE64DE for ; Fri, 30 Aug 2013 02:28:28 -0700 (PDT) Received: by mail-pb0-f43.google.com with SMTP id md4so1648094pbc.2 for ; Fri, 30 Aug 2013 02:28:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=wA9hTrKbRiKgQsIFKoULWBFcFTYoK0A2pKoiIP/OhEA=; b=RAthaynaoRdCttO8eHIOaoesypRJpkpTLEzvFnGft8IcyBXAqBHbJYdOULGIHiyKOB 0cdntMyHRojr7Gdh9IYgRw3OUnVj7u7lhHk3GOPX6UVUnJWtkIqr+fzdkkbQhhs2ahQ/ Om7z6Z+ZMGgR6yt1bmnEaftdWVndKBwb0WUk5pQcWV4VFh5e2ko11/OKf3rvWQ0T1cvf CyeBBo4EUWmnLbN1bGGt1GygxWX7//1EdHkSEkWKhyr6q+jiIDqgPv6ulGsfN+JSsATR sATVv9e3I9XQrMcvOaPZz3ZcYTnQSv150mtoR6C4JpML5bQdfjCx3TXRxMi5R98pmjXt 4HpA== X-Gm-Message-State: ALoCoQmImJS4F9wMftVKYlFCV0z+/er1N3qJnkKNaGQmD1Unu6NBRd8pcKWL8j4BqwXCUucO3ARS X-Received: by 10.66.145.166 with SMTP id sv6mr9461512pab.31.1377854908590; Fri, 30 Aug 2013 02:28:28 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id kd1sm46549501pab.20.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 30 Aug 2013 02:28:27 -0700 (PDT) From: Sachin Kamat To: dri-devel@lists.freedesktop.org Subject: [PATCH 1/1] drm/exynos: Fix build error with exynos_drm_connector.c Date: Fri, 30 Aug 2013 14:40:51 +0530 Message-Id: <1377853851-32636-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Mailman-Approved-At: Sun, 01 Sep 2013 08:49:07 -0700 Cc: sachin.kamat@linaro.org, Andrzej Hajda , patches@linaro.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP exynos_drm_connector.c now uses videomode helper API. Hence select VIDEOMODE_HELPERS at DRM_EXYNOS level itself instead of at DRM_EXYNOS_FIMD to avoid the following compilation error when FIMD is not selected (introduced by commit cf796235a6 "drm/exynos: fimd: replace struct fb_videomode with videomode"): drivers/built-in.o: In function `exynos_drm_connector_get_modes': drivers/gpu/drm/exynos/exynos_drm_connector.c:86: undefined reference to `drm_display_mode_from_videomode' Signed-off-by: Sachin Kamat Cc: Andrzej Hajda --- drivers/gpu/drm/exynos/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index 80a251a..4752f22 100644 --- a/drivers/gpu/drm/exynos/Kconfig +++ b/drivers/gpu/drm/exynos/Kconfig @@ -6,6 +6,7 @@ config DRM_EXYNOS select FB_CFB_COPYAREA select FB_CFB_IMAGEBLIT select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE + select VIDEOMODE_HELPERS help Choose this option if you have a Samsung SoC EXYNOS chipset. If M is selected the module will be called exynosdrm. @@ -26,7 +27,6 @@ config DRM_EXYNOS_FIMD bool "Exynos DRM FIMD" depends on DRM_EXYNOS && !FB_S3C && !ARCH_MULTIPLATFORM select FB_MODE_HELPERS - select VIDEOMODE_HELPERS help Choose this option if you want to use Exynos FIMD for DRM.