From patchwork Thu Sep 19 16:21:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Emil Velikov X-Patchwork-Id: 2926471 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D8039BFF05 for ; Mon, 23 Sep 2013 08:25:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A4B892053D for ; Mon, 23 Sep 2013 08:25:51 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id CEC5920127 for ; Mon, 23 Sep 2013 08:25:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC2ACE70CA for ; Mon, 23 Sep 2013 01:25:49 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ea0-f175.google.com (mail-ea0-f175.google.com [209.85.215.175]) by gabe.freedesktop.org (Postfix) with ESMTP id 86DB2E7555 for ; Thu, 19 Sep 2013 09:21:55 -0700 (PDT) Received: by mail-ea0-f175.google.com with SMTP id m14so4252202eaj.20 for ; Thu, 19 Sep 2013 09:21:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=meHEfPorYXtP3uCBcKzy0sFPeyOOqArw+2/lZDxOtXY=; b=qGXT0GjKAWEoCUdAULzFHMlkimbhnU0EGM5gd214jpNlYSa6cd+p80pgOevjUcy2Io EQP8MO5Pk6uCALrbmBKKooaK/edoX2eMLax5a5zHVBgU4t1RCU15vwYKqeHq+3aETsIe QFLV2A3uubG0H/DLiUM8Pq4zX7Z8DBFM40eI3UNIqUSD33OKYNQNWrtBIZxnLt4uAFY3 P7cBLTuh/kjLPGANKMJVU7NUaPJD2+OCKaEV1/J744slqHPYNvmX7t2+UnNRt1K2bhlZ xHG88gqNeGxoM+hSHWhVclIcl75ytfNZ/MNqfv12ZjwiBy8nqabqyZo1K+M1H+UvSRAG Qhjg== X-Received: by 10.14.38.14 with SMTP id z14mr3102303eea.89.1379607714619; Thu, 19 Sep 2013 09:21:54 -0700 (PDT) Received: from localhost.localdomain (cpc20-stap10-2-0-cust563.12-2.cable.virginmedia.com. [82.20.130.52]) by mx.google.com with ESMTPSA id d8sm12498336eeh.8.1969.12.31.16.00.00 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 19 Sep 2013 09:21:53 -0700 (PDT) From: Emil Velikov To: dri-devel@lists.freedesktop.org Subject: [PATCH] configure: add AC_LANG_SOURCE call within AC_COMPILE_IFELSE Date: Thu, 19 Sep 2013 17:21:01 +0100 Message-Id: <1379607661-20494-1-git-send-email-emil.l.velikov@gmail.com> X-Mailer: git-send-email 1.8.4 X-Mailman-Approved-At: Mon, 23 Sep 2013 01:17:00 -0700 Cc: emil.l.velikov@gmail.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Documentation states that AC_*_IFELSE has to use AC_LANG_SOURCE or friends in order to generate the source code to compile. AC_LINK_IFELSE already handles this, thus convert AC_COMPILE_IFELSE to silence the final autoconf warnings. Signed-off-by: Emil Velikov Reviewed-by: Daniel Kurtz --- While this patch is not strictly speaking necessary for the full/correct build of libdrm, it cuts down the configure'n'compile warnings to five. With the remaining being caused due to type conversion within exynos(4) and freedreno/kgsl(1). I planning to leave those to someone more aware of the respective codebase :) Cheers, Emil P.S. Keep me CC'd as I'm not subscribed to the list --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index d2e232b..43e6954 100644 --- a/configure.ac +++ b/configure.ac @@ -111,7 +111,7 @@ AC_DEFUN([LIBDRM_CC_TRY_FLAG], [ libdrm_save_CFLAGS="$CFLAGS" CFLAGS="$CFLAGS $1" - AC_COMPILE_IFELSE([ ], [libdrm_cc_flag=yes], [libdrm_cc_flag=no]) + AC_COMPILE_IFELSE([AC_LANG_SOURCE([ ])], [libdrm_cc_flag=yes], [libdrm_cc_flag=no]) CFLAGS="$libdrm_save_CFLAGS" if test "x$libdrm_cc_flag" = "xyes"; then