From patchwork Mon Oct 7 08:34:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 2995201 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 81B8BBF924 for ; Mon, 7 Oct 2013 09:05:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 43079201BF for ; Mon, 7 Oct 2013 09:05:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id AFFEA200E9 for ; Mon, 7 Oct 2013 09:05:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AB73CE713C for ; Mon, 7 Oct 2013 02:05:51 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by gabe.freedesktop.org (Postfix) with ESMTP id E7B46E5FB1 for ; Mon, 7 Oct 2013 01:37:24 -0700 (PDT) Received: by mail-bk0-f54.google.com with SMTP id mz12so2470463bkb.41 for ; Mon, 07 Oct 2013 01:37:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=X9ZldG2DrAG5L0tYX8MsHMJiS/awBvygakQRvnlI6MI=; b=Fw9GbfmwqOXG1tJ/XHRaCKyREX/4Wo7r5AXgkszd9p/yi5UCuqR3onHfyFVodXwn/O OUNXAhh5Bsd1kqUC5ANyoKiy3JQYx6XdLTlm9l5Nc0KfakLsaDQaisuxgR5RzeCktg82 YvobOffVJyzuzlGM2au6ZeyP38So9zMT4QD1jxyCs8bjHJqbe/iSJeF1WGgT1lvCR/EL mJrZWb2qCQZxGdlKNZxP0v0aGlY9dbUg0WCBEprO1UmOq5A/fQlBwW1F3wS4ul61/w9z vR6UPtFol9m0rQ2JlY65NYfiC2BzCxPUyL7EKB2NUhjuNtpi5RkN3KGO6AffozipkJ97 Aq8w== X-Received: by 10.204.55.137 with SMTP id u9mr998964bkg.28.1381135044077; Mon, 07 Oct 2013 01:37:24 -0700 (PDT) Received: from localhost (port-46445.pppoe.wtnet.de. [46.59.230.36]) by mx.google.com with ESMTPSA id ny10sm16317116bkb.17.1969.12.31.16.00.00 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 07 Oct 2013 01:37:23 -0700 (PDT) From: Thierry Reding To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 24/27] drm/tegra: Start connectors with correct DPMS mode Date: Mon, 7 Oct 2013 10:34:41 +0200 Message-Id: <1381134884-5816-25-git-send-email-treding@nvidia.com> X-Mailer: git-send-email 1.8.4 In-Reply-To: <1381134884-5816-1-git-send-email-treding@nvidia.com> References: <1381134884-5816-1-git-send-email-treding@nvidia.com> Cc: linux-tegra@vger.kernel.org, devicetree@vger.kernel.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A connector's DPMS mode isn't initialized by default, therefore using a default of 0 (DRM_MODE_DPMS_ON). This can cause problems in that the DRM core won't explicitly turn on a connector because it thinks that it is already on. Signed-off-by: Thierry Reding --- Note that it would probably make sense to do this in the core, but after some discussion on IRC it became clear that other drivers (specifically i915) use similar workarounds and moving this to the core may cause them to regress. drivers/gpu/drm/tegra/output.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c index be6ef34..d911fe8 100644 --- a/drivers/gpu/drm/tegra/output.c +++ b/drivers/gpu/drm/tegra/output.c @@ -264,6 +264,7 @@ int tegra_output_init(struct drm_device *drm, struct tegra_output *output) drm_connector_init(drm, &output->connector, &connector_funcs, connector); drm_connector_helper_add(&output->connector, &connector_helper_funcs); + output->connector.dpms = DRM_MODE_DPMS_OFF; if (output->panel) drm_panel_attach(output->panel, &output->connector);