From patchwork Tue Oct 29 16:13:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 3109191 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B4DBCBF924 for ; Tue, 29 Oct 2013 16:18:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 942E72035D for ; Tue, 29 Oct 2013 16:18:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 4526B200F4 for ; Tue, 29 Oct 2013 16:18:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 273A5EED97 for ; Tue, 29 Oct 2013 09:17:23 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qc0-f180.google.com (mail-qc0-f180.google.com [209.85.216.180]) by gabe.freedesktop.org (Postfix) with ESMTP id B45A4EEBD4 for ; Tue, 29 Oct 2013 09:14:04 -0700 (PDT) Received: by mail-qc0-f180.google.com with SMTP id e9so43454qcy.25 for ; Tue, 29 Oct 2013 09:14:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=bNbuSZj5sjDe4eiwln89CfdpokNznWjU9wEW1shOCc8=; b=PnF8LqAf9qVBddTzYcSunYMIhXKpH/XA6aXjKqxXuIO+atHcnpYdKnHb/nRibof/Ov Ru1GBGK2DrNKcaFZKIa01oEA23UIsT/TIv6SnhNkx44imYAN786bxKuBpiWvYieDHUYp qkPK2gaIu+DlrxN3XtaOFUtvo1y1H5RLaEi9A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=bNbuSZj5sjDe4eiwln89CfdpokNznWjU9wEW1shOCc8=; b=C1z6pngzZ4LlgiBNS4lcSywQ+tFWthiTvSVjXhwkOKb2DL2sRjb/h0Y6YYKo5O5OAx Sp/+cUgutZZrGHj7BSHaDLylQckG6X52b1p7SicSr6UOvUPBORQEr6/c6nmrVh/V8YaU In/LYtu517bIFPM3nCyuIANYboPlE2RCuATaTxYMwjSOlfbGEBlpvxPY7qJv2S04nhvi +g1LV7Xd/InKL+Ts4JtBeuXk7guf2vFQD9vviYFVnZKhOTgl6pWK3TYyE9oQhdHH4ER6 KW6yCPSzFdd8V2CPEK7P8pggogM07e5m249xmgKmoAfTDJi2vSrZZwUNs4v23lpbTp6M xR7g== X-Gm-Message-State: ALoCoQnJHDzq22fZCX+YHqGH1rxwEi8at5G5Q5tDZrgSW+pf8+R7WKtIl77VKpGou3tS7iqBsGAr X-Received: by 10.49.127.195 with SMTP id ni3mr473939qeb.21.1383063244273; Tue, 29 Oct 2013 09:14:04 -0700 (PDT) Received: from seanpaul-glaptop.roam.corp.google.com (cpe-173-095-180-236.nc.res.rr.com. [173.95.180.236]) by mx.google.com with ESMTPSA id h9sm66581946qaq.9.2013.10.29.09.14.03 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 29 Oct 2013 09:14:03 -0700 (PDT) From: Sean Paul To: dri-devel@lists.freedesktop.org, inki.dae@samsung.com Subject: [PATCH v3 20/32] drm/exynos: Remove unused/useless fimd_context members Date: Tue, 29 Oct 2013 12:13:06 -0400 Message-Id: <1383063198-10526-21-git-send-email-seanpaul@chromium.org> X-Mailer: git-send-email 1.8.4 In-Reply-To: <1383063198-10526-1-git-send-email-seanpaul@chromium.org> References: <1383063198-10526-1-git-send-email-seanpaul@chromium.org> Cc: marcheu@chromium.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org Errors-To: dri-devel-bounces+patchwork-dri-devel=patchwork.kernel.org@lists.freedesktop.org X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch removes a few fimd_context members which are either entirely unused or unneeded. Signed-off-by: Sean Paul Reviewed-by: Tomasz Figa --- Changes in v2: None Changes in v3: None drivers/gpu/drm/exynos/exynos_drm_fimd.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index f69d6e5..61124ca 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -121,8 +121,6 @@ struct fimd_mode_data { struct fimd_context { struct device *dev; struct drm_device *drm_dev; - int irq; - struct drm_crtc *crtc; struct clk *bus_clk; struct clk *lcd_clk; void __iomem *regs; @@ -134,7 +132,6 @@ struct fimd_context { u32 vidcon1; bool suspended; int pipe; - struct mutex lock; wait_queue_head_t wait_vsync_queue; atomic_t wait_vsync_event; @@ -547,8 +544,6 @@ static void fimd_dpms(struct exynos_drm_manager *mgr, int mode) DRM_DEBUG_KMS("%d\n", mode); - mutex_lock(&ctx->lock); - switch (mode) { case DRM_MODE_DPMS_ON: /* @@ -570,8 +565,6 @@ static void fimd_dpms(struct exynos_drm_manager *mgr, int mode) DRM_DEBUG_KMS("unspecified mode %d\n", mode); break; } - - mutex_unlock(&ctx->lock); } static u32 fimd_calc_clkdiv(struct fimd_context *ctx, @@ -964,9 +957,7 @@ static int fimd_probe(struct platform_device *pdev) return -ENXIO; } - ctx->irq = res->start; - - ret = devm_request_irq(dev, ctx->irq, fimd_irq_handler, + ret = devm_request_irq(dev, res->start, fimd_irq_handler, 0, "drm_fimd", ctx); if (ret) { dev_err(dev, "irq request failed.\n"); @@ -977,8 +968,6 @@ static int fimd_probe(struct platform_device *pdev) DRM_INIT_WAITQUEUE(&ctx->wait_vsync_queue); atomic_set(&ctx->wait_vsync_event, 0); - mutex_init(&ctx->lock); - platform_set_drvdata(pdev, &fimd_manager); fimd_manager.ctx = ctx;