From patchwork Wed Dec 11 10:34:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 3323741 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2CDD9C0D4A for ; Wed, 11 Dec 2013 10:34:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1A5AA20720 for ; Wed, 11 Dec 2013 10:34:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id C3FAA20726 for ; Wed, 11 Dec 2013 10:34:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D7DEBFA900; Wed, 11 Dec 2013 02:34:32 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ea0-f178.google.com (mail-ea0-f178.google.com [209.85.215.178]) by gabe.freedesktop.org (Postfix) with ESMTP id 271E2FA900 for ; Wed, 11 Dec 2013 02:34:31 -0800 (PST) Received: by mail-ea0-f178.google.com with SMTP id d10so2782332eaj.23 for ; Wed, 11 Dec 2013 02:34:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FAWUsI+3C6rvIvK6X0vYg3CwGLizNwcLhmiaNlMqCC8=; b=ZQmHL/ZMQ9AQg+HHykXxCZMUed8dS2r+uw98wftYvjG7rRxqqj/+sSLNHWL1hleP4a dw5JcXaNXyq6DIf1HZOAtfY5F8taoADZmkEqc4vAYJWpzyo0LAB5DX6J03ibd09Y5l3S S8/zhMsL/J4Y6Qu9x9F7u7n4moySa007pijJw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FAWUsI+3C6rvIvK6X0vYg3CwGLizNwcLhmiaNlMqCC8=; b=HdeYyvsRPh83/cvvEwLGn8eu6yq0YXL1YoYre7k36KJOYo60ugRgawoqiB8PyPqpdC 7pj6VdLSr8Nq08BXJTHFfcvnR76qomnhpOzSBkcJ5ZMJDSATZJT5FwExc8xOhu4UZ1en w0Zj2iOBvGR2jqa8ghNdfhRmj7Pj+oQhuVpBKIK0+mo9WEZv5DjkKh5zHEMKfnWjuCY6 ahj334d8IbqWlXBLsXjE1kfp/mUCB1iAMgbYLiZWH3T1gH88Ch/7p6AWFJHRiH30LBjQ N3qIatIzH/jkjBLNL1vxWdz/st3E6vMGpFRE5VEvxjvFWa4wzYdqAUlnZtKtec5GMjIz FG7g== X-Gm-Message-State: ALoCoQmHmp8kD+zc0dO+YXJm9ctjIQIbGzjF7uy+5bc+v1lQppGgqW+WPqmk3Xpu1VImR24a7V59 X-Received: by 10.14.93.197 with SMTP id l45mr877475eef.53.1386758070537; Wed, 11 Dec 2013 02:34:30 -0800 (PST) Received: from phenom.ffwll.local (178-83-130-250.dynamic.hispeed.ch. [178.83.130.250]) by mx.google.com with ESMTPSA id b41sm51932269eef.16.2013.12.11.02.34.29 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Dec 2013 02:34:29 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 01/50] drm/rcar: call drm_put_dev directly in the ->remove hook Date: Wed, 11 Dec 2013 11:34:22 +0100 Message-Id: <1386758111-3446-2-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 1.8.4.3 In-Reply-To: <1386758111-3446-1-git-send-email-daniel.vetter@ffwll.ch> References: <1386758111-3446-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Laurent Pinchart X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The magic dance drm_platform_exit does is actually a remnant of the old legacy shadow attach support for platform devices. Modern modesetting drm drivers shouldn't do this any more (and usb/pci devices actually don't do this). Cc: Laurent Pinchart Acked-by: Laurent Pinchart Signed-off-by: Daniel Vetter --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 0023f9719cf1..4ec6272a1c11 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c @@ -224,7 +224,9 @@ static int rcar_du_probe(struct platform_device *pdev) static int rcar_du_remove(struct platform_device *pdev) { - drm_platform_exit(&rcar_du_driver, pdev); + struct rcar_du_device *rcdu = platform_get_drvdata(pdev); + + drm_put_dev(rcdu->ddev); return 0; }