From patchwork Sun Jan 5 18:22:51 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guenter Roeck X-Patchwork-Id: 3435141 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 841D29F163 for ; Mon, 6 Jan 2014 00:05:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AAAD320163 for ; Mon, 6 Jan 2014 00:05:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id A83BA2015F for ; Mon, 6 Jan 2014 00:05:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E0B91FD787; Sun, 5 Jan 2014 16:05:28 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by gabe.freedesktop.org (Postfix) with ESMTP id 1490EFD394 for ; Sun, 5 Jan 2014 10:23:31 -0800 (PST) Received: by mail-pb0-f50.google.com with SMTP id rr13so17630809pbb.37 for ; Sun, 05 Jan 2014 10:23:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=N3hXaJGL/REN/kYM5vERqo1S1ugwghYE0YGwLUwK/nE=; b=aomkb2eK8YWua9E3ep/bsfsCWewJ12rG3nVePFiX+FmH4C1pQvqRiw5ASvb4kKYKhM 0oxmKeRkKjA09pYbyl7GKDdCbAPhiLEXwo4hP5kwNiw4e/ht9eP3feBCjPj9jV9GJYlX OA86WQRNNBWhmr+BrQcDULpaWQJ96iRy0SPDZtJ4xzLeV2ziyBPp6LPfEDX5oz09qYMM jSQiROihZ/7EjQCDoIREH2pOeqnGtV6pg8FHTmW5dJUi0vPKizDKITo/ye5SWhDUTW6O CdLKhGtKKoF36njKQfT8fVJPTr7cIYByfJxmuLWT07Qf8AgJ9B5U4gyf0OP8cZC1SCAo /PRQ== X-Received: by 10.69.8.225 with SMTP id dn1mr27770731pbd.54.1388946210852; Sun, 05 Jan 2014 10:23:30 -0800 (PST) Received: from localhost (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by mx.google.com with ESMTPSA id nw11sm161618309pab.13.2014.01.05.10.23.29 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 05 Jan 2014 10:23:30 -0800 (PST) From: Guenter Roeck To: Thierry Reding , =?UTF-8?q?Terje=20Bergstr=C3=B6m?= Subject: [PATCH] drm/tegra: Fix Kconfig dependencies Date: Sun, 5 Jan 2014 10:22:51 -0800 Message-Id: <1388946171-29459-1-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 1.7.9.7 X-Mailman-Approved-At: Sun, 05 Jan 2014 16:05:26 -0800 Cc: linux-tegra@vger.kernel.org, Guenter Roeck , dri-devel@lists.freedesktop.org, Stephen Warren X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP arm:allmodconfig fails to build with several undefined drm and host1x symbols. drivers/gpu/drm/tegra/bus.c:52: undefined reference to `drm_dev_alloc' drivers/gpu/drm/tegra/bus.c:56: undefined reference to `drm_dev_register' drivers/gpu/drm/tegra/bus.c:67: undefined reference to `drm_dev_free' drivers/gpu/drm/tegra/bus.c:75: undefined reference to `drm_put_dev' drivers/gpu/drm/tegra/drm.c:445: undefined reference to `host1x_syncpt_get_base' drivers/gpu/drm/tegra/drm.c:449: undefined reference to `host1x_syncpt_base_id' and so on. This is caused by DRM=m but DRM_TEGRA=y. DRM_TEGRA is bool while DRM is tristate. DRM_TEGRA can not be set to tristate because it depends on unexported host1x symbols (and possibly others). Fix by updating DRM_TEGRA dependency. Also, the DRM_TEGRA help text states that it can be built as module. Remove that text since it is not (or no longer) correct. Signed-off-by: Guenter Roeck Acked-by: Thierry Reding --- drivers/gpu/drm/tegra/Kconfig | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig index 8961ba6..9966547 100644 --- a/drivers/gpu/drm/tegra/Kconfig +++ b/drivers/gpu/drm/tegra/Kconfig @@ -1,7 +1,7 @@ config DRM_TEGRA bool "NVIDIA Tegra DRM" depends on ARCH_TEGRA || ARCH_MULTIPLATFORM - depends on DRM + depends on DRM=y select TEGRA_HOST1X select DRM_KMS_HELPER select DRM_KMS_FB_HELPER @@ -11,9 +11,6 @@ config DRM_TEGRA help Choose this option if you have an NVIDIA Tegra SoC. - To compile this driver as a module, choose M here: the module - will be called tegra-drm. - if DRM_TEGRA config DRM_TEGRA_DEBUG