From patchwork Thu Jan 16 06:01:26 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 3501181 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 6A6D3C02DC for ; Fri, 17 Jan 2014 00:02:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A01A42015E for ; Fri, 17 Jan 2014 00:02:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id C2E892015D for ; Fri, 17 Jan 2014 00:02:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5806F106272; Thu, 16 Jan 2014 16:02:43 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by gabe.freedesktop.org (Postfix) with ESMTP id A11484A06 for ; Wed, 15 Jan 2014 22:05:56 -0800 (PST) Received: by mail-pb0-f54.google.com with SMTP id un15so2208108pbc.13 for ; Wed, 15 Jan 2014 22:05:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4TcedTptL8lTdF0eUmcof4rPRda8AjW4Mn6HmsVIHOA=; b=Ba+UMCSsDNS6yMZILPn8AZFLNUd7WNheuBjbOnO5jN0DrjZwVdQErdTQu+nnu/wsq6 T3Hmbf7dEfJ/xAG2KOLeedAul8wQ/fnDSpBxk4RlrgUWqu/kW1zm2ySkYJSQ5O575GPQ 9qaBZezyDdxrCUfBPkVrtcYrLFgVQS5JosMkL++oc717sIC4fzXzqYo1+Ur3QGZlmE/a +3hIDCs9r/hXRto/Bs8DVlsjckH/COtO0P5KMrihWRygzdMphEEIUhIFRnt8mWuF0pxA n9mLrNAuo9sf9ifRb5wC0A0E2A3C8Go/xpECiRN4Vy5GRrk5rcknBCM9TI0CSRMJVGPT iiPA== X-Gm-Message-State: ALoCoQlD2P6JRAw38XDp0sJ7bKRii9jrsNUdyG1AFHT/OXpoKltfeeNqENzOkQQXZAwGMkQ+lvsw X-Received: by 10.66.49.74 with SMTP id s10mr7927823pan.0.1389852356534; Wed, 15 Jan 2014 22:05:56 -0800 (PST) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPSA id e6sm12369296pbg.4.2014.01.15.22.05.45 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 15 Jan 2014 22:05:55 -0800 (PST) From: Sachin Kamat To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 1/1] drm/exynos: Fix freeing issues in exynos_drm_drv.c Date: Thu, 16 Jan 2014 11:31:26 +0530 Message-Id: <1389852086-11801-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Mailman-Approved-At: Thu, 16 Jan 2014 16:02:05 -0800 Cc: sachin.kamat@linaro.org, patches@linaro.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fixes the following errors: drivers/gpu/drm/exynos/exynos_drm_drv.c:182 exynos_drm_open() error: double free of 'file_priv' drivers/gpu/drm/exynos/exynos_drm_drv.c:188 exynos_drm_open() error: dereferencing freed memory 'file_priv' Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index 9d096a0..215131a 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c @@ -171,22 +171,24 @@ static int exynos_drm_open(struct drm_device *dev, struct drm_file *file) file->driver_priv = file_priv; ret = exynos_drm_subdrv_open(dev, file); - if (ret) { - kfree(file_priv); - file->driver_priv = NULL; - } + if (ret) + goto out; anon_filp = anon_inode_getfile("exynos_gem", &exynos_drm_gem_fops, NULL, 0); if (IS_ERR(anon_filp)) { - kfree(file_priv); - return PTR_ERR(anon_filp); + ret = PTR_ERR(anon_filp); + goto out; } anon_filp->f_mode = FMODE_READ | FMODE_WRITE; file_priv->anon_filp = anon_filp; return ret; +out: + kfree(file_priv); + file->driver_priv = NULL; + return ret; } static void exynos_drm_preclose(struct drm_device *dev,