From patchwork Mon Feb 10 18:34:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 3621881 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 5B1109F2D6 for ; Mon, 10 Feb 2014 18:34:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A14B6201D5 for ; Mon, 10 Feb 2014 18:34:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id F2F58201B6 for ; Mon, 10 Feb 2014 18:34:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AECB2105815; Mon, 10 Feb 2014 10:34:55 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qc0-f171.google.com (mail-qc0-f171.google.com [209.85.216.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 44C0E105819 for ; Mon, 10 Feb 2014 10:34:45 -0800 (PST) Received: by mail-qc0-f171.google.com with SMTP id n7so11185941qcx.2 for ; Mon, 10 Feb 2014 10:34:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ALTVNkbDa5t1NG8Fb0Fg29eHEm1MhsTwM9dUPgCtuvI=; b=jH49fsEjZNewNwwsaSxKKQ/JQHYUkEH+akxipr+gMw2dZXIHbhmM7SlMNGqxZEUorP XcHQyG+DtKg0KsbbO1OxPmUTvPL8de/gbwmk8lnp6M2QdJVP/+SkrdLzVeicUMpKVWFS pHIOtjcIdTSeheUITzSjhRhbZ9fks0pDaQls6i3EDyfqE8lNO/sGKjPiWw2m3nectQvg k2WBxcX8SUFJ49PZWrt9LBEsAotdWMr9WTDt/tWkqgEwIdt7wGkKS3fSBIducWW7zoXq /8NEzPtoHYjc30OaCGN8SdAPypmSmC4ylJw9ClBqnfMHPjv+GXACWxRw25XpmtlR2cH8 PHDA== X-Received: by 10.224.60.131 with SMTP id p3mr50510780qah.27.1392057284806; Mon, 10 Feb 2014 10:34:44 -0800 (PST) Received: from localhost (pool-108-20-254-237.bstnma.east.verizon.net. [108.20.254.237]) by mx.google.com with ESMTPSA id v3sm45097932qap.4.2014.02.10.10.34.43 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 10 Feb 2014 10:34:44 -0800 (PST) From: Rob Clark To: dri-devel@lists.freedesktop.org Subject: [PATCHv2 3/4] st/xa: missing handle type Date: Mon, 10 Feb 2014 13:34:20 -0500 Message-Id: <1392057261-25942-4-git-send-email-robdclark@gmail.com> X-Mailer: git-send-email 1.8.5.3 In-Reply-To: <1392057261-25942-1-git-send-email-robdclark@gmail.com> References: <1392057261-25942-1-git-send-email-robdclark@gmail.com> Cc: Emil Velikov , Rob Clark X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Rob Clark DRM_API_HANDLE_TYPE_SHARED is zero, so doesn't actually fix anything. But we shouldn't rely on SHARED handle type being zero. Signed-off-by: Rob Clark --- src/gallium/state_trackers/xa/xa_tracker.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/xa/xa_tracker.c b/src/gallium/state_trackers/xa/xa_tracker.c index 6943a29..01db945 100644 --- a/src/gallium/state_trackers/xa/xa_tracker.c +++ b/src/gallium/state_trackers/xa/xa_tracker.c @@ -370,6 +370,7 @@ xa_surface_from_handle(struct xa_tracker *xa, { struct winsys_handle whandle; memset(&whandle, 0, sizeof(whandle)); + whandle.type = DRM_API_HANDLE_TYPE_SHARED; whandle.handle = handle; whandle.stride = stride; return surface_create(xa, width, height, depth, stype, xa_format, flags, &whandle);