From patchwork Mon Mar 3 13:30:11 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inki Dae X-Patchwork-Id: 3754131 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 99D9E9F38E for ; Mon, 3 Mar 2014 13:30:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9C6C0203B6 for ; Mon, 3 Mar 2014 13:30:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 1BC78202F8 for ; Mon, 3 Mar 2014 13:30:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 754A8FB242; Mon, 3 Mar 2014 05:30:20 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTP id AE577FB244 for ; Mon, 3 Mar 2014 05:30:18 -0800 (PST) Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N1V00DT746FD860@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Mon, 03 Mar 2014 22:30:15 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.112]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 1E.51.10364.7E384135; Mon, 03 Mar 2014 22:30:15 +0900 (KST) X-AuditID: cbfee690-b7f266d00000287c-44-531483e7d9ee Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 21.15.28157.7E384135; Mon, 03 Mar 2014 22:30:15 +0900 (KST) Received: from daeinki-desktop.10.32.193.11 ([10.252.75.62]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N1V002RJ46EWY80@mmp1.samsung.com>; Mon, 03 Mar 2014 22:30:15 +0900 (KST) From: Inki Dae To: airlied@linux.ie, dri-devel@lists.freedesktop.org Subject: [RFC PATCH 1/3] drm/exynos: fix unnecessary resource cleanup Date: Mon, 03 Mar 2014 22:30:11 +0900 Message-id: <1393853413-22641-2-git-send-email-inki.dae@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1393853413-22641-1-git-send-email-inki.dae@samsung.com> References: <1393853413-22641-1-git-send-email-inki.dae@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRmVeSWpSXmKPExsWyRsSkQPd5s0iwwc9Hgha31p1jteg9d5LJ 4srX92wWk+5PYLE42/SG3eLuhrOMFvPaX7I6sHvMbrjI4rH92wNWj/vdx5k8+rasYgxgieKy SUnNySxLLdK3S+DKuLBtB0vBZI6Kuf/PszcwfmfrYuTkkBAwkTi8ZAUThC0mceHeeqA4F4eQ wFJGiXNfd7DCFK2fMJUZxBYSWMQoceeBGoTdzSTR8cUAxGYTUJWYuOI+2FARAVOJjklLWUAG MQtMY5SY3NbJ2MXIwSEs4CpxqEEWpIYFqH7a9IcsIDavgIvEtUfNbCAlEgIKEnMm2YCEOYGq Nxx6ww4SFgIqObFPDuKayewSJ57LQEwRkPg2+RALRKesxKYDzBAlkhIHV9xgmcAovICRYRWj aGpBckFxUnqRiV5xYm5xaV66XnJ+7iZGYFif/vdswg7GewesDzEmA42byCwlmpwPjIu8knhD YzMjC1MTU2Mjc0sz0oSVxHnVHiUFCQmkJ5akZqemFqQWxReV5qQWH2Jk4uCUamCcK1Swd2dg 2Vqpusl/0k/ceX7w5L+EY2vObcifUKPHVVX8PPBz9ck4a5tT4uxnvPbHbUhSXcdrGp76trj/ 77F7avXWsrfFOu7es7M7U/yaNyG1O+HSfq0N2z+8KQxl/7pFP9EgfetKYRNLxW839wY9Npfr 2pp+uVPxyaHvZv77T6RNfLbLRCRLiaU4I9FQi7moOBEAupa8PYECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDIsWRmVeSWpSXmKPExsVy+t9jAd3nzSLBBjN7uSxurTvHatF77iST xZWv79ksJt2fwGJxtukNu8XdDWcZLea1v2R1YPeY3XCRxWP7twesHve7jzN59G1ZxRjAEtXA aJORmpiSWqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDdIOSQlli TilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCGMePCth0sBZM5Kub+P8/ewPidrYuR k0NCwERi/YSpzBC2mMSFe+vB4kICixgl7jxQg7C7mSQ6vhiA2GwCqhITV9wHqxERMJXomLSU pYuRi4NZYBqjxOS2TsYuRg4OYQFXiUMNsiA1LED106Y/ZAGxeQVcJK49amYDKZEQUJCYM8kG JMwJVL3h0Bt2kLAQUMmJfXITGHkXMDKsYhRNLUguKE5KzzXSK07MLS7NS9dLzs/dxAiOm2fS OxhXNVgcYhTgYFTi4TVYKhwsxJpYVlyZe4hRgoNZSYQ3okYkWIg3JbGyKrUoP76oNCe1+BBj MtBNE5mlRJPzgTGdVxJvaGxiZmRpZG5oYWRsTpqwkjjvwVbrQCGB9MSS1OzU1ILUIpgtTByc Ug2MYhe/r8vlj6x0zust7QtQzy+P3XC0K27RxNOq/SunGQQVBc16HG8Z+m1jiGIQ9/LWvYmu +s0f2rtZVwpbH50wqeMZ78yTBfOu1i1Tr7m2a8//s10z0jr9u9c891X5/IFTvHKfuucU2Tij kDO/q62/c2ZwXJfe3ZbodPF2z72jU7tq7MOfKz1WYinOSDTUYi4qTgQAM9rSZt8CAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: t.stanislaws@samsung.com, a.hajda@samsung.com, Kyungmin Park X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch removes unnecessary drm_mode_config_cleanup call. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index cba25b1..de010b1 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c @@ -66,7 +66,7 @@ static int exynos_drm_load(struct drm_device *dev, unsigned long flags) ret = drm_create_iommu_mapping(dev); if (ret < 0) { DRM_ERROR("failed to create iommu mapping.\n"); - goto err_crtc; + goto err_free_private; } drm_mode_config_init(dev); @@ -124,8 +124,7 @@ err_manager_cleanup: err_mode_config_cleanup: drm_mode_config_cleanup(dev); drm_release_iommu_mapping(dev); -err_crtc: - drm_mode_config_cleanup(dev); +err_free_private: kfree(private); return ret;