From patchwork Mon Mar 17 13:16:12 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 3843611 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 8AC4C9F334 for ; Mon, 17 Mar 2014 13:16:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BDC52201FB for ; Mon, 17 Mar 2014 13:16:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id D5D422015E for ; Mon, 17 Mar 2014 13:16:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7FA9A8ABD7; Mon, 17 Mar 2014 06:16:55 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by gabe.freedesktop.org (Postfix) with ESMTP id 1EEB28ABD7 for ; Mon, 17 Mar 2014 06:16:54 -0700 (PDT) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N2L00MWT0W44Y70@mailout1.w1.samsung.com> for dri-devel@lists.freedesktop.org; Mon, 17 Mar 2014 13:16:52 +0000 (GMT) X-AuditID: cbfec7f5-b7fc96d000004885-d4-5326f5c46dfa Received: from eusync4.samsung.com ( [203.254.199.214]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 82.32.18565.4C5F6235; Mon, 17 Mar 2014 13:16:52 +0000 (GMT) Received: from AMDC1061.digital.local ([106.116.147.88]) by eusync4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N2L007B90VZ5Z40@eusync4.samsung.com>; Mon, 17 Mar 2014 13:16:52 +0000 (GMT) From: Andrzej Hajda To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 9/9] drm/exynos/fimd: remove unused variable Date: Mon, 17 Mar 2014 14:16:12 +0100 Message-id: <1395062172-19756-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.8.3.2 In-reply-to: <1395052045-23848-10-git-send-email-a.hajda@samsung.com> References: <1395052045-23848-10-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBLMWRmVeSWpSXmKPExsVy+t/xa7pHvqoFG9yYwGVxa905Vot5qyYy W8w/AmRd+fqezaL/zUJWiwN/djBanHu1ktFi0v0JLBZnm96wW8w4v4/JYu2Ru+wWS69fZLKY MH0ti0Xr3iPsFnc3nGV04PdYM28No8fshossHpf7epk8Zix5weixcvkXNo9NqzrZPO5c28Pm cb/7OJNH35ZVjB6fN8kFcEVx2aSk5mSWpRbp2yVwZbTOWcBS8J634tSmHawNjDO5uxg5OSQE TCS+P/zIBGGLSVy4t56ti5GLQ0hgKaPEx9v9zBBOH5PEu1uTwKrYBDQl/m6+yQZiiwgoS/yd uIoRpIhZYCKLxIy118ESwgL2Eg3vl4LZLAKqEr+WbWMGsXkFnCW+ve9ng1inILHsy1qwOKeA q8S30w/BbCEBF4mpfx6zTWDkXcDIsIpRNLU0uaA4KT3XSK84Mbe4NC9dLzk/dxMjJLS/7mBc eszqEKMAB6MSD+8EZbVgIdbEsuLK3EOMEhzMSiK8Tu+AQrwpiZVVqUX58UWlOanFhxiZODil GhhzDh68WrzroGYB952gtTOE9216k2l45b9enQPvhxyzqMa03dfCw9hCpndyh+8QXZax/sG5 j5L1BsvWJ0/+yM7je/Ll6YeKXlqdIco9alLhq0S/FX/iW+WY7q/P07Vc4//cRaIlX0+utQ5+ 94znj2vcNzONbaGpfg732z20b9wrqrFh2Cuy8bgSS3FGoqEWc1FxIgCE/P8ySwIAAA== Cc: Mark Rutland , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Pawel Moll , Ian Campbell , Andrzej Hajda , Kyungmin Park , Rob Herring , Kumar Gala , Grant Likely , Denis Carikli , Marek Szyprowski X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The patch removes unused vidcon0 field from fimd_context structure. Signed-off-by: Andrzej Hajda --- v2: - corrected vidcon0 calculation --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index dbfad4e..158d53a 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -114,7 +114,6 @@ struct fimd_context { struct fimd_win_data win_data[WINDOWS_NR]; unsigned int default_win; unsigned long irq_flags; - u32 vidcon0; bool suspended; int pipe; wait_queue_head_t wait_vsync_queue; @@ -269,26 +268,19 @@ static void fimd_commit(struct exynos_drm_manager *mgr) VIDTCON2_HOZVAL_E(mode->hdisplay - 1); writel(val, ctx->regs + driver_data->timing_base + VIDTCON2); - /* setup clock source, clock divider, enable dma. */ - val = ctx->vidcon0; - val &= ~(VIDCON0_CLKVAL_F_MASK | VIDCON0_CLKDIR); + /* + * fields of register with prefix '_F' would be updated + * at vsync(same as dma start) + */ + val = VIDCON0_ENVID | VIDCON0_ENVID_F; - if (ctx->driver_data->has_clksel) { - val &= ~VIDCON0_CLKSEL_MASK; + if (ctx->driver_data->has_clksel) val |= VIDCON0_CLKSEL_LCD; - } clkdiv = fimd_calc_clkdiv(ctx, mode); if (clkdiv > 1) val |= VIDCON0_CLKVAL_F(clkdiv - 1) | VIDCON0_CLKDIR; - else - val &= ~VIDCON0_CLKDIR; /* 1:1 clock */ - /* - * fields of register with prefix '_F' would be updated - * at vsync(same as dma start) - */ - val |= VIDCON0_ENVID | VIDCON0_ENVID_F; writel(val, ctx->regs + VIDCON0); }