From patchwork Fri Mar 28 11:52:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 3902621 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 2B2EE9F402 for ; Fri, 28 Mar 2014 11:53:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5F72E20263 for ; Fri, 28 Mar 2014 11:53:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 9F0142028D for ; Fri, 28 Mar 2014 11:53:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 975796EC7F; Fri, 28 Mar 2014 04:53:30 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout3.w1.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by gabe.freedesktop.org (Postfix) with ESMTP id E262C6EC7A for ; Fri, 28 Mar 2014 04:53:28 -0700 (PDT) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N3500KNLAD42SA0@mailout3.w1.samsung.com> for dri-devel@lists.freedesktop.org; Fri, 28 Mar 2014 11:53:28 +0000 (GMT) X-AuditID: cbfec7f5-b7fc96d000004885-1b-533562b75a3e Received: from eusync4.samsung.com ( [203.254.199.214]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id 6E.A8.18565.7B265335; Fri, 28 Mar 2014 11:53:27 +0000 (GMT) Received: from AMDC1061.digital.local ([106.116.147.88]) by eusync4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N3500JZBACMH5A0@eusync4.samsung.com>; Fri, 28 Mar 2014 11:53:27 +0000 (GMT) From: Andrzej Hajda To: dri-devel@lists.freedesktop.org Subject: [PATCH v3 03/12] drm/exynos: disallow fbdev initialization if no device is connected Date: Fri, 28 Mar 2014 12:52:38 +0100 Message-id: <1396007567-4015-4-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.8.3.2 In-reply-to: <1396007567-4015-1-git-send-email-a.hajda@samsung.com> References: <1396007567-4015-1-git-send-email-a.hajda@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLLMWRmVeSWpSXmKPExsVy+t/xa7rbk0yDDR7dU7e4te4cq8X8I0Di ytf3bBb9bxayWhz4s4PR4tyrlYwWk+5PYLE42/SG3WLG+X1MFmuP3GW3WHr9IpPFhOlrWSxa 9x5ht7i74SyjA5/HmnlrGD1mN1xk8bjc18vksXL5FzaPTas62TzuXNvD5nG/+ziTR9+WVYwe nzfJBXBGcdmkpOZklqUW6dslcGVcO7iSpWAdT8XLNZ+YGhj3cnUxcnJICJhItC56zQJhi0lc uLeerYuRi0NIYCmjxKbTr5lBEkICfUwSPRvDQGw2AU2Jv5tvsoHYIgLKEn8nrmIEaWAWeM8s sffKZEaQhLBAvMTP5dfBmlkEVCWe7P3MBGLzCjhJ7LraC7VNQWLZl7VgNZwCzhKr3k5kg1jm JHHneSPzBEbeBYwMqxhFU0uTC4qT0nON9IoTc4tL89L1kvNzNzFCgvjrDsalx6wOMQpwMCrx 8M6wMgkWYk0sK67MPcQowcGsJMK7xNY0WIg3JbGyKrUoP76oNCe1+BAjEwenVANjye33Si8O XvlmEZb7aIGpo/8h1r5/+r1XruY0Mmtqm934+fio7q0Hk7VP1H3Y5zqB52tIAUcb09foklTD vGxBZf1v79gM8w7Wu6db+r+49XW+3vNpC0/NkY/imn3pYOj0m3IPOl+XXAlcfd7h8zmP9y4T VrcG8i8rap4stKrVYpZLx9/YLM1lSizFGYmGWsxFxYkAqKCuSkACAAA= Cc: Mark Rutland , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Pawel Moll , Ian Campbell , Andrzej Hajda , Kyungmin Park , Rob Herring , Kumar Gala , Grant Likely , Marek Szyprowski X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds explicit check if there is a connector with connected status before fbdev initialization. It prevents creation of default fbdev 1024x768 which is unusable on panels with bigger resolutions. Signed-off-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c index e7c2f2d..e09449a 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c @@ -237,6 +237,24 @@ static struct drm_fb_helper_funcs exynos_drm_fb_helper_funcs = { .fb_probe = exynos_drm_fbdev_create, }; +bool exynos_drm_fbdev_is_anything_connected(struct drm_device *dev) +{ + struct drm_connector *connector; + bool ret = false; + + mutex_lock(&dev->mode_config.mutex); + list_for_each_entry(connector, &dev->mode_config.connector_list, head) { + if (connector->status != connector_status_connected) + continue; + + ret = true; + break; + } + mutex_unlock(&dev->mode_config.mutex); + + return ret; +} + int exynos_drm_fbdev_init(struct drm_device *dev) { struct exynos_drm_fbdev *fbdev; @@ -248,6 +266,9 @@ int exynos_drm_fbdev_init(struct drm_device *dev) if (!dev->mode_config.num_crtc || !dev->mode_config.num_connector) return 0; + if (!exynos_drm_fbdev_is_anything_connected(dev)) + return 0; + fbdev = kzalloc(sizeof(*fbdev), GFP_KERNEL); if (!fbdev) return -ENOMEM;