From patchwork Tue Apr 15 13:33:01 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 3992991 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 59930BFF02 for ; Tue, 15 Apr 2014 13:33:20 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2D9B32022D for ; Tue, 15 Apr 2014 13:33:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id C9669201FA for ; Tue, 15 Apr 2014 13:33:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4EF846E218; Tue, 15 Apr 2014 06:33:16 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by gabe.freedesktop.org (Postfix) with ESMTP id AC8946E218 for ; Tue, 15 Apr 2014 06:33:15 -0700 (PDT) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N4200EJ5QZCE830@mailout1.w1.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 15 Apr 2014 14:33:12 +0100 (BST) X-AuditID: cbfec7f5-b7fc96d000004885-9b-534d3519c35b Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm2.samsung.com (EUCPMTA) with SMTP id D2.86.18565.9153D435; Tue, 15 Apr 2014 14:33:13 +0100 (BST) Received: from AMDC1061.digital.local ([106.116.147.88]) by eusync3.samsung.com (Oracle Communications Messaging Server 7u4-23.01 (7.0.4.23.0) 64bit (built Aug 10 2011)) with ESMTPA id <0N4200HKYQZ9U670@eusync3.samsung.com>; Tue, 15 Apr 2014 14:33:13 +0100 (BST) From: Andrzej Hajda To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm/exynos: balance framebuffer refcount Date: Tue, 15 Apr 2014 15:33:01 +0200 Message-id: <1397568781-23108-1-git-send-email-a.hajda@samsung.com> X-Mailer: git-send-email 1.8.3.2 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHJMWRmVeSWpSXmKPExsVy+t/xq7qSpr7BBndaWC1urTvHanHl63s2 i0n3J7BYzDi/j8li7ZG77BbrZ7xmcWDzuN99nMmjb8sqRo/Pm+QCmKO4bFJSczLLUov07RK4 Mq6fPMpYMJGjYu13wwbGH2xdjJwcEgImEgcXX2eEsMUkLtxbDxTn4hASWMoocXj+dhYIp49J Ys+672BVbAKaEn833wTrFhFQlvg7cRUjSBGzwD5GiWnNq1lBEsIClhJbrr5nArFZBFQl7nzf CBTn4OAVcJZov+MCsU1BYtmXtcwTGLkXMDKsYhRNLU0uKE5KzzXSK07MLS7NS9dLzs/dxAgJ g687GJceszrEKMDBqMTDO+Gdd7AQa2JZcWXuIUYJDmYlEd6P3L7BQrwpiZVVqUX58UWlOanF hxiZODilGhjXTt30kK2g7tWfjUECz2wXz5kzvXdvyLVJPmpqTjk5FRZBesY3BNW+G07VN2L8 5n6YT/v6fCnH55o1cmwfXDSeBh9Syz0l0dV4+4kfw4ryF+I29nkRdgs/PRO8XD8h1bZv+7wr 3FF1y29WCNcImy35UxF0Jn7S3HNi7Pv279X9oLtRqtGlyleJpTgj0VCLuag4EQAtq+gQ4QEA AA== Cc: Andrzej Hajda , linux-samsung-soc@vger.kernel.org, Marek Szyprowski X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP exynos_drm_crtc_mode_set assigns primary framebuffer to plane without taking reference. Then during framebuffer removal it is dereferenced twice, causing oops. The patch fixes it. Signed-off-by: Andrzej Hajda --- Hi, This patch fixes framebuffer refcount balancing. The issue appeared after merge of universal plane related patches. Similar issue affected omap [1]. [1]: http://permalink.gmane.org/gmane.comp.video.dri.devel/104108 Regards Andrzej --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c index e930d4f..1ef5ab9 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c @@ -145,6 +145,7 @@ exynos_drm_crtc_mode_set(struct drm_crtc *crtc, struct drm_display_mode *mode, plane->crtc = crtc; plane->fb = crtc->primary->fb; + drm_framebuffer_reference(plane->fb); return 0; }