From patchwork Wed Apr 16 15:12:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Stanislawski X-Patchwork-Id: 4002261 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 792D29F375 for ; Wed, 16 Apr 2014 15:13:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BDD3E20155 for ; Wed, 16 Apr 2014 15:13:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id EECD920176 for ; Wed, 16 Apr 2014 15:13:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E53A06E3D5; Wed, 16 Apr 2014 08:13:19 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id 66A936E3D5 for ; Wed, 16 Apr 2014 08:13:19 -0700 (PDT) Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N4400HE5QA6XM20@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 17 Apr 2014 00:13:18 +0900 (KST) X-AuditID: cbfee61b-b7f456d000006dfd-c5-534e9e0e217b Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id C9.10.28157.E0E9E435; Thu, 17 Apr 2014 00:13:18 +0900 (KST) Received: from mcdsrvbld02.digital.local ([106.116.37.23]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N44001CNQ9OVS50@mmp2.samsung.com>; Thu, 17 Apr 2014 00:13:17 +0900 (KST) From: Tomasz Stanislawski To: linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCHv3 2/5] drm: exynos: hdmi: simplify extracting hpd-gpio from DT Date: Wed, 16 Apr 2014 17:12:55 +0200 Message-id: <1397661178-6016-3-git-send-email-t.stanislaws@samsung.com> X-Mailer: git-send-email 1.7.10.4 In-reply-to: <1397661178-6016-1-git-send-email-t.stanislaws@samsung.com> References: <1397661178-6016-1-git-send-email-t.stanislaws@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFLMWRmVeSWpSXmKPExsVy+t9jQV2+eX7BBvs28FlsnLGe1eLK1/ds FpPuT2CxeHHvIovF2aY37BYP5t5ksphxfh+TxcV18hYTpq9lsZiy6DCrReveI+wWMya/ZLNY P+M1i8W89pesDnwea+atYfTYtKqTzeN+93Emj/6/Bh59W1YxenzeJBfAFsVlk5Kak1mWWqRv l8CVcWvtduaCzewVW9c2MDcwTmfrYuTkkBAwkbi35QszhC0mceHeeqA4F4eQwHRGiUVv9jNB OF1MErtPH2ABqWID6ji25DNjFyMHh4iAm8Ss/6wgNcwCu5gkli3fA1YjLOAn8XHla0YQm0VA VWLHvOVMIDavgLvE7u7dTBDbFCW6n00Au4JTwENiyflWsF4hoJre+V2MExh5FzAyrGIUTS1I LihOSs810itOzC0uzUvXS87P3cQIDtFn0jsYVzVYHGIU4GBU4uGdmeMbLMSaWFZcmXuIUYKD WUmE13KaX7AQb0piZVVqUX58UWlOavEhRmkOFiVx3oOt1oFCAumJJanZqakFqUUwWSYOTqkG RkWHbwn5784o3Fp4Sd6ym71AJzJL41d1JgNj0etbdx9b3puz/uydHWUd/J+ydhly73VyOzX9 9zOLi89aX10T2xrb/FlE8LXZljd73xpN8C/x28x0v+DkZf9/PbsPfLx8x3iBjJ5DUgHDkWm7 fvxi/++i8pwj6GTV2yVZf1K2uvdoaBpsf6kXIqfEUpyRaKjFXFScCADBwEnyTQIAAA== Cc: Tomasz Stanislawski , pawel.moll@arm.com, b.zolnierkie@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, robh+dt@kernel.org, rahul.sharma@samsung.com, m.chehab@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch eliminates redundant checks while retrieving HPD gpio from DT during HDMI's probe(). Signed-off-by: Tomasz Stanislawski --- drivers/gpu/drm/exynos/exynos_hdmi.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index 482ca77..176e764 100644 --- a/drivers/gpu/drm/exynos/exynos_hdmi.c +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c @@ -2012,15 +2012,12 @@ fail: static int drm_hdmi_dt_parse(struct hdmi_context *hdata, struct device_node *np) { - u32 value; - - if (!of_find_property(np, "hpd-gpio", &value)) { + hdata->hpd_gpio = of_get_named_gpio(np, "hpd-gpio", 0); + if (!gpio_is_valid(hdata->hpd_gpio)) { DRM_ERROR("no hpd gpio property found\n"); return -ENOENT; } - hdata->hpd_gpio = of_get_named_gpio(np, "hpd-gpio", 0); - return 0; }