From patchwork Wed Apr 16 15:12:56 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Stanislawski X-Patchwork-Id: 4002291 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E14E5BFF02 for ; Wed, 16 Apr 2014 15:13:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 228AA20176 for ; Wed, 16 Apr 2014 15:13:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id D69062035C for ; Wed, 16 Apr 2014 15:13:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 252B66E3CD; Wed, 16 Apr 2014 08:13:24 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A5F56E079 for ; Wed, 16 Apr 2014 08:13:23 -0700 (PDT) Received: from epcpsbgm2.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N4400JUXQAASK70@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 17 Apr 2014 00:13:22 +0900 (KST) X-AuditID: cbfee61b-b7f456d000006dfd-cb-534e9e12467b Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id AF.10.28157.21E9E435; Thu, 17 Apr 2014 00:13:22 +0900 (KST) Received: from mcdsrvbld02.digital.local ([106.116.37.23]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N44001CNQ9OVS50@mmp2.samsung.com>; Thu, 17 Apr 2014 00:13:22 +0900 (KST) From: Tomasz Stanislawski To: linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCHv3 3/5] drm: exynos: mixer: fix using usleep() in atomic context Date: Wed, 16 Apr 2014 17:12:56 +0200 Message-id: <1397661178-6016-4-git-send-email-t.stanislaws@samsung.com> X-Mailer: git-send-email 1.7.10.4 In-reply-to: <1397661178-6016-1-git-send-email-t.stanislaws@samsung.com> References: <1397661178-6016-1-git-send-email-t.stanislaws@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrJLMWRmVeSWpSXmKPExsVy+t9jQV2heX7BBnsPyltsnLGe1eLK1/ds FpPuT2CxeHHvIovF2aY37BYP5t5ksphxfh+TxcV18hYTpq9lsZiy6DCrReveI+wWMya/ZLNY P+M1i8W89pesDnwea+atYfTYtKqTzeN+93Emj/6/Bh59W1YxenzeJBfAFsVlk5Kak1mWWqRv l8CVcbL5IXPBGfaKxbMXMzcwbmDrYuTkkBAwkfgx8zoLhC0mceHeeqA4F4eQwHRGiUt35oIV CQl0MUm8mJYFYrMBNRxb8pmxi5GDQ0TATWLWf1aQemaBXUwSy5bvARskLOAvcWzxDDCbRUBV YsXJCawgNq+Au8SFZX3MEMsUJbqfTQCbzyngIbHkfCsLxC53id75XYwTGHkXMDKsYhRNLUgu KE5KzzXSK07MLS7NS9dLzs/dxAgO0GfSOxhXNVgcYhTgYFTi4Z2Z4xssxJpYVlyZe4hRgoNZ SYTXcppfsBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHeg63WgUIC6YklqdmpqQWpRTBZJg5OqQbG jfYX1ke3dQqv9tCNMlYLuOYy48iK1opDMqfb/4TrM1xmO7jdoK9mvhe74SSze6cWfgs10T1Q fXr5r8TeyorVvzMcmDY/yDE788Tk7uzZy6e8737waFdpuOCxI113Fxw92ttlzqJ2kytjttDa BZt1u2OEjs1sX3gy4ntZxMnoI8Zp/Zsezp3yTImlOCPRUIu5qDgRAOdMyQhMAgAA Cc: Tomasz Stanislawski , pawel.moll@arm.com, b.zolnierkie@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, robh+dt@kernel.org, rahul.sharma@samsung.com, m.chehab@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes calling usleep_range() after taking reg_slock using spin_lock_irqsave(). The mdelay() is used instead. Waiting in atomic context is not the best idea in general. Hopefully, waiting occurs only when Video Processor fails to reset correctly. Signed-off-by: Tomasz Stanislawski --- drivers/gpu/drm/exynos/exynos_mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index ce28881..e3306c8 100644 --- a/drivers/gpu/drm/exynos/exynos_mixer.c +++ b/drivers/gpu/drm/exynos/exynos_mixer.c @@ -615,7 +615,7 @@ static void vp_win_reset(struct mixer_context *ctx) /* waiting until VP_SRESET_PROCESSING is 0 */ if (~vp_reg_read(res, VP_SRESET) & VP_SRESET_PROCESSING) break; - usleep_range(10000, 12000); + mdelay(10); } WARN(tries == 0, "failed to reset Video Processor\n"); }