From patchwork Thu Apr 17 05:50:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inki Dae X-Patchwork-Id: 4005721 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 145059F319 for ; Thu, 17 Apr 2014 05:50:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 42AA42034F for ; Thu, 17 Apr 2014 05:50:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 54341202FF for ; Thu, 17 Apr 2014 05:50:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 685F76EB02; Wed, 16 Apr 2014 22:50:47 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E5586EAFB for ; Wed, 16 Apr 2014 22:50:46 -0700 (PDT) Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N4500F1GUW79730@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 17 Apr 2014 14:50:31 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.114]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id FC.57.10092.7AB6F435; Thu, 17 Apr 2014 14:50:31 +0900 (KST) X-AuditID: cbfee68f-b7f156d00000276c-50-534f6ba79c10 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id A1.53.29263.6AB6F435; Thu, 17 Apr 2014 14:50:30 +0900 (KST) Received: from daeinki-desktop.10.32.193.11 ([10.252.83.67]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N4500C1SUW6AQ10@mmp2.samsung.com>; Thu, 17 Apr 2014 14:50:30 +0900 (KST) From: Inki Dae To: airlied@linux.ie, dri-devel@lists.freedesktop.org Subject: [PATCH 1/5] drm/exynos: modify goto labels to meaningful names Date: Thu, 17 Apr 2014 14:50:25 +0900 Message-id: <1397713829-25776-2-git-send-email-inki.dae@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1397713829-25776-1-git-send-email-inki.dae@samsung.com> References: <1397713829-25776-1-git-send-email-inki.dae@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgkeLIzCtJLcpLzFFi42JZI2JSpLs82z/Y4OpTdotb686xWvSeO8lk ceXrezaLSfcnsFi8uHeRxeJs0xt2ixnn9zFZ3N1wltFixuSXbA6cHrMbLrJ4bP/2gNXjfvdx Jo++LasYPT5vkgtgjeKySUnNySxLLdK3S+DKeHJqGUvBTMWKWQvuszYwHpDuYuTkkBAwkWhq n88IYYtJXLi3nq2LkYtDSGApo0T3yoVsMEX3VjaxQySmM0rseHGLBcLpZpJYsG43M0gVm4Cq xMQV98E6RARMJTomLQUrYhY4xCix7tZXsISwgLtE/7H/TCA2C1DD2o5eVhCbV8BFYm7fCqAa DqB1ChJzJtmAhDkFXCV27doIFhYCKmmfWAgyUkJgFbvEnjd9zBBjBCS+TT7EAtEqK7HpADPE 0ZISB1fcYJnAKLyAkWEVo2hqQXJBcVJ6kbFecWJucWleul5yfu4mRmDon/73rH8H490D1ocY k4HGTWSWEk3OB8ZOXkm8obGZkYWpiamxkbmlGWnCSuK89x8mBQkJpCeWpGanphakFsUXleak Fh9iZOLglGpg3GlrtLOCoy5ILep+16dAYWVR+dBdMwqS5x42evNy9TGdhWXbZXdwXNo+Z+30 2Ifdrcfq1omyOtvuaeM/2L375OwnZlYnHFpyDra27u9g4+q23L9PwCFCO3dOtG2hnRWDxG3j pSXhj+t+Goa1nD958My21ZrrjaSX7kzt/TLFIupGSgOX6bl8JZbijERDLeai4kQAciIHqJMC AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsVy+t9jQd1l2f7BBsfWW1vcWneO1aL33Ekm iytf37NZTLo/gcXixb2LLBZnm96wW8w4v4/J4u6Gs4wWMya/ZHPg9JjdcJHFY/u3B6we97uP M3n0bVnF6PF5k1wAa1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6q rZKLT4CuW2YO0EVKCmWJOaVAoYDE4mIlfTtME0JD3HQtYBojdH1DguB6jAzQQMIaxownp5ax FMxUrJi14D5rA+MB6S5GTg4JAROJeyub2CFsMYkL99azdTFycQgJTGeU2PHiFguE080ksWDd bmaQKjYBVYmJK+6zgdgiAqYSHZOWghUxCxxilFh36ytYQljAXaL/2H8mEJsFqGFtRy8riM0r 4CIxt28FUA0H0DoFiTmTbEDCnAKuErt2bQQLCwGVtE8snMDIu4CRYRWjaGpBckFxUnquoV5x Ym5xaV66XnJ+7iZGcGQ9k9rBuLLB4hCjAAejEg/vBHX/YCHWxLLiylygWziYlUR4xcOAQrwp iZVVqUX58UWlOanFhxiTgW6ayCwlmpwPjPq8knhDYxMzI0sjc0MLI2Nz0oSVxHkPtFoHCgmk J5akZqemFqQWwWxh4uCUamDc/eam/nzrwMvXHL0Vj0bwRs2uazebMLVs37bVXc3W23y73zMv O8Lvslq3UuRUj0+ce7bK1XCViafleBWOLAoMZDSPrnE9V8Jeyd326FOD95yDk1bo13ZfKfy9 ImTuvs/XLfusvirUet0SyxcRc5tw/fPNohNlrhMvFj57zVM2+ehVu58FRy8qsRRnJBpqMRcV JwIAFkoaQfACAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: linux-samsung-soc@vger.kernel.org, sw0312.kim@samsung.com, a.hajda@samsung.com, kyungmin.park@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 55 +++++++++++++++---------------- 1 file changed, 27 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index 2d27ba2..b3ba043 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c @@ -447,139 +447,138 @@ static int __init exynos_drm_init(void) #ifdef CONFIG_DRM_EXYNOS_DP ret = platform_driver_register(&dp_driver); if (ret < 0) - goto out_dp; + return ret; #endif #ifdef CONFIG_DRM_EXYNOS_DSI ret = platform_driver_register(&dsi_driver); if (ret < 0) - goto out_dsi; + goto err_unregister_dp_drv; #endif #ifdef CONFIG_DRM_EXYNOS_FIMD ret = platform_driver_register(&fimd_driver); if (ret < 0) - goto out_fimd; + goto err_unregister_dsi_drv; #endif #ifdef CONFIG_DRM_EXYNOS_HDMI ret = platform_driver_register(&hdmi_driver); if (ret < 0) - goto out_hdmi; + goto err_unregister_fimd_drv; ret = platform_driver_register(&mixer_driver); if (ret < 0) - goto out_mixer; + goto err_unregister_hdmi_drv; #endif #ifdef CONFIG_DRM_EXYNOS_VIDI ret = platform_driver_register(&vidi_driver); if (ret < 0) - goto out_vidi; + goto err_unregister_mixer_drv; #endif #ifdef CONFIG_DRM_EXYNOS_G2D ret = platform_driver_register(&g2d_driver); if (ret < 0) - goto out_g2d; + goto err_unregister_vidi_drv; #endif #ifdef CONFIG_DRM_EXYNOS_FIMC ret = platform_driver_register(&fimc_driver); if (ret < 0) - goto out_fimc; + goto err_unregister_g2d_drv; #endif #ifdef CONFIG_DRM_EXYNOS_ROTATOR ret = platform_driver_register(&rotator_driver); if (ret < 0) - goto out_rotator; + goto err_unregister_fimc_drv; #endif #ifdef CONFIG_DRM_EXYNOS_GSC ret = platform_driver_register(&gsc_driver); if (ret < 0) - goto out_gsc; + goto err_unregister_rotator_drv; #endif #ifdef CONFIG_DRM_EXYNOS_IPP ret = platform_driver_register(&ipp_driver); if (ret < 0) - goto out_ipp; + goto err_unregister_gsc_drv; ret = exynos_platform_device_ipp_register(); if (ret < 0) - goto out_ipp_dev; + goto err_unregister_ipp_drv; #endif ret = platform_driver_register(&exynos_drm_platform_driver); if (ret < 0) - goto out_drm; + goto err_unregister_ipp_dev; exynos_drm_pdev = platform_device_register_simple("exynos-drm", -1, NULL, 0); if (IS_ERR(exynos_drm_pdev)) { ret = PTR_ERR(exynos_drm_pdev); - goto out; + goto err_unregister_drm_drv; } return 0; -out: +err_unregister_drm_drv: platform_driver_unregister(&exynos_drm_platform_driver); -out_drm: +err_unregister_ipp_dev: #ifdef CONFIG_DRM_EXYNOS_IPP exynos_platform_device_ipp_unregister(); -out_ipp_dev: +err_unregister_ipp_drv: platform_driver_unregister(&ipp_driver); -out_ipp: +err_unregister_gsc_drv: #endif #ifdef CONFIG_DRM_EXYNOS_GSC platform_driver_unregister(&gsc_driver); -out_gsc: +err_unregister_rotator_drv: #endif #ifdef CONFIG_DRM_EXYNOS_ROTATOR platform_driver_unregister(&rotator_driver); -out_rotator: +err_unregister_fimc_drv: #endif #ifdef CONFIG_DRM_EXYNOS_FIMC platform_driver_unregister(&fimc_driver); -out_fimc: +err_unregister_g2d_drv: #endif #ifdef CONFIG_DRM_EXYNOS_G2D platform_driver_unregister(&g2d_driver); -out_g2d: +err_unregister_vidi_drv: #endif #ifdef CONFIG_DRM_EXYNOS_VIDI platform_driver_unregister(&vidi_driver); -out_vidi: +err_unregister_mixer_drv: #endif #ifdef CONFIG_DRM_EXYNOS_HDMI platform_driver_unregister(&mixer_driver); -out_mixer: +err_unregister_hdmi_drv: platform_driver_unregister(&hdmi_driver); -out_hdmi: +err_unregister_fimd_drv: #endif #ifdef CONFIG_DRM_EXYNOS_FIMD platform_driver_unregister(&fimd_driver); -out_fimd: +err_unregister_dsi_drv: #endif #ifdef CONFIG_DRM_EXYNOS_DSI platform_driver_unregister(&dsi_driver); -out_dsi: +err_unregister_dp_drv: #endif #ifdef CONFIG_DRM_EXYNOS_DP platform_driver_unregister(&dp_driver); -out_dp: #endif return ret; }