From patchwork Thu Apr 17 05:52:31 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inki Dae X-Patchwork-Id: 4005791 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D3107BFF02 for ; Thu, 17 Apr 2014 05:52:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0F67620306 for ; Thu, 17 Apr 2014 05:52:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 26E6D20351 for ; Thu, 17 Apr 2014 05:52:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A2346EB07; Wed, 16 Apr 2014 22:52:42 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTP id 97F2D6EB07 for ; Wed, 16 Apr 2014 22:52:40 -0700 (PDT) Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N45005VSUZL5FB0@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Thu, 17 Apr 2014 14:52:33 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.116]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 99.12.09028.02C6F435; Thu, 17 Apr 2014 14:52:32 +0900 (KST) X-AuditID: cbfee68e-b7f566d000002344-73-534f6c204e55 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 59.1D.28157.02C6F435; Thu, 17 Apr 2014 14:52:32 +0900 (KST) Received: from daeinki-desktop.10.32.193.11 ([10.252.83.67]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N450037NUZKPL40@mmp1.samsung.com>; Thu, 17 Apr 2014 14:52:32 +0900 (KST) From: Inki Dae To: airlied@linux.ie, dri-devel@lists.freedesktop.org Subject: [PATCH] drm/exynos: dsi: remove unnecessary pm interfaces Date: Thu, 17 Apr 2014 14:52:31 +0900 Message-id: <1397713951-25872-1-git-send-email-inki.dae@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsWyRsSkRFchxz/Y4Ol7KYtb686xWvSeO8lk ceXrezaLSfcnsFi8uHeRxeJs0xt2ixnn9zFZ3N1wltFixuSXbA6cHrMbLrJ4bP/2gNXjfvdx Jo++LasYPT5vkgtgjeKySUnNySxLLdK3S+DKmL9gM3PBU76KT1+OsjYwzuXpYuTkkBAwkdja uYkdwhaTuHBvPVsXIxeHkMBSRoknp+6ywhRNm3mFCSKxiFFi16KHUE43k0Tn3YnMIFVsAqoS E1fcZwOxRQRMJTomLWUBKWIWOMQose7WV7CEsICTxO6Px4ESHBwsQA2T/pSAhHkFXCTW3DvE BhKWEFCQmDPJBqRVQmAyu8T8tm6wK1gEBCS+TT7EAlEjK7HpADPEcZISB1fcYJnAKLiAkWEV o2hqQXJBcVJ6kZFecWJucWleul5yfu4mRmAon/73rG8H480D1ocYk4HGTWSWEk3OB8ZCXkm8 obGZkYWpiamxkbmlGWnCSuK8ix4mBQkJpCeWpGanphakFsUXleakFh9iZOLglGpgZGtsPXq9 4Nt2v6unnuW4HDhYrPxFMVxKw/Vy357XJlwrxHVbW/bYznj4WS7Z8UvlsZOLylh+L11yefHH WftsE2+6LPaJXOMWdObO62VT/55b+DGmOlZawebLz/yMv9ybdSf8+ukf3jk/oGThKq3FOlfq xefLnlteW9vYn7EivXR2M+/7/n1+W5RYijMSDbWYi4oTAYpiJEV7AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKIsWRmVeSWpSXmKPExsVy+t9jAV2FHP9gg4ebhC1urTvHatF77iST xZWv79ksJt2fwGLx4t5FFouzTW/YLWac38dkcXfDWUaLGZNfsjlwesxuuMjisf3bA1aP+93H mTz6tqxi9Pi8SS6ANaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfV VsnFJ0DXLTMH6CIlhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGENY8b8BZuZ C57yVXz6cpS1gXEuTxcjJ4eEgInEtJlXmCBsMYkL99azdTFycQgJLGKU2LXoIROE080k0Xl3 IjNIFZuAqsTEFffZQGwRAVOJjklLWUCKmAUOMUqsu/UVLCEs4CSx++NxoAQHBwtQw6Q/JSBh XgEXiTX3DrGBhCUEFCTmTLKZwMi9gJFhFaNoakFyQXFSeq6RXnFibnFpXrpecn7uJkZwpDyT 3sG4qsHiEKMAB6MSDy/nb79gIdbEsuLKXKCdHMxKIrziYf7BQrwpiZVVqUX58UWlOanFhxiT gXZPZJYSTc4HRnFeSbyhsYmZkaWRuaGFkbE5acJK4rwHW60DhQTSE0tSs1NTC1KLYLYwcXBK ASP4j1VNX2DWnVDWGEEJvp9cRVKrmEwirl7d7LRuvvu6ODlTiYid0rM+XLCadW/qOf+39Y97 NPmDm+SZAhZXaT1Zf+B/8w2BcoZjznonb8tOXhRXudt3xp9wZvGna+5PD/JIZV0ftb7k0Bal VIMD16tNZDJqffSqf5xqfNA5+aDgiu2rpgubJCuxFGckGmoxFxUnAgD5iUuj2AIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: linux-samsung-soc@vger.kernel.org, sw0312.kim@samsung.com, a.hajda@samsung.com, kyungmin.park@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Exynos drm driver is a single driver so pm operation for kms drivers should be done by connector->dpms at top level driver. If kms driver has its own pm interfaces, single driver model would be broken so this patch removes unnecessary pm interfaces from dsi driver. Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 31 ------------------------------- 1 file changed, 31 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 09cc4bae..ae81124 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1412,36 +1412,6 @@ static void exynos_dsi_unbind(struct device *dev, struct device *master, drm_connector_cleanup(&dsi->connector); } -#if CONFIG_PM_SLEEP -static int exynos_dsi_resume(struct device *dev) -{ - struct exynos_dsi *dsi = exynos_dsi_display.ctx; - - if (dsi->state & DSIM_STATE_ENABLED) { - dsi->state &= ~DSIM_STATE_ENABLED; - exynos_dsi_enable(dsi); - } - - return 0; -} - -static int exynos_dsi_suspend(struct device *dev) -{ - struct exynos_dsi *dsi = exynos_dsi_display.ctx; - - if (dsi->state & DSIM_STATE_ENABLED) { - exynos_dsi_disable(dsi); - dsi->state |= DSIM_STATE_ENABLED; - } - - return 0; -} -#endif - -static const struct dev_pm_ops exynos_dsi_pm_ops = { - SET_SYSTEM_SLEEP_PM_OPS(exynos_dsi_suspend, exynos_dsi_resume) -}; - static const struct component_ops exynos_dsi_component_ops = { .bind = exynos_dsi_bind, .unbind = exynos_dsi_unbind, @@ -1545,7 +1515,6 @@ struct platform_driver dsi_driver = { .driver = { .name = "exynos-dsi", .owner = THIS_MODULE, - .pm = &exynos_dsi_pm_ops, .of_match_table = exynos_dsi_of_match, }, };