| Message ID | 1399622493-31701-2-git-send-email-sonika.jindal@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, May 09, 2014 at 01:31:22PM +0530, sonika.jindal@intel.com wrote: > From: Ville Syrjälä <ville.syrjala at linux.intel.com> > > The rotation property stuff should be standardized among all drivers. > Move the bits to drm_crtc.h from omap_drv.h. > > Cc: David Airlie <airlied@linux.ie> > Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> > Cc: Dave Airlie <airlied@redhat.com> > Cc: Rob Clark <robdclark@gmail.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Archit Taneja <archit@ti.com> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > Reviewed-by: Sagar Kamble <sagar.a.kamble@intel.com> > Tested-by: Sagar Kamble <sagar.a.kamble@intel.com> This is missing your Signed-off-by line. Also the patch subject says 01/12, where are the other eleven patches? Thierry
Hi Thierry, This patch was sent out by mistake. I am sorry for the confusion. I am working on further patchset based on these patches. Regards, Sonika On 5/13/2014 1:16 PM, Thierry Reding wrote: > On Fri, May 09, 2014 at 01:31:22PM +0530, sonika.jindal@intel.com wrote: >> From: Ville Syrjälä <ville.syrjala at linux.intel.com> >> >> The rotation property stuff should be standardized among all drivers. >> Move the bits to drm_crtc.h from omap_drv.h. >> >> Cc: David Airlie <airlied@linux.ie> >> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com> >> Cc: Dave Airlie <airlied@redhat.com> >> Cc: Rob Clark <robdclark@gmail.com> >> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> >> Cc: Archit Taneja <archit@ti.com> >> Cc: dri-devel@lists.freedesktop.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> >> Reviewed-by: Sagar Kamble <sagar.a.kamble@intel.com> >> Tested-by: Sagar Kamble <sagar.a.kamble@intel.com> > > This is missing your Signed-off-by line. Also the patch subject says > 01/12, where are the other eleven patches? > > Thierry >
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h b/drivers/gpu/drm/omapdrm/omap_drv.h index 428b2981..aac8e10 100644 --- a/drivers/gpu/drm/omapdrm/omap_drv.h +++ b/drivers/gpu/drm/omapdrm/omap_drv.h @@ -119,13 +119,6 @@ struct omap_drm_private { struct omap_drm_irq error_handler; }; -/* this should probably be in drm-core to standardize amongst drivers */ -#define DRM_ROTATE_0 0 -#define DRM_ROTATE_90 1 -#define DRM_ROTATE_180 2 -#define DRM_ROTATE_270 3 -#define DRM_REFLECT_X 4 -#define DRM_REFLECT_Y 5 #ifdef CONFIG_DEBUG_FS int omap_debugfs_init(struct drm_minor *minor); diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 27f828c..4775008 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -64,6 +64,14 @@ struct drm_object_properties { uint64_t values[DRM_OBJECT_MAX_PROPERTY]; }; +/* rotation property bits */ +#define DRM_ROTATE_0 0 +#define DRM_ROTATE_90 1 +#define DRM_ROTATE_180 2 +#define DRM_ROTATE_270 3 +#define DRM_REFLECT_X 4 +#define DRM_REFLECT_Y 5 + enum drm_connector_force { DRM_FORCE_UNSPECIFIED, DRM_FORCE_OFF,