From patchwork Tue May 27 12:42:43 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inki Dae X-Patchwork-Id: 4249131 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CBA4EBF90B for ; Tue, 27 May 2014 12:42:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 05D5E2017D for ; Tue, 27 May 2014 12:42:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 361F92017E for ; Tue, 27 May 2014 12:42:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 78A256E679; Tue, 27 May 2014 05:42:51 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTP id AA4EB6E420 for ; Tue, 27 May 2014 05:42:46 -0700 (PDT) Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N6800GJJGN97ZB0@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 27 May 2014 21:42:45 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.113]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id EA.12.16580.54884835; Tue, 27 May 2014 21:42:45 +0900 (KST) X-AuditID: cbfee691-b7f2f6d0000040c4-ad-538488457950 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id E1.DB.08203.54884835; Tue, 27 May 2014 21:42:45 +0900 (KST) Received: from daeinki-desktop.10.32.193.11 ([10.252.83.67]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N680038CGN7F010@mmp1.samsung.com>; Tue, 27 May 2014 21:42:45 +0900 (KST) From: Inki Dae To: airlied@linux.ie, dri-devel@lists.freedesktop.org Subject: [PATCH 2/2] drm/exynos: mipi-dsi: consider panel driver-deferred probe Date: Tue, 27 May 2014 21:42:43 +0900 Message-id: <1401194563-803-3-git-send-email-inki.dae@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1401194563-803-1-git-send-email-inki.dae@samsung.com> References: <1401194563-803-1-git-send-email-inki.dae@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRmVeSWpSXmKPExsWyRsSkUNe1oyXY4PdUeYtb686xWvSeO8lk ceXrezaLSfcnsFjMOL+PyWLzh5dsDmweLc09bB7bvz1g9bjffZzJo2/LKkaPz5vkAlijuGxS UnMyy1KL9O0SuDJmXrvAXjBXvOLR8X2sDYxnhLsYOTkkBEwk5u3dyQRhi0lcuLeerYuRi0NI YCmjRNOBjaxdjBxgResnpEHEFzFK3P1/ixnC6WaSePrqEiNIN5uAqsTEFffZQGwRAVOJjklL WUBsZoEqieub37GADBIW8Je48d8fxGQBKl/2RgWkglfASWLGzkWMEKsUJOZMsgEJcwo4SyxY 8JsdxBYCKllzYhETyFYJgensEm9utIDdzCIgIPFt8iEWiF5ZiU0HmCFekZQ4uOIGywRG4QWM DKsYRVMLkguKk9KLTPWKE3OLS/PS9ZLzczcxAsP69L9nE3cw3j9gfYgxGWjcRGYp0eR8YFzk lcQbGpsZWZiamBobmVuakSasJM6b/igpSEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVAPj6kP3 pGZdmi8aaffNm5ntzJUGvjXc1dM8y05O3/btj7j8vCcvdh6P7ObPOKvzz+rwrvj8p9Mf7Ho0 MY19T9fK/V0dUadZVRwd9ryMWtgfwhAys/GizYUTYeukDxp2B/Z/UH354pnI5kMv0q9OFlPY /2hXj5NkVP2H07W6f0U/m23Knnf46eZ+JyWW4oxEQy3mouJEAFqITneBAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNIsWRmVeSWpSXmKPExsVy+t9jAV3XjpZgg6NXxSxurTvHatF77iST xZWv79ksJt2fwGIx4/w+JovNH16yObB5tDT3sHls//aA1eN+93Emj74tqxg9Pm+SC2CNamC0 yUhNTEktUkjNS85PycxLt1XyDo53jjc1MzDUNbS0MFdSyEvMTbVVcvEJ0HXLzAE6QUmhLDGn FCgUkFhcrKRvh2lCaIibrgVMY4Sub0gQXI+RARpIWMOYMfPaBfaCueIVj47vY21gPCPcxcjB ISFgIrF+QloXIyeQKSZx4d56ti5GLg4hgUWMEnf/32KGcLqZJJ6+usQIUsUmoCoxccV9NhBb RMBUomPSUhYQm1mgSuL65ncsIEOFBfwlbvz3BzFZgMqXvVEBqeAVcJKYsXMRI8RaBYk5k2xA wpwCzhILFvxmB7GFgErWnFjENIGRdwEjwypG0dSC5ILipPRcQ73ixNzi0rx0veT83E2M4Kh5 JrWDcWWDxSFGAQ5GJR7eCb7NwUKsiWXFlbmHGCU4mJVEeMvaWoKFeFMSK6tSi/Lji0pzUosP MSYD3TSRWUo0OR8Y0Xkl8YbGJmZGlkbmhhZGxuakCSuJ8x5otQ4UEkhPLEnNTk0tSC2C2cLE wSnVwGj8oNM18shDy7N7TqYtZ1i36ElR/Z68VlOTY6JKksp7WJd8vdCW8neqfMe6VRtuXdnd z7Zh7nvdxZWNLzIb3V23HIzjsQ+4XFttV1mRfjP+9u0Dvk92Giik/0yrX3kjPb7rbOOsedYx kaJ1M6oexty4wS3WeS9gJmvTdyW7o0uNHp44P0Hxn7sSS3FGoqEWc1FxIgCxpYxS3gIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: a.hajda@samsung.com, linux-samsung-soc@vger.kernel.org, rmk+kernel@arm.linux.org.uk X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch makes sure that mipi dsi driver makes it re-probe in case that panel driver isn't probed yet. For this, it checks if panel driver is probed or not before component_add() is called. Signed-off-by: Inki Dae Acked-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 38 +++++++++++++++---------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 1421d9b..22503f3 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1166,11 +1166,8 @@ exynos_dsi_detect(struct drm_connector *connector, bool force) { struct exynos_dsi *dsi = connector_to_dsi(connector); - if (!dsi->panel) { - dsi->panel = of_drm_find_panel(dsi->panel_node); - if (dsi->panel) - drm_panel_attach(dsi->panel, &dsi->connector); - } else if (!dsi->panel_node) { + /* Power off if panel driver is removed. */ + if (!dsi->panel_node) { struct exynos_drm_display *display; display = platform_get_drvdata(to_platform_device(dsi->dev)); @@ -1383,19 +1380,8 @@ static int exynos_dsi_bind(struct device *dev, struct device *master, void *data) { struct drm_device *drm_dev = data; - struct exynos_dsi *dsi; - int ret; - ret = exynos_drm_create_enc_conn(drm_dev, &exynos_dsi_display); - if (ret) { - DRM_ERROR("Encoder create [%d] failed with %d\n", - exynos_dsi_display.type, ret); - return ret; - } - - dsi = exynos_dsi_display.ctx; - - return mipi_dsi_host_register(&dsi->dsi_host); + return exynos_drm_create_enc_conn(drm_dev, &exynos_dsi_display); } static void exynos_dsi_unbind(struct device *dev, struct device *master, @@ -1406,8 +1392,6 @@ static void exynos_dsi_unbind(struct device *dev, struct device *master, exynos_dsi_dpms(&exynos_dsi_display, DRM_MODE_DPMS_OFF); - mipi_dsi_host_unregister(&dsi->dsi_host); - encoder->funcs->destroy(encoder); drm_connector_cleanup(&dsi->connector); } @@ -1502,6 +1486,18 @@ static int exynos_dsi_probe(struct platform_device *pdev) platform_set_drvdata(pdev, &exynos_dsi_display); + ret = mipi_dsi_host_register(&dsi->dsi_host); + if (ret) + goto err_del_component; + + dsi->panel = of_drm_find_panel(dsi->panel_node); + if (!dsi->panel) { + mipi_dsi_host_unregister(&dsi->dsi_host); + return -EPROBE_DEFER; + } + + drm_panel_attach(dsi->panel, &dsi->connector); + ret = component_add(&pdev->dev, &exynos_dsi_component_ops); if (ret) goto err_del_component; @@ -1515,6 +1511,10 @@ err_del_component: static int exynos_dsi_remove(struct platform_device *pdev) { + struct exynos_dsi *dsi = exynos_dsi_display.ctx; + + mipi_dsi_host_unregister(&dsi->dsi_host); + component_del(&pdev->dev, &exynos_dsi_component_ops); exynos_drm_component_del(&pdev->dev);