From patchwork Mon Jun 2 05:22:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YoungJun Cho X-Patchwork-Id: 4279971 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C0E279F387 for ; Mon, 2 Jun 2014 05:23:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0DC4B203AD for ; Mon, 2 Jun 2014 05:23:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 28E64203AF for ; Mon, 2 Jun 2014 05:23:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9AB836E453; Sun, 1 Jun 2014 22:22:59 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by gabe.freedesktop.org (Postfix) with ESMTP id AAD2C6E364 for ; Sun, 1 Jun 2014 22:22:56 -0700 (PDT) Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N6J00HE60A6BG90@mailout3.samsung.com> for dri-devel@lists.freedesktop.org; Mon, 02 Jun 2014 14:22:54 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.45]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 25.18.16580.E2A0C835; Mon, 02 Jun 2014 14:22:54 +0900 (KST) X-AuditID: cbfee691-b7f2f6d0000040c4-bf-538c0a2e0f42 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 33.79.08203.E2A0C835; Mon, 02 Jun 2014 14:22:54 +0900 (KST) Received: from localhost.localdomain ([10.252.75.90]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N6J00KWX0A3O8D0@mmp2.samsung.com>; Mon, 02 Jun 2014 14:22:54 +0900 (KST) From: YoungJun Cho To: airlied@linux.ie, dri-devel@lists.freedesktop.org Subject: [PATCH v3 02/15] drm/exynos: use wait_event_timeout() for safety usage Date: Mon, 02 Jun 2014 14:22:38 +0900 Message-id: <1401686571-22148-3-git-send-email-yj44.cho@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1401686571-22148-1-git-send-email-yj44.cho@samsung.com> References: <1401686571-22148-1-git-send-email-yj44.cho@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKIsWRmVeSWpSXmKPExsVy+t8zXV09rp5gg5+X1C1urTvHatF77iST xfwjQNaVr+/ZLPrfLGS1OPdqJaPFpPsTWCxe3LvIYtG74CqbxdmmN+wWM87vY7JYev0ik8WE 6WtZLFr3HgGKTX7JZvFz1zwWBwGPNfPWMHpc7utl8tg56y67x8rlX9g8Nq3qZPPY/u0Bq8f9 7uNMHn1bVjF6fN4kF8AZxWWTkpqTWZZapG+XwJVxcMIMloKDvBUfVv9ibGA8yt3FyMkhIWAi 8f9GEwuELSZx4d56ti5GLg4hgWWMEh8XLABKcIAV7W30h4hPZ5T4tm01M0iDkEArk8TplU4g NpuApsTzjztYQWwRAVOJjklLWUAamAWeMEmc2rwfbIOwgL9Ew8KlYDaLgKrE9lf7wAbxCrhI TG4+ygSxTEFiziQbkDCngKvE4QebWCF2uUi8WTaNFeLQv+wS9w4KQYwRkPg2+RDUnbISmw4w Q5RIShxccYNlAqPwAkaGVYyiqQXJBcVJ6UWmesWJucWleel6yfm5mxghUTZxB+P9A9aHGJOB xk1klhJNzgdGaV5JvKGxmZGFqYmpsZG5pRlpwkrivOmPkoKEBNITS1KzU1MLUovii0pzUosP MTJxcEo1MNr937ZE5dyqv3n8+wyT9mUcXfDi7YYCC5667Da5m1M017n7FXyfd96qwX9Rz9ym xjNx0RFqBxf7Zgmxnl276BjnNQXGvfNmvZJonVZsFfdB8IuqeaTefG2nf+9WqZTc3c2wi3OO gFdJptK2Cw9vLr177IXi3kMyptKbq12j7tff0aib5Wfy/qESS3FGoqEWc1FxIgAbCabhyAIA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMKsWRmVeSWpSXmKPExsVy+t9jQV09rp5ggwOzlC1urTvHatF77iST xfwjQNaVr+/ZLPrfLGS1OPdqJaPFpPsTWCxe3LvIYtG74CqbxdmmN+wWM87vY7JYev0ik8WE 6WtZLFr3HgGKTX7JZvFz1zwWBwGPNfPWMHpc7utl8tg56y67x8rlX9g8Nq3qZPPY/u0Bq8f9 7uNMHn1bVjF6fN4kF8AZ1cBok5GamJJapJCal5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeY m2qr5OIToOuWmQP0iJJCWWJOKVAoILG4WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsI4x4+CE GSwFB3krPqz+xdjAeJS7i5GDQ0LARGJvo38XIyeQKSZx4d56ti5GLg4hgemMEt+2rWYGSQgJ tDJJnF7pBGKzCWhKPP+4gxXEFhEwleiYtJQFpIFZ4AmTxKnN+1lAEsIC/hINC5eC2SwCqhLb X+0DG8Qr4CIxufkoE8RiBYk5k2xAwpwCrhKHH2xihdjlIvFm2TTWCYy8CxgZVjGKphYkFxQn peca6hUn5haX5qXrJefnbmIER/EzqR2MKxssDjEKcDAq8fBOWNAVLMSaWFZcmXuIUYKDWUmE 9+jZ7mAh3pTEyqrUovz4otKc1OJDjMlAR01klhJNzgcmmLySeENjEzMjSyMzYxNzY2PShJXE eQ+0WgcKCaQnlqRmp6YWpBbBbGHi4JRqYBS59a4oIFy1eMW2F19SVkqkCS0XNlu5nV3Fd/7R zts/bf9pX1p6VDX6dbZFiHKs0Tr/ZW2/DDMFBTccSlw06a6Y6LvXTZ/X1PJmtN18bVhrevF9 LU/LPLYgtitXOdWvOVd0fc+SDOWuTeEzzvTeYX9B2nhb4/rFn2vmHz5n970o462MfExGthJL cUaioRZzUXEiAEidVx8mAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, sw0312.kim@samsung.com, a.hajda@samsung.com, kyungmin.park@samsung.com, robh+dt@kernel.org, galak@codeaurora.org, kgene.kim@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There could be the case that the page flip operation isn't finished correctly with some abnormal condition such as panel reset. So this patch replaces wait_event() with wait_event_timeout() to avoid waiting for page flip completion infinitely. And clears exynos_crtc->pending_flip in exynos_drm_crtc_page_flip() when exynos_drm_crtc_mode_set_commit() is failed. Signed-off-by: YoungJun Cho Acked-by: Inki Dae Acked-by: Kyungmin Park Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c index 95c9435..3bf091d 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c @@ -69,8 +69,10 @@ static void exynos_drm_crtc_dpms(struct drm_crtc *crtc, int mode) if (mode > DRM_MODE_DPMS_ON) { /* wait for the completion of page flip. */ - wait_event(exynos_crtc->pending_flip_queue, - atomic_read(&exynos_crtc->pending_flip) == 0); + if (!wait_event_timeout(exynos_crtc->pending_flip_queue, + !atomic_read(&exynos_crtc->pending_flip), + HZ/20)) + atomic_set(&exynos_crtc->pending_flip, 0); drm_vblank_off(crtc->dev, exynos_crtc->pipe); } @@ -259,6 +261,7 @@ static int exynos_drm_crtc_page_flip(struct drm_crtc *crtc, spin_lock_irq(&dev->event_lock); drm_vblank_put(dev, exynos_crtc->pipe); list_del(&event->base.link); + atomic_set(&exynos_crtc->pending_flip, 0); spin_unlock_irq(&dev->event_lock); goto out;